Skip to content

Venus cleanups

Konrad Dybcio linux-arm-msm linux-media lkml 4 versions – In review

Get series with b4
b4 am [email protected] change-id 20230911-topic-mars-e60bb2269411

Versions newest first

  1. v3 Latest19 patches 28 repliesIn review
  2. v2 posting 2/220 patches 29 repliesSuperseded
  3. v2 posting 1/25 of 20 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v120 patches5 repliesSuperseded

Changes in v3 from the cover letter

- Drop const within const patch
- Pick up tags
- Some stylistic fixes in kerneldoc
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19media: venus: pm_helpers: Only set rate of the core clock in core_clks_enabledrivers/media/platform/qcom/venus/pm_helpers.c+11 -122 replies
2/19media: venus: pm_helpers: Rename core_clks_get to venus_clks_getdrivers/media/platform/qcom/venus/pm_helpers.c+3 -31 reply
3/19media: venus: pm_helpers: Add kerneldoc to venus_clks_get()drivers/media/platform/qcom/venus/pm_helpers.c+28 -05 replies
4/19media: venus: core: Set OPP clkname in a common code pathdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/pm_helpers.c+7 -211 reply
5/19media: venus: pm_helpers: Kill dead codedrivers/media/platform/qcom/venus/pm_helpers.c+0 -103 replies
6/19media: venus: pm_helpers: Move reset acquisition to common codedrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/pm_helpers.c+8 -241 reply
7/19media: venus: core: Deduplicate OPP genpd namesdrivers/media/platform/qcom/venus/core.c+7 -41 reply
8/19media: venus: core: Get rid of vcodec_numdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/pm_helpers.c+1 -72 replies
9/19media: venus: core: Drop cache properties in resource structdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/hfi_venus.c+4 -331 reply
10/19media: venus: core: Use GENMASK for dma_maskdrivers/media/platform/qcom/venus/core.c+7 -71 reply
11/19media: venus: core: Remove cp_startdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/firmware.c+1 -71 reply
12/19media: venus: pm_helpers: Commonize core_powerdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/pm_helpers.c drivers/media/platform/qcom/venus/pm_helpers.h+9 -311 reply
13/19media: venus: pm_helpers: Remove pm_ops->core_putdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/pm_helpers.c drivers/media/platform/qcom/venus/pm_helpers.h+5 -221 reply
14/19media: venus: core: Define a pointer to core->resdrivers/media/platform/qcom/venus/core.c+7 -42 replies
15/19media: venus: pm_helpers: Simplify vcodec clock handlingdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/pm_helpers.c+71 -891 reply
16/19media: venus: pm_helpers: Commonize getting clocks and GenPDsdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/pm_helpers.c drivers/media/platform/qcom/venus/pm_helpers.h+5 -111 reply
17/19media: venus: pm_helpers: Commonize vdec_get()drivers/media/platform/qcom/venus/pm_helpers.c drivers/media/platform/qcom/venus/pm_helpers.h drivers/media/platform/qcom/venus/vdec.c+10 -231 reply
18/19media: venus: pm_helpers: Commonize venc_get()drivers/media/platform/qcom/venus/pm_helpers.c drivers/media/platform/qcom/venus/pm_helpers.h drivers/media/platform/qcom/venus/venc.c+7 -221 reply
19/19media: venus: pm_helpers: Use reset_bulk APIdrivers/media/platform/qcom/venus/core.c drivers/media/platform/qcom/venus/core.h drivers/media/platform/qcom/venus/pm_helpers.c+15 -191 reply

Reviews trailers per patch

13 of 19 patches have a Reviewed-by or Acked-by.

PatchBryan O'DonoghuePhilipp ZabelDikshita Agarwal
1/19
2/19R-b
3/19R-b
4/19R-b
5/19
6/19R-b
7/19R-b R-b
8/19R-b
9/19R-b R-b
10/19R-b R-b
11/19R-b R-b
12/19R-b
13/19R-b
14/19R-b R-b
15/19
16/19
17/19
18/19
19/19R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/19] Venus cleanups

With the driver supporting multiple generations of hardware, some mold has definitely grown over the code..

This series attempts to amend this situation a bit by commonizing some code paths and fixing some bugs while at it.

Only tested on SM8250.

Definitely needs testing on:

- SDM845 with old bindings
- SDM845 with new bindings or 7180
- MSM8916
- MSM8996

---
Changes in v3:
- Drop const within const patch
- Pick up tags
- Some stylistic fixes in kerneldoc
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Fix "set but unused" warning in "Drop cache properties in resource struct"
- Fix modular build with "Commonize vdec_get()"
- Rebase
- Test again on 8250, since nobody else tested other platforms since the last submission (or at least hasn't reported that), I'm assuming nobody cares
- Needs to be tested atop [1] and similar, it's in latest -next already
- Link to v1: https://lore.kernel.org/r/[email protected]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=d2cd22c9c384aa50c0b4530e842bd078427e6279

---
Konrad Dybcio (19):
media: venus: pm_helpers: Only set rate of the core clock in core_clks_enable
media: venus: pm_helpers: Rename core_clks_get to venus_clks_get
media: venus: pm_helpers: Add kerneldoc to venus_clks_get()
media: venus: core: Set OPP clkname in a common code path
media: venus: pm_helpers: Kill dead code
media: venus: pm_helpers: Move reset acquisition to common code
media: venus: core: Deduplicate OPP genpd names
media: venus: core: Get rid of vcodec_num
media: venus: core: Drop cache properties in resource struct
media: venus: core: Use GENMASK for dma_mask
media: venus: core: Remove cp_start
media: venus: pm_helpers: Commonize core_power
media: venus: pm_helpers: Remove pm_ops->core_put
media: venus: core: Define a pointer to core->res
media: venus: pm_helpers: Simplify vcodec clock handling
media: venus: pm_helpers: Commonize getting clocks and GenPDs
media: venus: pm_helpers: Commonize vdec_get()
media: venus: pm_helpers: Commonize venc_get()
media: venus: pm_helpers: Use reset_bulk API

 drivers/media/platform/qcom/venus/core.c       | 139 ++++-------
 drivers/media/platform/qcom/venus/core.h       |  22 +-
 drivers/media/platform/qcom/venus/firmware.c   |   3 +-
 drivers/media/platform/qcom/venus/hfi_venus.c  |  10 +-
 drivers/media/platform/qcom/venus/pm_helpers.c | 323 +++++++++----------------
 drivers/media/platform/qcom/venus/pm_helpers.h |  10 +-
 drivers/media/platform/qcom/venus/vdec.c       |   9 +-
 drivers/media/platform/qcom/venus/venc.c       |   9 +-
 8 files changed, 191 insertions(+), 334 deletions(-)

---
base-commit: 26074e1be23143b2388cacb36166766c235feb7c
change-id: 20230911-topic-mars-e60bb2269411

Best regards,

Signature · 1 line
Konrad Dybcio <[email protected]>