Venus cleanups
Get series with b4
b4 am [email protected] change-id 20230911-topic-mars-e60bb2269411Versions newest first
- v3 Latest19 patches 28 repliesIn review
- v2 posting 2/220 patches 29 repliesSuperseded
- v2 posting 1/25 of 20 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 20 patches | 5 replies | Superseded |
Changes in v3 from the cover letter
- Drop const within const patch
- Pick up tags
- Some stylistic fixes in kerneldoc
- Link to v2: https://lore.kernel.org/r/[email protected]
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | media: venus: pm_helpers: Only set rate of the core clock in core_clks_enabledrivers/ | +11 | 2 replies | |
| 2/19 | media: venus: pm_helpers: Rename core_clks_get to venus_clks_getdrivers/ | +3 | 1 reply | |
| 3/19 | media: venus: pm_helpers: Add kerneldoc to venus_clks_get()drivers/ | +28 | 5 replies | |
| 4/19 | media: venus: core: Set OPP clkname in a common code pathdrivers/ drivers/ | +7 | 1 reply | |
| 5/19 | media: venus: pm_helpers: Kill dead codedrivers/ | +0 | 3 replies | |
| 6/19 | media: venus: pm_helpers: Move reset acquisition to common codedrivers/ drivers/ | +8 | 1 reply | |
| 7/19 | media: venus: core: Deduplicate OPP genpd namesdrivers/ | +7 | 1 reply | |
| 8/19 | media: venus: core: Get rid of vcodec_numdrivers/ drivers/ drivers/ | +1 | 2 replies | |
| 9/19 | media: venus: core: Drop cache properties in resource structdrivers/ drivers/ drivers/ | +4 | 1 reply | |
| 10/19 | media: venus: core: Use GENMASK for dma_maskdrivers/ | +7 | 1 reply | |
| 11/19 | media: venus: core: Remove cp_startdrivers/ drivers/ drivers/ | +1 | 1 reply | |
| 12/19 | media: venus: pm_helpers: Commonize core_powerdrivers/ drivers/ drivers/ | +9 | 1 reply | |
| 13/19 | media: venus: pm_helpers: Remove pm_ops->core_putdrivers/ drivers/ drivers/ | +5 | 1 reply | |
| 14/19 | media: venus: core: Define a pointer to core->resdrivers/ | +7 | 2 replies | |
| 15/19 | media: venus: pm_helpers: Simplify vcodec clock handlingdrivers/ drivers/ drivers/ | +71 | 1 reply | |
| 16/19 | media: venus: pm_helpers: Commonize getting clocks and GenPDsdrivers/ drivers/ drivers/ | +5 | 1 reply | |
| 17/19 | media: venus: pm_helpers: Commonize vdec_get()drivers/ drivers/ drivers/ | +10 | 1 reply | |
| 18/19 | media: venus: pm_helpers: Commonize venc_get()drivers/ drivers/ drivers/ | +7 | 1 reply | |
| 19/19 | media: venus: pm_helpers: Use reset_bulk APIdrivers/ drivers/ drivers/ | +15 | 1 reply |
Reviews trailers per patch
13 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Bryan O'Donoghue | Philipp Zabel | Dikshita Agarwal |
|---|---|---|---|
| 1/19 | |||
| 2/19 | R-b | ||
| 3/19 | R-b | ||
| 4/19 | R-b | ||
| 5/19 | |||
| 6/19 | R-b | ||
| 7/19 | R-b | R-b | |
| 8/19 | R-b | ||
| 9/19 | R-b | R-b | |
| 10/19 | R-b | R-b | |
| 11/19 | R-b | R-b | |
| 12/19 | R-b | ||
| 13/19 | R-b | ||
| 14/19 | R-b | R-b | |
| 15/19 | |||
| 16/19 | |||
| 17/19 | |||
| 18/19 | |||
| 19/19 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/19] Venus cleanups
With the driver supporting multiple generations of hardware, some mold has definitely grown over the code..
This series attempts to amend this situation a bit by commonizing some code paths and fixing some bugs while at it.
Only tested on SM8250.
Definitely needs testing on:
- SDM845 with old bindings
- SDM845 with new bindings or 7180
- MSM8916
- MSM8996
---
Changes in v3:
- Drop const within const patch
- Pick up tags
- Some stylistic fixes in kerneldoc
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Fix "set but unused" warning in "Drop cache properties in resource struct"
- Fix modular build with "Commonize vdec_get()"
- Rebase
- Test again on 8250, since nobody else tested other platforms since the last submission (or at least hasn't reported that), I'm assuming nobody cares
- Needs to be tested atop [1] and similar, it's in latest -next already
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Konrad Dybcio (19):
media: venus: pm_helpers: Only set rate of the core clock in core_clks_enable
media: venus: pm_helpers: Rename core_clks_get to venus_clks_get
media: venus: pm_helpers: Add kerneldoc to venus_clks_get()
media: venus: core: Set OPP clkname in a common code path
media: venus: pm_helpers: Kill dead code
media: venus: pm_helpers: Move reset acquisition to common code
media: venus: core: Deduplicate OPP genpd names
media: venus: core: Get rid of vcodec_num
media: venus: core: Drop cache properties in resource struct
media: venus: core: Use GENMASK for dma_mask
media: venus: core: Remove cp_start
media: venus: pm_helpers: Commonize core_power
media: venus: pm_helpers: Remove pm_ops->core_put
media: venus: core: Define a pointer to core->res
media: venus: pm_helpers: Simplify vcodec clock handling
media: venus: pm_helpers: Commonize getting clocks and GenPDs
media: venus: pm_helpers: Commonize vdec_get()
media: venus: pm_helpers: Commonize venc_get()
media: venus: pm_helpers: Use reset_bulk API
drivers/media/platform/qcom/venus/core.c | 139 ++++------- drivers/media/platform/qcom/venus/core.h | 22 +- drivers/media/platform/qcom/venus/firmware.c | 3 +- drivers/media/platform/qcom/venus/hfi_venus.c | 10 +- drivers/media/platform/qcom/venus/pm_helpers.c | 323 +++++++++---------------- drivers/media/platform/qcom/venus/pm_helpers.h | 10 +- drivers/media/platform/qcom/venus/vdec.c | 9 +- drivers/media/platform/qcom/venus/venc.c | 9 +- 8 files changed, 191 insertions(+), 334 deletions(-)
---
base-commit: 26074e1be23143b2388cacb36166766c235feb7c
change-id: 20230911-topic-mars-e60bb2269411
Best regards,
Signature · 1 line
Konrad Dybcio <[email protected]>