Skip to content

wifi: rtw89: add TX/RX descriptor v2 and mac port registers for WiFi 7 chips

Ping-Ke Shih linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6wifi: rtw89: add to query RX descriptor format v2drivers/net/wireless/realtek/rtw89/core.c drivers/net/wireless/realtek/rtw89/core.h drivers/net/wireless/realtek/rtw89/txrx.h+188 -01 reply
2/6wifi: rtw89: add to fill TX descriptor for firmware command v2drivers/net/wireless/realtek/rtw89/core.c drivers/net/wireless/realtek/rtw89/core.h+23 -00 replies
3/6wifi: rtw89: add to fill TX descriptor v2drivers/net/wireless/realtek/rtw89/core.c drivers/net/wireless/realtek/rtw89/core.h drivers/net/wireless/realtek/rtw89/txrx.h+330 -00 replies
4/6wifi: rtw89: add chip_info::txwd_info size to generalize TX WD submitdrivers/net/wireless/realtek/rtw89/core.h drivers/net/wireless/realtek/rtw89/pci.c drivers/net/wireless/realtek/rtw89/rtw8851b.c +3 more+6 -20 replies
5/6wifi: rtw89: consolidate registers of mac port to structdrivers/net/wireless/realtek/rtw89/core.h drivers/net/wireless/realtek/rtw89/mac.c+26 -120 replies
6/6wifi: rtw89: add mac_gen pointer to access mac port registersdrivers/net/wireless/realtek/rtw89/mac.c drivers/net/wireless/realtek/rtw89/mac.h drivers/net/wireless/realtek/rtw89/mac_be.c +1 more+223 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] wifi: rtw89: add TX/RX descriptor v2 and mac port registers for WiFi 7 chips

WiFi 7 chips use different TX/RX descriptors and mac port registers, but logic is similar or the same as before, so implment them and reuse the existing code.

Three descriptors types:
- RX descriptor or RXWD (RX WiFi Descriptor) for short
That is meta data of received packet, such as MAC_ID, security CAM index and etc.
- TX descriptor or TXWD (TX WiFi Descriptor) for short
That is meta data of sending packet. Similar to RX descriptor, it contains MAC_ID, security key ID and etc.
- TX descriptor for firmware command
To send firmware command or download firmware is via a special path, and use different descriptor from normal TX packets. Because it doesn't need much meta data to assist, we choose short form RXWD to reduce overhead.

About TXWD body and info:
TXWD body is hard required, but TXWD info can be skipped to reduce overhead. A bit defined in TXWD body to indicate if TXWD info presents. For this driver, we always fill both.

About RXWD short and long forms:
Similarly, RXWD can be short or long forms. For driver, it must handle both though.

This patchset doesn't change logic for existing chpis.

Ping-Ke Shih (6):
wifi: rtw89: add to query RX descriptor format v2
wifi: rtw89: add to fill TX descriptor for firmware command v2
wifi: rtw89: add to fill TX descriptor v2
wifi: rtw89: add chip_info::txwd_info size to generalize TX WD submit
wifi: rtw89: consolidate registers of mac port to struct
wifi: rtw89: add mac_gen pointer to access mac port registers

 drivers/net/wireless/realtek/rtw89/core.c     | 215 ++++++++++++++
 drivers/net/wireless/realtek/rtw89/core.h     |  62 ++++
 drivers/net/wireless/realtek/rtw89/mac.c      |  94 ++++--
 drivers/net/wireless/realtek/rtw89/mac.h      |   1 +
 drivers/net/wireless/realtek/rtw89/mac_be.c   |  27 ++
 drivers/net/wireless/realtek/rtw89/pci.c      |   3 +-
 drivers/net/wireless/realtek/rtw89/reg.h      | 147 ++++++++++
 drivers/net/wireless/realtek/rtw89/rtw8851b.c |   1 +
 drivers/net/wireless/realtek/rtw89/rtw8852a.c |   1 +
 drivers/net/wireless/realtek/rtw89/rtw8852b.c |   1 +
 drivers/net/wireless/realtek/rtw89/rtw8852c.c |   1 +
 drivers/net/wireless/realtek/rtw89/txrx.h     | 271 ++++++++++++++++++
 12 files changed, 791 insertions(+), 33 deletions(-)
Signature · 1 line
2.25.1