Skip to content

Add support for multishot reads

Jens Axboe io-uring 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Code reformatting
- Add/expand a few comments

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3io_uring/rw: split io_read() into a helperio_uring/rw.c+12 -10 replies
2/3io_uring/rw: mark readv/writev as vectored in the opcode definitionio_uring/opdef.c io_uring/opdef.h io_uring/rw.c+10 -40 replies
3/3io_uring/rw: add support for IORING_OP_READ_MULTISHOTinclude/uapi/linux/io_uring.h io_uring/opdef.c io_uring/rw.c +1 more+85 -31 reply

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGabriel Krisman Bertazi
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHSET v2 0/3] Add support for multishot reads

Hi,

We support multishot for other request types, generally in the shape of a flag for the request. Doing a flag based approach with reads isn't straightforward, as the read/write flags are in the RWF_ space. Instead, add a separate opcode for this, IORING_OP_READ_MULTISHOT.

This can only be used provided buffers, like other multishot request types that read/receive data.

It can also only be used for pollable file types, like a tun device or pipes, for example. File types that are always readable (or seekable), like regular files, cannot be used with multishot reads.

This is based on the io_uring-futex branch (which, in turn, is based on the io_uring-waitid branch). No dependencies as such between them, except the opcode numbering.

Can also be found here:

https://git.kernel.dk/cgit/linux/log/?h=io_uring-mshot-read

and there's a liburing branch with some basic support and some test cases here:

https://git.kernel.dk/cgit/liburing/log/?h=read-mshot

 include/uapi/linux/io_uring.h |  1 +
 io_uring/opdef.c              | 14 ++++++
 io_uring/opdef.h              |  2 +
 io_uring/rw.c                 | 92 ++++++++++++++++++++++++++++++++---
 io_uring/rw.h                 |  2 +
 5 files changed, 105 insertions(+), 6 deletions(-)

Changes since v1:
- Code reformatting
- Add/expand a few comments

Signature · 1 line
Jens Axboe