Skip to content

IFS support for GNR and SRF

Jithu Joseph linux-patches lkml platform-driver-x86 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 1 replyIn review
  2. v39 patches 11 repliesSuperseded
  3. v29 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches24 repliesSuperseded

Changes in v4 from the cover letter

Ilpo Järvinen
- Changed the dev_err/warn printk format specifiers to more appropriate ones (patch 5, 6)
- Add defines for array generation (patch 9)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9platform/x86/intel/ifs: Store IFS generation numberarch/x86/include/asm/msr-index.h drivers/platform/x86/intel/ifs/core.c drivers/platform/x86/intel/ifs/ifs.h+6 -00 replies
2/9platform/x86/intel/ifs: Refactor image loading codedrivers/platform/x86/intel/ifs/load.c+19 -120 replies
3/9platform/x86/intel/ifs: Gen2 scan image loadingdrivers/platform/x86/intel/ifs/ifs.h drivers/platform/x86/intel/ifs/load.c+137 -20 replies
4/9platform/x86/intel/ifs: Gen2 Scan test supportdrivers/platform/x86/intel/ifs/ifs.h drivers/platform/x86/intel/ifs/runtest.c include/trace/events/intel_ifs.h+52 -210 replies
5/9platform/x86/intel/ifs: Validate image sizedrivers/platform/x86/intel/ifs/load.c+8 -00 replies
6/9platform/x86/intel/ifs: Metadata validation for start_chunkdrivers/platform/x86/intel/ifs/load.c+7 -00 replies
7/9platform/x86/intel/ifs: Add new CPU supportdrivers/platform/x86/intel/ifs/core.c+3 -00 replies
8/9platform/x86/intel/ifs: Add new error codedrivers/platform/x86/intel/ifs/runtest.c+6 -00 replies
9/9platform/x86/intel/ifs: ARRAY BIST for Sierra Forestdrivers/platform/x86/intel/ifs/core.c drivers/platform/x86/intel/ifs/ifs.h drivers/platform/x86/intel/ifs/runtest.c+51 -81 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchTony LuckIlpo JärvinenPengfei Xu
1/9R-b R-b T-b
2/9R-b R-b T-b
3/9R-b R-b T-b
4/9R-b R-b T-b
5/9R-b R-b T-b
6/9R-b T-b
7/9R-b R-b T-b
8/9R-b R-b T-b
9/9R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/9] IFS support for GNR and SRF

Changes in v4
Ilpo Järvinen
- Changed the dev_err/warn printk format specifiers to more appropriate ones (patch 5, 6)
- Add defines for array generation (patch 9)

v3 submission

Changes in v3
Ilpo Järvinen
- Added Reviewed-by tags wherever provided
- In function validate_ifs_metadata() (patch 6)
- Add != 0 to next line for clarity
- In function ifs_load_firmware() (patch 5)
- return -EINVAL instead of -BADFD
- In function ifs_test_core() (patch 4)
- initialize activate.gen0.rsvd = 0
- use if instead of conditional operator
- alignment change in ifs_scan_hashes_status_gen2 (patch 3)

v2 submission

Changes in v2
Ilpo Järvinen
- Use GENMASK_ULL() / FIELD_GET() for bitops (patch 01)
- Avoid mixing u8 type and bitfields in certain MSR structure scenarios (patch03 also suggested by Dave Hansen)
- Expand bitfield structures to use consistent genx naming (patch 04)
- Replace goto with do / while (patch 03)
- general formatting (multiple patches)
- remove un-necessary parenthesis
- reformat commit message to use whole allowed 72 columns
- alignment changes
Other change
- fold v1 04/10 and 05/10 into v2 patch 04/09 to satisfy build constraints due to consistent genx naming

v1 submission:

This series adds In Field Scan(IFS) support for newer CPUs like Granite Rapids(GNR) and Sierra Forest(SRF).

There are changes in the IFS image loading and test flow to support these new CPUs.

Note to reviewers:
- patch 1/9 adds a bit mask to arch/x86/.../msr-index.h, hence x86 maintainers are cc-d.
- patch 4/9 modifies an existing tracepoint, cc Steven Rostedt
- Rest are localized to IFS driver

Jithu Joseph (9):
platform/x86/intel/ifs: Store IFS generation number platform/x86/intel/ifs: Refactor image loading code platform/x86/intel/ifs: Gen2 scan image loading platform/x86/intel/ifs: Gen2 Scan test support platform/x86/intel/ifs: Validate image size platform/x86/intel/ifs: Metadata validation for start_chunk platform/x86/intel/ifs: Add new CPU support platform/x86/intel/ifs: Add new error code platform/x86/intel/ifs: ARRAY BIST for Sierra Forest

 arch/x86/include/asm/msr-index.h         |   1 +
 drivers/platform/x86/intel/ifs/ifs.h     |  64 ++++++++-
 include/trace/events/intel_ifs.h         |  16 +--
 drivers/platform/x86/intel/ifs/core.c    |  15 ++-
 drivers/platform/x86/intel/ifs/load.c    | 158 +++++++++++++++++++++--
 drivers/platform/x86/intel/ifs/runtest.c |  72 +++++++++--
 6 files changed, 286 insertions(+), 40 deletions(-)

base-commit: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa

Signature · 1 line
2.25.1