Skip to content

vfio/pds: Fixes for locking bugs

Brett Creeley kvm lkml 4 versions – Applied

Status from this message: Applied to vfio for-linus branch for v6.7. Thanks,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyApplied
  2. v33 patches 3 repliesSuperseded
  3. v23 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches4 repliesSuperseded

Changes in v4 from the cover letter

- Drop patch 1/3 since it added a spinlock_init that was later replaced by a mutex_init anyway

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2vfio/pds: Fix mutex lock->magic != lock warningdrivers/vfio/pci/pds/vfio_dev.c+13 -30 replies
2/2vfio/pds: Fix possible sleep while in atomic contextdrivers/vfio/pci/pds/pci_drv.c drivers/vfio/pci/pds/vfio_dev.c drivers/vfio/pci/pds/vfio_dev.h+11 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchShannon Nelson
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 vfio 0/2] vfio/pds: Fixes for locking bugs

This series contains fixes for locking bugs in the recently introduced pds-vfio-pci driver. There was an initial bug reported by Dan Carpenter at:

https://lore.kernel.org/kvm/[email protected]/

However, more locking bugs were found when looking into the previously mentioned issue. So, all fixes are included in this series.

v4:
- Drop patch 1/3 since it added a spinlock_init that was later replaced by a mutex_init anyway

v3:
https://lore.kernel.org/kvm/[email protected]/
- Change reset lock from spinlock to mutex

v2:
https://lore.kernel.org/kvm/[email protected]/
- Trim the OOPs in the patch commit messages
- Rework patch 3/3 to only unlock the spinlock once
- Destroy the state_mutex in the driver specific vfio_device_ops.release callback

v1:
https://lore.kernel.org/kvm/[email protected]/

Brett Creeley (2):
vfio/pds: Fix mutex lock->magic != lock warning vfio/pds: Fix possible sleep while in atomic context

 drivers/vfio/pci/pds/pci_drv.c  |  4 ++--
 drivers/vfio/pci/pds/vfio_dev.c | 30 +++++++++++++++++++++---------
 drivers/vfio/pci/pds/vfio_dev.h |  2 +-
 3 files changed, 24 insertions(+), 12 deletions(-)
Signature · 1 line
2.17.1