Skip to content

random tty fixes

Jiri Slaby (SUSE) linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15tty: n_tty: use 'retval' instead of 'c'drivers/tty/n_tty.c+4 -50 replies
2/15tty: n_tty: rename and retype 'retval' in n_tty_ioctl()drivers/tty/n_tty.c+4 -40 replies
3/15tty: n_tty: use min3() in copy_from_read_buf()drivers/tty/n_tty.c+1 -20 replies
4/15tty: n_tty: invert the condition in copy_from_read_buf()drivers/tty/n_tty.c+20 -182 replies
5/15tty: n_tty: use do-while in n_tty_check_{,un}throttle()drivers/tty/n_tty.c+7 -120 replies
6/15tty: switch tty_{,un}throttle_safe() to return a booldrivers/tty/tty_ioctl.c include/linux/tty.h+10 -120 replies
7/15tty: invert return values of tty_{,un}throttle_safe()drivers/tty/n_tty.c drivers/tty/tty_ioctl.c+8 -80 replies
8/15tty: fix up and plug in tty_ioctl kernel-docDocumentation/driver-api/tty/index.rst Documentation/driver-api/tty/tty_ioctl.rst drivers/tty/tty_ioctl.c+115 -1110 replies
9/15tty: fix kernel-doc for functions in tty.hDocumentation/driver-api/tty/tty_ioctl.rst include/linux/tty.h+12 -124 replies
10/15tty: stop using ndash in kernel-docdrivers/tty/tty_io.c drivers/tty/tty_port.c drivers/tty/vt/consolemap.c +2 more+12 -120 replies
11/15tty: tty_buffer: use bool for 'restart' in tty_buffer_unlock_exclusive()drivers/tty/tty_buffer.c+2 -30 replies
12/15tty: convert THROTTLE constants into enumdrivers/tty/tty.h drivers/tty/tty_ioctl.c+10 -52 replies
13/15tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAKdrivers/tty/tty_io.c+17 -150 replies
14/15tty: don't check for signal_pending() in send_break()drivers/tty/tty_io.c+1 -21 reply
15/15tty: use 'if' in send_break() instead of 'goto'drivers/tty/tty_io.c+4 -50 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIlpo Järvinen
SeriesR-b
1/15
2/15
3/15
4/15R-b
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] random tty fixes

This is a collection of random fixes for tty I did while crawling through the code. Mostly done for readability and understandability. No behavior change intended (except for Documentation fixes).

Jiri Slaby (SUSE) (15):
tty: n_tty: use 'retval' instead of 'c'
tty: n_tty: rename and retype 'retval' in n_tty_ioctl()
tty: n_tty: use min3() in copy_from_read_buf()
tty: n_tty: invert the condition in copy_from_read_buf()
tty: n_tty: use do-while in n_tty_check_{,un}throttle()
tty: switch tty_{,un}throttle_safe() to return a bool
tty: invert return values of tty_{,un}throttle_safe()
tty: fix up and plug in tty_ioctl kernel-doc
tty: fix kernel-doc for functions in tty.h
tty: stop using ndash in kernel-doc
tty: tty_buffer: use bool for 'restart' in
tty_buffer_unlock_exclusive()
tty: convert THROTTLE constants into enum
tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAK
tty: don't check for signal_pending() in send_break()
tty: use 'if' in send_break() instead of 'goto'

 Documentation/driver-api/tty/index.rst     |   1 +
 Documentation/driver-api/tty/tty_ioctl.rst |  10 +
 drivers/tty/n_tty.c                        |  77 ++++---
 drivers/tty/tty.h                          |  13 +-
 drivers/tty/tty_buffer.c                   |   5 +-
 drivers/tty/tty_io.c                       |  36 ++--
 drivers/tty/tty_ioctl.c                    | 234 ++++++++++-----------
 drivers/tty/tty_port.c                     |   6 +-
 drivers/tty/vt/consolemap.c                |   2 +-
 drivers/tty/vt/vc_screen.c                 |   4 +-
 drivers/tty/vt/vt.c                        |   4 +-
 include/linux/tty.h                        |  25 +--
 12 files changed, 209 insertions(+), 208 deletions(-)
 create mode 100644 Documentation/driver-api/tty/tty_ioctl.rst
Signature · 1 line
2.42.0