Add OA functionality to Xe
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest21 patches 59 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | drm/xe/uapi: Introduce OA (observability architecture) uapiinclude/ | +253 | 3 replies | |
| 2/21 | drm/xe/oa: Add OA typesdrivers/ | +295 | 1 reply | |
| 3/21 | drm/xe/oa: Add registers and GPU commands used by OAdrivers/ drivers/ drivers/ | +188 | 2 replies | |
| 4/21 | drm/xe/oa: Module init/exit and probe/removedrivers/ drivers/ drivers/ +5 more | +354 | 3 replies | |
| 5/21 | drm/xe/oa: Add/remove config ioctl'sdrivers/ drivers/ drivers/ | +387 | 1 reply | |
| 6/21 | drm/xe/oa: Start implementing OA stream open ioctldrivers/ drivers/ drivers/ | +242 | 1 reply | |
| 7/21 | drm/xe/oa: OA stream initializationdrivers/ | +669 | 1 reply | |
| 8/21 | drm/xe/oa: Expose OA stream fddrivers/ | +386 | 1 reply | |
| 9/21 | drm/xe/oa: Read file_operationdrivers/ | +360 | 1 reply | |
| 10/21 | drm/xe/oa: Implement queriesdrivers/ drivers/ drivers/ | +19 | 1 reply | |
| 11/21 | drm/xe/oa: Override GuC RC with OA on PVCdrivers/ drivers/ drivers/ +1 more | +94 | 1 reply | |
| 12/21 | drm/xe/uapi: "Perf" layer to support multiple perf counter stream typesdrivers/ drivers/ drivers/ +3 more | +133 | 2 replies | |
| 13/21 | drm/xe/uapi: Multiplex PERF ops through a single PERF ioctldrivers/ drivers/ drivers/ +1 more | +20 | 5 replies | |
| 14/21 | drm/xe/uapi: Simplify OA configs in uapidrivers/ drivers/ include/ | +27 | 3 replies | |
| 15/21 | drm/xe/uapi: Remove OA format names from OA uapidrivers/ drivers/ include/ | +72 | 2 replies | |
| 16/21 | drm/xe/oa: Make xe_oa_timestamp_frequency per gtdrivers/ drivers/ drivers/ | +24 | 3 replies | |
| 17/21 | drm/xe/oa: Remove filtering reports on context iddrivers/ drivers/ | +3 | 3 replies | |
| 18/21 | drm/xe/uapi: More OA uapi fixes/additionsinclude/ | +66 | 7 replies | |
| 19/21 | drm/xe/uapi: Drop OA_IOCTL_VERSIONdrivers/ drivers/ drivers/ +1 more | +1 | 8 replies | |
| 20/21 | drm/xe/uapi: Use OA unit id to identify OA unitdrivers/ include/ | +160 | 3 replies | |
| 21/21 | drm/xe/uapi: Convert OA property key/value pairs to a structdrivers/ drivers/ include/ | +151 | 3 replies |
Reviews trailers per patch
9 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Umesh Nerlige Ramappa |
|---|---|
| 1/21 | |
| 2/21 | R-b |
| 3/21 | R-b |
| 4/21 | R-b |
| 5/21 | |
| 6/21 | R-b |
| 7/21 | |
| 8/21 | R-b |
| 9/21 | R-b |
| 10/21 | |
| 11/21 | R-b |
| 12/21 | R-b |
| 13/21 | |
| 14/21 | R-b |
| 15/21 | |
| 16/21 | |
| 17/21 | |
| 18/21 | |
| 19/21 | |
| 20/21 | |
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-xe] [PATCH 00/21] Add OA functionality to Xe
This patchset is the initial port of i915 perf/OA functionality to the XE driver. The following features in i915 have not been ported and will be added (as new patches) if/as they are needed:
* Inline batch submission on stream exec_queue/hw_engine
* NOA wait
* GuC ctx id (guc_sw_ctx_id)
* CTX_R_PWR_CLK_STATE/GEN8_R_PWR_CLK_STATE
* hold_preemption (DRM_XE_OA_PROP_HOLD_PREEMPTION)
* sseu_config (DRM_XE_OA_PROP_GLOBAL_SSEU)
* MTL bios_c6_setup
* ratelimits
* compat ioctl
I am providing the following additional HAX patch (not part of this series) to help review these patches:
https://patchwork.freedesktop.org/patch/551683/?series=120100&rev=4
The commit message in the above patch explains how it can be useful for reviewing this series.
This series is also available at:
https://gitlab.freedesktop.org/adixit/kernel/-/tree/xe-oa
The series has been tested against this IGT series:
https://gitlab.freedesktop.org/adixit/igt-gpu-tools/-/tree/xe-oa
v2: Fix build
v3: Rebase, due to s/xe_engine/xe_exec_queue/
v4: Re-run for testing
v5: Address review comments, new patches 11 through 17
v6: New patches 18 through 21
Ashutosh Dixit (21):
drm/xe/uapi: Introduce OA (observability architecture) uapi drm/xe/oa: Add OA types
drm/xe/oa: Add registers and GPU commands used by OA drm/xe/oa: Module init/exit and probe/remove drm/xe/oa: Add/remove config ioctl's
drm/xe/oa: Start implementing OA stream open ioctl drm/xe/oa: OA stream initialization
drm/xe/oa: Expose OA stream fd
drm/xe/oa: Read file_operation
drm/xe/oa: Implement queries
drm/xe/oa: Override GuC RC with OA on PVC
drm/xe/uapi: "Perf" layer to support multiple perf counter stream
types
drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl drm/xe/uapi: Simplify OA configs in uapi
drm/xe/uapi: Remove OA format names from OA uapi drm/xe/oa: Make xe_oa_timestamp_frequency per gt drm/xe/oa: Remove filtering reports on context id drm/xe/uapi: More OA uapi fixes/additions
drm/xe/uapi: Drop OA_IOCTL_VERSION
drm/xe/uapi: Use OA unit id to identify OA unit drm/xe/uapi: Convert OA property key/value pairs to a struct
drivers/gpu/drm/xe/Makefile | 2 + drivers/gpu/drm/xe/regs/xe_engine_regs.h | 2 + drivers/gpu/drm/xe/regs/xe_gpu_commands.h | 13 + drivers/gpu/drm/xe/regs/xe_oa_regs.h | 173 ++ drivers/gpu/drm/xe/xe_device.c | 13 + drivers/gpu/drm/xe/xe_device_types.h | 4 + drivers/gpu/drm/xe/xe_gt_types.h | 4 + drivers/gpu/drm/xe/xe_guc_pc.c | 60 + drivers/gpu/drm/xe/xe_guc_pc.h | 3 + drivers/gpu/drm/xe/xe_hw_engine_types.h | 2 + drivers/gpu/drm/xe/xe_module.c | 5 + drivers/gpu/drm/xe/xe_oa.c | 2314 +++++++++++++++++++++ drivers/gpu/drm/xe/xe_oa.h | 27 + drivers/gpu/drm/xe/xe_oa_types.h | 307 +++ drivers/gpu/drm/xe/xe_perf.c | 36 + drivers/gpu/drm/xe/xe_perf.h | 16 + drivers/gpu/drm/xe/xe_query.c | 5 +- include/uapi/drm/xe_drm.h | 288 ++- 18 files changed, 3272 insertions(+), 2 deletions(-) create mode 100644 drivers/gpu/drm/xe/regs/xe_oa_regs.h create mode 100644 drivers/gpu/drm/xe/xe_oa.c create mode 100644 drivers/gpu/drm/xe/xe_oa.h create mode 100644 drivers/gpu/drm/xe/xe_oa_types.h create mode 100644 drivers/gpu/drm/xe/xe_perf.c create mode 100644 drivers/gpu/drm/xe/xe_perf.h
Signature · 1 line
2.41.0