Skip to content

Add OA functionality to Xe

Ashutosh Dixit intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 59 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21drm/xe/uapi: Introduce OA (observability architecture) uapiinclude/uapi/drm/xe_drm.h+253 -23 replies
2/21drm/xe/oa: Add OA typesdrivers/gpu/drm/xe/xe_oa_types.h+295 -01 reply
3/21drm/xe/oa: Add registers and GPU commands used by OAdrivers/gpu/drm/xe/regs/xe_engine_regs.h drivers/gpu/drm/xe/regs/xe_gpu_commands.h drivers/gpu/drm/xe/regs/xe_oa_regs.h+188 -02 replies
4/21drm/xe/oa: Module init/exit and probe/removedrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h +5 more+354 -03 replies
5/21drm/xe/oa: Add/remove config ioctl'sdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h+387 -11 reply
6/21drm/xe/oa: Start implementing OA stream open ioctldrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h+242 -01 reply
7/21drm/xe/oa: OA stream initializationdrivers/gpu/drm/xe/xe_oa.c+669 -31 reply
8/21drm/xe/oa: Expose OA stream fddrivers/gpu/drm/xe/xe_oa.c+386 -01 reply
9/21drm/xe/oa: Read file_operationdrivers/gpu/drm/xe/xe_oa.c+360 -01 reply
10/21drm/xe/oa: Implement queriesdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h drivers/gpu/drm/xe/xe_query.c+19 -11 reply
11/21drm/xe/oa: Override GuC RC with OA on PVCdrivers/gpu/drm/xe/xe_guc_pc.c drivers/gpu/drm/xe/xe_guc_pc.h drivers/gpu/drm/xe/xe_oa.c +1 more+94 -11 reply
12/21drm/xe/uapi: "Perf" layer to support multiple perf counter stream typesdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_oa.c +3 more+133 -332 replies
13/21drm/xe/uapi: Multiplex PERF ops through a single PERF ioctldrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_perf.c drivers/gpu/drm/xe/xe_perf.h +1 more+20 -375 replies
14/21drm/xe/uapi: Simplify OA configs in uapidrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h include/uapi/drm/xe_drm.h+27 -893 replies
15/21drm/xe/uapi: Remove OA format names from OA uapidrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h include/uapi/drm/xe_drm.h+72 -362 replies
16/21drm/xe/oa: Make xe_oa_timestamp_frequency per gtdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h drivers/gpu/drm/xe/xe_query.c+24 -243 replies
17/21drm/xe/oa: Remove filtering reports on context iddrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h+3 -393 replies
18/21drm/xe/uapi: More OA uapi fixes/additionsinclude/uapi/drm/xe_drm.h+66 -67 replies
19/21drm/xe/uapi: Drop OA_IOCTL_VERSIONdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h drivers/gpu/drm/xe/xe_query.c +1 more+1 -98 replies
20/21drm/xe/uapi: Use OA unit id to identify OA unitdrivers/gpu/drm/xe/xe_oa.c include/uapi/drm/xe_drm.h+160 -1293 replies
21/21drm/xe/uapi: Convert OA property key/value pairs to a structdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h include/uapi/drm/xe_drm.h+151 -2243 replies

Reviews trailers per patch

9 of 21 patches have a Reviewed-by or Acked-by.

PatchUmesh Nerlige Ramappa
1/21
2/21R-b
3/21R-b
4/21R-b
5/21
6/21R-b
7/21
8/21R-b
9/21R-b
10/21
11/21R-b
12/21R-b
13/21
14/21R-b
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-xe] [PATCH 00/21] Add OA functionality to Xe

This patchset is the initial port of i915 perf/OA functionality to the XE driver. The following features in i915 have not been ported and will be added (as new patches) if/as they are needed:

* Inline batch submission on stream exec_queue/hw_engine
* NOA wait
* GuC ctx id (guc_sw_ctx_id)
* CTX_R_PWR_CLK_STATE/GEN8_R_PWR_CLK_STATE
* hold_preemption (DRM_XE_OA_PROP_HOLD_PREEMPTION)
* sseu_config (DRM_XE_OA_PROP_GLOBAL_SSEU)
* MTL bios_c6_setup
* ratelimits
* compat ioctl

I am providing the following additional HAX patch (not part of this series) to help review these patches:

https://patchwork.freedesktop.org/patch/551683/?series=120100&rev=4

The commit message in the above patch explains how it can be useful for reviewing this series.

This series is also available at:
https://gitlab.freedesktop.org/adixit/kernel/-/tree/xe-oa

The series has been tested against this IGT series:
https://gitlab.freedesktop.org/adixit/igt-gpu-tools/-/tree/xe-oa

v2: Fix build
v3: Rebase, due to s/xe_engine/xe_exec_queue/
v4: Re-run for testing
v5: Address review comments, new patches 11 through 17
v6: New patches 18 through 21

Ashutosh Dixit (21):
drm/xe/uapi: Introduce OA (observability architecture) uapi drm/xe/oa: Add OA types
drm/xe/oa: Add registers and GPU commands used by OA drm/xe/oa: Module init/exit and probe/remove drm/xe/oa: Add/remove config ioctl's
drm/xe/oa: Start implementing OA stream open ioctl drm/xe/oa: OA stream initialization
drm/xe/oa: Expose OA stream fd
drm/xe/oa: Read file_operation
drm/xe/oa: Implement queries
drm/xe/oa: Override GuC RC with OA on PVC
drm/xe/uapi: "Perf" layer to support multiple perf counter stream
types
drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl drm/xe/uapi: Simplify OA configs in uapi
drm/xe/uapi: Remove OA format names from OA uapi drm/xe/oa: Make xe_oa_timestamp_frequency per gt drm/xe/oa: Remove filtering reports on context id drm/xe/uapi: More OA uapi fixes/additions
drm/xe/uapi: Drop OA_IOCTL_VERSION
drm/xe/uapi: Use OA unit id to identify OA unit drm/xe/uapi: Convert OA property key/value pairs to a struct

 drivers/gpu/drm/xe/Makefile               |    2 +
 drivers/gpu/drm/xe/regs/xe_engine_regs.h  |    2 +
 drivers/gpu/drm/xe/regs/xe_gpu_commands.h |   13 +
 drivers/gpu/drm/xe/regs/xe_oa_regs.h      |  173 ++
 drivers/gpu/drm/xe/xe_device.c            |   13 +
 drivers/gpu/drm/xe/xe_device_types.h      |    4 +
 drivers/gpu/drm/xe/xe_gt_types.h          |    4 +
 drivers/gpu/drm/xe/xe_guc_pc.c            |   60 +
 drivers/gpu/drm/xe/xe_guc_pc.h            |    3 +
 drivers/gpu/drm/xe/xe_hw_engine_types.h   |    2 +
 drivers/gpu/drm/xe/xe_module.c            |    5 +
 drivers/gpu/drm/xe/xe_oa.c                | 2314 +++++++++++++++++++++
 drivers/gpu/drm/xe/xe_oa.h                |   27 +
 drivers/gpu/drm/xe/xe_oa_types.h          |  307 +++
 drivers/gpu/drm/xe/xe_perf.c              |   36 +
 drivers/gpu/drm/xe/xe_perf.h              |   16 +
 drivers/gpu/drm/xe/xe_query.c             |    5 +-
 include/uapi/drm/xe_drm.h                 |  288 ++-
 18 files changed, 3272 insertions(+), 2 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/regs/xe_oa_regs.h
 create mode 100644 drivers/gpu/drm/xe/xe_oa.c
 create mode 100644 drivers/gpu/drm/xe/xe_oa.h
 create mode 100644 drivers/gpu/drm/xe/xe_oa_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_perf.c
 create mode 100644 drivers/gpu/drm/xe/xe_perf.h
Signature · 1 line
2.41.0