Skip to content

mm: Implement ECC handling for pfn with no struct page

[email protected] kvm linux-acpi linux-arm-kernel linux-edac linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Change poisoned page tracking from bitmap to hashtable.
- Addressed miscellaneous comments in v1.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mm: handle poisoning of pfn without struct pagesinclude/linux/memory-failure.h include/linux/mm.h include/ras/ras_event.h +2 more+146 -250 replies
2/4mm: Add poison error check in fixup_user_fault() for mapped pfnmm/gup.c virt/kvm/kvm_main.c+7 -11 reply
3/4mm: Change ghes code to allow poison of non-struct pfndrivers/acpi/apei/ghes.c+1 -115 replies
4/4vfio/nvgpu: register device memory for poison handlingdrivers/vfio/pci/nvgrace-gpu/main.c drivers/vfio/vfio_main.c+124 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] mm: Implement ECC handling for pfn with no struct page

From: Ankit Agrawal <[email protected]>

The kernel MM currently handles ECC errors / poison only on memory page backed by struct page. As part of [1], the nvgrace-gpu-vfio-pci module maps the device memory to user VA (Qemu) using remap_pfn_range without being added to the kernel. These pages are not backed by struct page.

Implement a new ECC handling for memory without struct pages. Kernel MM expose registration APIs to allow modules that are managing the device to register its memory region and a callback function. MM then tracks such regions using interval tree.

The mechanism is largely similar to that of ECC on pfn with struct pages. If there is an ECC error on a pfn, MM uses the registered memory failure callback function to notify the module of the faulty PFN, so that the module may take any required action. The pfn is then unmapped in Stage-2. When the VM tries to access the page, it gets trapped in KVM, which calls the vm ops fault function. If the module fault function returns VM_FAULT_HWPOISON, KVM sends a BUS_MCEERR_AR to the usermode (Qemu) mapped to the poisoned page.

Lastly, nvgrace-gpu-vfio-pci module make use of the new mechanism to get poison handling support on the device memory.

Patch generated over v6.7-rc2 and with [1] applied. [1] is currently under review.

[1] https://lore.kernel.org/all/[email protected]/

---

Link for v1: https://lore.kernel.org/all/[email protected]/

v1 -> v2
- Change poisoned page tracking from bitmap to hashtable.
- Addressed miscellaneous comments in v1.

Ankit Agrawal (4):
mm: handle poisoning of pfn without struct pages
mm: Add poison error check in fixup_user_fault() for mapped pfn
mm: Change ghes code to allow poison of non-struct pfn vfio/nvgpu: register device memory for poison handling

 drivers/acpi/apei/ghes.c            |  12 +--
 drivers/vfio/pci/nvgrace-gpu/main.c | 123 ++++++++++++++++++++++-
 drivers/vfio/vfio_main.c            |   3 +-
 include/linux/memory-failure.h      |  22 +++++
 include/linux/mm.h                  |   1 +
 include/ras/ras_event.h             |   1 +
 mm/Kconfig                          |   1 +
 mm/gup.c                            |   2 +-
 mm/memory-failure.c                 | 146 +++++++++++++++++++++++-----
 virt/kvm/kvm_main.c                 |   6 ++
 10 files changed, 278 insertions(+), 39 deletions(-)
 create mode 100644 include/linux/memory-failure.h
Signature · 1 line
2.17.1