Skip to content

ALSA: cs35l41: prevent old firmwares using unsupported commands

Stefan Binding alsa-devel linux-sound lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Added fixes tag to all patches
- patches rebased after v6.7 release

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ALSA: hda: cs35l41: Remove unnecessary boolean state variable firmware_runningsound/pci/hda/cs35l41_hda.c+12 -160 replies
2/2ALSA: cs35l41: Fix for old systems which do not support commandinclude/sound/cs35l41.h sound/pci/hda/cs35l41_hda.c sound/soc/codecs/cs35l41-lib.c +1 more+9 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands

Some systems use older firmware which does not support newer commands which are used to enable external boost. For those systems, we can workaround this by writing the registers directly.

We can use the firmware version, stored inside cs_dsp, to determine whether or not the command is supported.
To achieve this, it requires a cleanup in the api, to pass the cs_dsp struct into the function.

We can also remove the redundant boolean firmware_running from the HDA driver, and use the equivalent state inside cs_dsp.

Changes since V1:
- Added fixes tag to all patches
- patches rebased after v6.7 release

Stefan Binding (2):
ALSA: hda: cs35l41: Remove unnecessary boolean state variable
firmware_running
ALSA: cs35l41: Fix for old systems which do not support command

 include/sound/cs35l41.h        |  2 +-
 sound/pci/hda/cs35l41_hda.c    | 28 ++++++++++++----------------
 sound/soc/codecs/cs35l41-lib.c |  6 ++++--
 sound/soc/codecs/cs35l41.c     |  4 ++--
 4 files changed, 19 insertions(+), 21 deletions(-)
Signature · 1 line
2.34.1