Skip to content

Review nf_tables audit logging

Phil Sutter audit netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests: netfilter: Extend nft_audit.shtools/testing/selftests/netfilter/nft_audit.sh+81 -160 replies
2/3netfilter: nf_tables: Deduplicate nft_register_obj audit logsnet/netfilter/nf_tables_api.c tools/testing/selftests/netfilter/nft_audit.sh+48 -165 replies
3/3netfilter: nf_tables: Audit log object reset once per tablenet/netfilter/nf_tables_api.c tools/testing/selftests/netfilter/nft_audit.sh+74 -233 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRichard Guy BriggsPaul Moore
1/3
2/3R-b A-b
3/3R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [nf PATCH 0/3] Review nf_tables audit logging

When working on locking for reset commands, some audit log calls had to be adjusted as well. This series deals with the "fallout" from adding tests for the changed log calls, dealing with the uncovered issues and adding more tests.

Patch 1 adds more testing to nft_audit.sh for commands which are unproblematic.

Patch 2 deals with (likely) leftovers from audit log flood prevention in commit c520292f29b80 ("audit: log nftables configuration change events once per table").

Patch 3 changes logging for object reset requests to happen once per table (if skb size is sufficient) and thereby aligns output with object add requests. As a side-effect, logging is fixed to happen after the actual reset has succeeded, not before.

NOTE: This whole series probably depends on the reset locking series[1] submitted earlier, but there's no functional connection and reviews should happen independently.

[1] https://lore.kernel.org/netfilter-devel/[email protected]/

Phil Sutter (3):
selftests: netfilter: Extend nft_audit.sh
netfilter: nf_tables: Deduplicate nft_register_obj audit logs
netfilter: nf_tables: Audit log object reset once per table

 net/netfilter/nf_tables_api.c                 |  95 +++++-----
 .../testing/selftests/netfilter/nft_audit.sh  | 163 ++++++++++++++++--
 2 files changed, 203 insertions(+), 55 deletions(-)
Signature · 1 line
2.41.0