clang-tools support in tools
Status from this message: Applied to perf-tools-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest18 patches 2 repliesApplied
- v218 patches 14 repliesSuperseded
- v118 patches 8 repliesSuperseded
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | gen_compile_commands: Allow the line prefix to still be cmd_scripts/ | +3 | 0 replies | |
| 2/18 | gen_compile_commands: Sort output compile commands by file namescripts/ | +1 | 0 replies | |
| 3/18 | run-clang-tools: Add pass through checks and and header-filter argumentsscripts/ | +25 | 0 replies | |
| 3/18 | run-clang-tools: Add pass through checks and header-filter argumentsscripts/ | +25 | 0 replies | |
| 4/18 | perf bench uprobe: Fix potential use of memory after freetools/ | +1 | 0 replies | |
| 5/18 | perf buildid-cache: Fix use of uninitialized valuetools/ | +4 | 0 replies | |
| 6/18 | perf env: Remove unnecessary NULL teststools/ | +3 | 0 replies | |
| 7/18 | perf jitdump: Avoid memory leaktools/ | +1 | 0 replies | |
| 8/18 | perf mem-events: Avoid uninitialized readtools/ | +2 | 0 replies | |
| 9/18 | perf dlfilter: Be defensive against potential NULL dereferencetools/ | +3 | 0 replies | |
| 10/18 | perf hists browser: Reorder variables to reduce paddingtools/ | +2 | 0 replies | |
| 11/18 | perf hists browser: Avoid potential NULL dereferencetools/ | +1 | 0 replies | |
| 12/18 | perf svghelper: Avoid memory leaktools/ | +3 | 0 replies | |
| 13/18 | perf lock: Fix a memory leak on an error pathtools/ | +1 | 0 replies | |
| 14/18 | perf parse-events: Fix unlikely memory leak when cloning termstools/ | +3 | 0 replies | |
| 15/18 | tools api: Avoid potential double freetools/ | +1 | 0 replies | |
| 16/18 | perf trace-event-info: Avoid passing NULL value to closedirtools/ | +2 | 0 replies | |
| 17/18 | perf header: Fix various error path memory leakstools/ | +34 | 0 replies | |
| 18/18 | perf bpf_counter: Fix a few memory leakstools/ | +4 | 0 replies |
Reviews trailers per patch
4 of 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Nick Desaulniers | Namhyung Kim |
|---|---|---|
| Series | A-b | |
| 1/18 | R-b | |
| 2/18 | R-b | |
| 3/18 | R-b R-b | |
| 3/18 | R-b R-b | |
| 4/18 | ||
| 5/18 | ||
| 6/18 | ||
| 7/18 | ||
| 8/18 | ||
| 9/18 | ||
| 10/18 | ||
| 11/18 | ||
| 12/18 | ||
| 13/18 | ||
| 14/18 | ||
| 15/18 | ||
| 16/18 | ||
| 17/18 | ||
| 18/18 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/18] clang-tools support in tools
Allow the clang-tools scripts to work with builds in tools such as tools/perf and tools/lib/perf. An example use looks like:
```
$ cd tools/perf
$ make CC=clang CXX=clang++
$ ../../scripts/clang-tools/gen_compile_commands.py
$ ../../scripts/clang-tools/run-clang-tools.py clang-tidy compile_commands.json -checks=-*,readability-named-parameter
Skipping non-C file: 'tools/perf/bench/mem-memcpy-x86-64-asm.S'
Skipping non-C file: 'tools/perf/bench/mem-memset-x86-64-asm.S'
Skipping non-C file: 'tools/perf/arch/x86/tests/regs_load.S'
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings generated.
4 warnings generated.
Suppressed 4 warnings (4 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings generated.
tools/perf/util/parse-events-flex.c:546:27: warning: all parameters should be named in a function [readability-named-parameter]
void *yyalloc ( yy_size_t , yyscan_t yyscanner );
^
/*size*/
...
```Fix a number of the more serious low-hanging issues in perf found by clang-tidy.
This support isn't complete, in particular it doesn't support output directories properly and so fails for tools/lib/bpf, tools/bpf/bpftool and if an output directory is used.
v3. Add Nick Desaulniers reviewed-by to patch 3. For Namhyung, drop
"perf hisi-ptt: Fix potential memory leak", split lock change out of "perf svghelper: Avoid memory leak" and address comments in "perf header: Fix various error path memory leaks".
v2: Address comments by Nick Desaulniers in patch 3, and add their
Reviewed-by to patches 1 and 2.
Ian Rogers (18):
gen_compile_commands: Allow the line prefix to still be cmd_
gen_compile_commands: Sort output compile commands by file name
run-clang-tools: Add pass through checks and header-filter arguments perf bench uprobe: Fix potential use of memory after free perf buildid-cache: Fix use of uninitialized value
perf env: Remove unnecessary NULL tests
perf jitdump: Avoid memory leak
perf mem-events: Avoid uninitialized read
perf dlfilter: Be defensive against potential NULL dereference perf hists browser: Reorder variables to reduce padding perf hists browser: Avoid potential NULL dereference
perf svghelper: Avoid memory leak
perf lock: Fix a memory leak on an error path
perf parse-events: Fix unlikely memory leak when cloning terms tools api: Avoid potential double free
perf trace-event-info: Avoid passing NULL value to closedir perf header: Fix various error path memory leaks
perf bpf_counter: Fix a few memory leaks
scripts/clang-tools/gen_compile_commands.py | 8 +-- scripts/clang-tools/run-clang-tools.py | 32 ++++++++--- tools/lib/api/io.h | 1 + tools/perf/bench/uprobe.c | 1 + tools/perf/builtin-buildid-cache.c | 6 ++- tools/perf/builtin-lock.c | 1 + tools/perf/ui/browsers/hists.c | 6 +-- tools/perf/util/bpf_counter.c | 5 +- tools/perf/util/dlfilter.c | 4 +- tools/perf/util/env.c | 6 +-- tools/perf/util/header.c | 60 ++++++++++++--------- tools/perf/util/jitdump.c | 1 + tools/perf/util/mem-events.c | 3 +- tools/perf/util/parse-events.c | 4 +- tools/perf/util/svghelper.c | 5 +- tools/perf/util/trace-event-info.c | 3 +- 16 files changed, 94 insertions(+), 52 deletions(-)
Signature · 1 line
2.42.0.609.gbb76f46606-goog