Skip to content

RFC benchmarks/gem_wsim: added basic xe support

Marcin Bernatowicz igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest14 patches 21 repliesIn review

v2 from the cover letter

- minimizing divergence - same workload syntax for both drivers, so most existing examples should run on xe unmodified (Tvrtko) This version creates one common VM per workload. Explicit VM management, compute mode, improved engine handling to come in next patchset.
- split patches to easy review (Tvrtko)
- dropped already merged patches, added documentation to public lib functions, some code cleanups (Kamil)

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14lib/igt_device_scan: Xe get integrated/discrete card functionslib/igt_device_scan.c lib/igt_device_scan.h+45 -90 replies
2/14benchmarks/gem_wsim: reposition the unbound duration booleanbenchmarks/gem_wsim.c+5 -51 reply
3/14benchmarks/gem_wsim: fix scaling of period stepsbenchmarks/gem_wsim.c+8 -21 reply
4/14benchmarks/gem_wsim: fix duration range checkbenchmarks/gem_wsim.c+1 -11 reply
5/14benchmarks/gem_wsim: extract duration parsing code to new functionbenchmarks/gem_wsim.c+37 -301 reply
6/14benchmarks/gem_wsim: fix conflicting SSEU #define and enumbenchmarks/gem_wsim.c+3 -31 reply
7/14benchmarks/gem_wsim: cleanupsbenchmarks/gem_wsim.c+34 -223 replies
8/14benchmarks/gem_wsim: reposition repeat_start variablebenchmarks/gem_wsim.c+3 -51 reply
9/14benchmarks/gem_wsim: use lib code to query enginesbenchmarks/gem_wsim.c+19 -1382 replies
10/14benchmarks/gem_wsim: allow comments in workload description filesbenchmarks/gem_wsim.c benchmarks/wsim/README+20 -13 replies
11/14benchmarks/gem_wsim: introduce w_step_sync functionbenchmarks/gem_wsim.c+11 -61 reply
12/14benchmarks/gem_wsim: extract prepare contexts code to new functionbenchmarks/gem_wsim.c+20 -102 replies
13/14benchmarks/gem_wsim: extract prepare working sets code to new functionbenchmarks/gem_wsim.c+58 -481 reply
14/14benchmarks/gem_wsim: added basic xe supportbenchmarks/gem_wsim.c benchmarks/wsim/README+485 -363 replies

Reviews trailers per patch

6 of 14 patches have a Reviewed-by or Acked-by.

PatchTvrtko Ursulin
1/14
2/14R-b
3/14
4/14R-b
5/14
6/14R-b
7/14
8/14R-b
9/14
10/14
11/14R-b
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 00/14] [RFC] benchmarks/gem_wsim: added basic xe support

Added basic xe support. Single binary handles both i915 and Xe devices.

Some functionality is still missing: working sets, bonding.

The tool is handy for scheduling tests, we find it useful to verify vGPU profiles defining different execution quantum/preemption timeout settings.

There is also some rationale for the tool in following thread:
https://lore.kernel.org/dri-devel/[email protected]/

With this patch it should be possible to run following on xe device:

gem_wsim -w benchmarks/wsim/media_load_balance_fhd26u7.wsim -c 36 -r 600

Best with drm debug logs disabled:

echo 0 > /sys/module/drm/parameters/debug

v2:
- minimizing divergence - same workload syntax for both drivers, so most existing examples should run on xe unmodified (Tvrtko) This version creates one common VM per workload. Explicit VM management, compute mode, improved engine handling to come in next patchset.
- split patches to easy review (Tvrtko)
- dropped already merged patches, added documentation to public lib functions, some code cleanups (Kamil)

Marcin Bernatowicz (14):
lib/igt_device_scan: Xe get integrated/discrete card functions benchmarks/gem_wsim: reposition the unbound duration boolean benchmarks/gem_wsim: fix scaling of period steps benchmarks/gem_wsim: fix duration range check benchmarks/gem_wsim: extract duration parsing code to new function benchmarks/gem_wsim: fix conflicting SSEU #define and enum benchmarks/gem_wsim: cleanups
benchmarks/gem_wsim: reposition repeat_start variable benchmarks/gem_wsim: use lib code to query engines benchmarks/gem_wsim: allow comments in workload description files benchmarks/gem_wsim: introduce w_step_sync function benchmarks/gem_wsim: extract prepare contexts code to new function benchmarks/gem_wsim: extract prepare working sets code to new function benchmarks/gem_wsim: added basic xe support

 benchmarks/gem_wsim.c  | 963 +++++++++++++++++++++++++++++------------
 benchmarks/wsim/README |   8 +-
 lib/igt_device_scan.c  |  52 ++-
 lib/igt_device_scan.h  |   2 +
 4 files changed, 729 insertions(+), 296 deletions(-)
Signature · 1 line
2.42.0