Skip to content

platform/x86: int3472: don't use gpiod_toggle_active_low()

Bartosz Golaszewski linux-acpi linux-gpio lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4platform/x86: int3472: provide a helper for getting GPIOs from lookupsdrivers/platform/x86/intel/int3472/common.c drivers/platform/x86/intel/int3472/common.h+38 -01 reply
2/4platform/x86: int3472: led: don't use gpiod_toggle_active_low()drivers/platform/x86/intel/int3472/led.c+4 -87 replies
3/4platform/x86: int3472: clk_and_regulator: use GPIO lookup tablesdrivers/platform/x86/intel/int3472/clk_and_regulator.c+9 -131 reply
4/4gpio: acpi: remove acpi_get_and_request_gpiod()drivers/gpio/gpiolib-acpi.c include/linux/gpio/consumer.h+0 -363 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFrom: Andy ShevchenkoMika Westerberg
SeriesR-b R-b
1/4
2/4
3/4
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFT PATCH 0/4] platform/x86: int3472: don't use gpiod_toggle_active_low()

From: Bartosz Golaszewski <[email protected]>

gpiod_toggle_active_low() is a badly designed API that should have never been used elsewhere then in the MMC code. And even there we should find a better solution.

Replace the uses of it in the int3472 driver with the good old temporary lookup table trick. This is not very pretty either but it's the lesser evil.

Bartosz Golaszewski (4):
platform/x86: int3472: provide a helper for getting GPIOs from lookups platform/x86: int3472: led: don't use gpiod_toggle_active_low() platform/x86: int3472: clk_and_regulator: use GPIO lookup tables
gpio: acpi: remove acpi_get_and_request_gpiod()

 drivers/gpio/gpiolib-acpi.c                   | 28 ------------------
 .../x86/intel/int3472/clk_and_regulator.c     | 22 ++++++--------
 drivers/platform/x86/intel/int3472/common.c   | 29 +++++++++++++++++++
 drivers/platform/x86/intel/int3472/common.h   |  9 ++++++
 drivers/platform/x86/intel/int3472/led.c      | 12 +++-----
 include/linux/gpio/consumer.h                 |  8 -----
 6 files changed, 51 insertions(+), 57 deletions(-)
Signature · 1 line
2.39.2