platform/x86: int3472: don't use gpiod_toggle_active_low()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 18 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | platform/x86: int3472: provide a helper for getting GPIOs from lookupsdrivers/ drivers/ | +38 | 1 reply | |
| 2/4 | platform/x86: int3472: led: don't use gpiod_toggle_active_low()drivers/ | +4 | 7 replies | |
| 3/4 | platform/x86: int3472: clk_and_regulator: use GPIO lookup tablesdrivers/ | +9 | 1 reply | |
| 4/4 | gpio: acpi: remove acpi_get_and_request_gpiod()drivers/ include/ | +0 | 3 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | From: Andy Shevchenko | Mika Westerberg |
|---|---|---|
| Series | R-b R-b | |
| 1/4 | ||
| 2/4 | ||
| 3/4 | ||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFT PATCH 0/4] platform/x86: int3472: don't use gpiod_toggle_active_low()
From: Bartosz Golaszewski <[email protected]>
gpiod_toggle_active_low() is a badly designed API that should have never been used elsewhere then in the MMC code. And even there we should find a better solution.
Replace the uses of it in the int3472 driver with the good old temporary lookup table trick. This is not very pretty either but it's the lesser evil.
Bartosz Golaszewski (4):
platform/x86: int3472: provide a helper for getting GPIOs from lookups platform/x86: int3472: led: don't use gpiod_toggle_active_low() platform/x86: int3472: clk_and_regulator: use GPIO lookup tables
gpio: acpi: remove acpi_get_and_request_gpiod()
drivers/gpio/gpiolib-acpi.c | 28 ------------------ .../x86/intel/int3472/clk_and_regulator.c | 22 ++++++-------- drivers/platform/x86/intel/int3472/common.c | 29 +++++++++++++++++++ drivers/platform/x86/intel/int3472/common.h | 9 ++++++ drivers/platform/x86/intel/int3472/led.c | 12 +++----- include/linux/gpio/consumer.h | 8 ----- 6 files changed, 51 insertions(+), 57 deletions(-)
Signature · 1 line
2.39.2