Skip to content

x86: expo: Add support for editing coreboot CMOS RAM settings

Simon Glass u-boot 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest20 patches 15 repliesIn review
  2. v219 patches 6 repliesSuperseded
  3. v134 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- Update Dockerfile instead

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20video: Add a dark-grey console colourboot/scene.c drivers/video/video-uclass.c include/video.h+5 -11 reply
2/20video: Avoid starting a new line to close to the bottomdrivers/video/vidconsole-uclass.c include/video.h include/video_console.h+13 -21 reply
3/20expo: Place menu items to the right of all labelsboot/cedit.c boot/expo.c boot/scene.c +5 more+104 -111 reply
4/20expo: Set the initial next_id to 1boot/expo.c test/boot/expo.c+22 -21 reply
5/20expo: Use standard numbering for save and discardboot/cedit.c boot/expo.c doc/develop/cedit.rst +7 more+112 -411 reply
6/20expo: Allow menu items to have valuesarch/sandbox/dts/cedit.dtsi boot/expo_build.c boot/scene_internal.h +5 more+58 -41 reply
7/20expo: Add a little more cedit CMOS loggingboot/cedit.c+4 -21 reply
8/20expo: Support menu-item values in ceditboot/cedit.c boot/scene_menu.c doc/usage/cmd/cedit.rst +2 more+117 -601 reply
9/20expo: Drop unneceesary calls to expo_str()boot/expo_build.c+2 -141 reply
10/20expo: Drop scene_title_set()boot/expo_build.c boot/scene.c include/expo.h +1 more+3 -191 reply
11/20expo: Add forward declaration for udevice to ceditinclude/cedit.h+1 -01 reply
12/20x86: coreboot: Enable unit testsconfigs/coreboot_defconfig+4 -00 replies
13/20docker: Update coreboottools/docker/Dockerfile+5 -22 replies
14/20doc: Update coreboot's CI informationdoc/board/coreboot/coreboot.rst+1 -131 reply
15/20x86: coreboot: Add a test for cbsysinfo commandtest/cmd/Makefile test/cmd/coreboot.c+37 -00 replies
16/20x86: coreboot: Show the option tablecmd/x86/cbsysinfo.c doc/usage/cmd/cbsysinfo.rst test/cmd/coreboot.c+178 -10 replies
17/20x86: coreboot: Enable support for the configuration editorarch/x86/dts/coreboot.dts configs/coreboot64_defconfig configs/coreboot_defconfig+11 -00 replies
18/20x86: coreboot: Add a command to check and update CMOS RAMcmd/Kconfig cmd/x86/Makefile cmd/x86/cbcmos.c +3 more+235 -00 replies
19/20x86: coreboot: Allow building an expo for editing CMOS configboot/Makefile boot/expo_build_cb.c cmd/cedit.c +6 more+405 -10 replies
20/20x86: Enable RTC command by defaultcmd/Kconfig+1 -01 reply

Reviews trailers per patch

1 of 20 patches has a Reviewed-by or Acked-by.

PatchTom Rini
1/20
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20R-b R-b
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/20] x86: expo: Add support for editing coreboot CMOS RAM settings

U-Boot provides support for editing settings with an 'expo', as well as reading and writing settings to CMOS RAM.

This series integrates expo functionality with coreboot, using the sysinfo table to get a list of settings, creating an expo with them and allowing them to be edited.

A new CI test provides coverage for some coreboot-related commands. For this to work, a number of minor tweaks are made to existing tests, so that they pass on coreboot (x86) or at least are skipped when they cannot pass. Likely most of these fixes will apply to other boards too.

It includes several other fixes and improvements:
- new -m flag for 'bootflow scan' so it can display a menu automatically
- Fix for video-scrolling crash with Truetype
- menu items can now have individual integer values
- menu items are lined up according to the width of all menu labels

Changes in v3:
- Update Dockerfile instead

Changes in v2:
- Avoid using common.h
- Avoid using common.h
- Rebase to -next

Simon Glass (20):
video: Add a dark-grey console colour
video: Avoid starting a new line to close to the bottom
expo: Place menu items to the right of all labels
expo: Set the initial next_id to 1
expo: Use standard numbering for save and discard
expo: Allow menu items to have values
expo: Add a little more cedit CMOS logging
expo: Support menu-item values in cedit
expo: Drop unneceesary calls to expo_str()
expo: Drop scene_title_set()
expo: Add forward declaration for udevice to cedit
x86: coreboot: Enable unit tests
docker: Update coreboot
doc: Update coreboot's CI information
x86: coreboot: Add a test for cbsysinfo command
x86: coreboot: Show the option table
x86: coreboot: Enable support for the configuration editor
x86: coreboot: Add a command to check and update CMOS RAM
x86: coreboot: Allow building an expo for editing CMOS config
x86: Enable RTC command by default

 arch/sandbox/dts/cedit.dtsi       |   3 +
 arch/x86/dts/coreboot.dts         |   7 +
 boot/Makefile                     |   3 +
 boot/cedit.c                      | 191 +++++++++++++++--------
 boot/expo.c                       |   3 +
 boot/expo_build.c                 |  36 ++---
 boot/expo_build_cb.c              | 245 ++++++++++++++++++++++++++++++
 boot/scene.c                      |  61 ++++++--
 boot/scene_internal.h             |  30 +++-
 boot/scene_menu.c                 |  26 +++-
 boot/scene_textline.c             |   3 +-
 cmd/Kconfig                       |  12 ++
 cmd/cedit.c                       |  28 ++++
 cmd/x86/Makefile                  |   1 +
 cmd/x86/cbcmos.c                  | 139 +++++++++++++++++
 cmd/x86/cbsysinfo.c               |  73 ++++++++-
 configs/coreboot64_defconfig      |   2 +
 configs/coreboot_defconfig        |   6 +
 doc/board/coreboot/coreboot.rst   |  16 +-
 doc/develop/cedit.rst             |   9 +-
 doc/develop/expo.rst              |  26 +++-
 doc/usage/cmd/cbcmos.rst          |  45 ++++++
 doc/usage/cmd/cbsysinfo.rst       |  99 ++++++++++++
 doc/usage/cmd/cedit.rst           |  91 ++++++++++-
 doc/usage/index.rst               |   1 +
 drivers/video/vidconsole-uclass.c |   4 +-
 drivers/video/video-uclass.c      |   3 +
 include/cedit.h                   |   1 +
 include/expo.h                    |  51 +++++--
 include/test/cedit-test.h         |  30 ++--
 include/video.h                   |   4 +-
 include/video_console.h           |   8 +
 test/boot/cedit.c                 |  22 ++-
 test/boot/expo.c                  |  26 +++-
 test/boot/files/expo_ids.h        |   3 +-
 test/boot/files/expo_layout.dts   |   5 +-
 test/cmd/Makefile                 |   1 +
 test/cmd/coreboot.c               | 119 +++++++++++++++
 tools/docker/Dockerfile           |   7 +-
 tools/expo.py                     |  33 +++-
 40 files changed, 1309 insertions(+), 164 deletions(-)
 create mode 100644 boot/expo_build_cb.c
 create mode 100644 cmd/x86/cbcmos.c
 create mode 100644 doc/usage/cmd/cbcmos.rst
 create mode 100644 test/cmd/coreboot.c
Signature · 1 line
2.34.1