Skip to content

Fix DT based address translations

Herve Codina linux-devicetree lkml oe-kbuild-all 2 versions – Applied

Status from this message: I've applied this. I sent out this series[1] of clean-ups to apply on

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v11 patch 3 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1
Simplify of_bus_default_flags_map().
Fix the commit log (pci-ep-bus ranges[0] size is 0x200_0000 instead of 0x2000_0000).

- Patch 2 (new in v2)
Remove duplicated code.

- Patch 3 (new in v2)
Add unit tests.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3of: address: Fix address translation when address-size is greater than 2drivers/of/address.c+28 -20 replies
2/3of: address: Remove duplicated functionsdrivers/of/address.c+2 -110 replies
3/3of: unittest: Add tests for address translationsdrivers/of/unittest-data/tests-address.dtsi drivers/of/unittest.c+175 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fix DT based address translations

Hi,

This patch series fixes a DT based address translation (translations using the ranges property).

The issue is present with a ranges property made of a 3 cells child address, a 3 cells parent address and a 2 cells child size. This can happen with the recent addition of of_pci_prop_ranges() in commit 407d1a51921e ("PCI: Create device tree node for bridge")

The issue description is fully described in the first patch commit log.

In this series,
- The first patch fixes the issue.
- The second patch avoids duplicated code.
- The third patch adds unit tests related address translations.

I previously sent the first patch alone:
https://lore.kernel.org/linux-kernel/[email protected]/
This series v2 has to be considered as the next iteration based on the review done on my previous patch sent alone.

Best regards,
Hervé

Changes v1 -> v2

- Patch 1
Simplify of_bus_default_flags_map().
Fix the commit log (pci-ep-bus ranges[0] size is 0x200_0000 instead of 0x2000_0000).

- Patch 2 (new in v2)
Remove duplicated code.

- Patch 3 (new in v2)
Add unit tests.

Herve Codina (3):
of: address: Fix address translation when address-size is greater than

    2

of: address: Remove duplicated functions
of: unittest: Add tests for address translations

 drivers/of/address.c                        |  43 ++++++---
 drivers/of/unittest-data/tests-address.dtsi | 101 ++++++++++++++++++++
 drivers/of/unittest.c                       |  74 ++++++++++++++
 3 files changed, 205 insertions(+), 13 deletions(-)
Signature · 1 line
2.41.0