Skip to content

ASoC: codecs: wcd938x: fix probe and bind error handling

Johan Hovold alsa-devel lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ASoC: codecs: wcd938x: drop bogus bind error handlingsound/soc/codecs/wcd938x.c+0 -40 replies
2/7ASoC: codecs: wcd938x: fix unbind tear down ordersound/soc/codecs/wcd938x.c+1 -10 replies
3/7ASoC: codecs: wcd938x: fix resource leaks on bind errorssound/soc/codecs/wcd938x.c+34 -100 replies
4/7ASoC: codecs: wcd938x: fix regulator leaks on probe errorssound/soc/codecs/wcd938x.c+15 -30 replies
5/7ASoC: codecs: wcd938x: fix runtime PM imbalance on removesound/soc/codecs/wcd938x.c+8 -20 replies
6/7ASoC: codecs: wcd938x-sdw: fix use after free on driver unbindsound/soc/codecs/wcd938x-sdw.c+10 -00 replies
7/7ASoC: codecs: wcd938x-sdw: fix runtime PM imbalance on probe errorssound/soc/codecs/wcd938x-sdw.c+16 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] ASoC: codecs: wcd938x: fix probe and bind error handling

The wcd938x codec driver happily ignores error handling, something which has bitten us in the past when we hit a probe deferral:

	https://lore.kernel.org/lkml/[email protected]/

Fix up the remaining probe and component bind paths that left resources allocated and registered after errors to avoid similar future issues.

Johan

Johan Hovold (7):
ASoC: codecs: wcd938x: drop bogus bind error handling
ASoC: codecs: wcd938x: fix unbind tear down order
ASoC: codecs: wcd938x: fix resource leaks on bind errors
ASoC: codecs: wcd938x: fix regulator leaks on probe errors
ASoC: codecs: wcd938x: fix runtime PM imbalance on remove
ASoC: codecs: wcd938x-sdw: fix use after free on driver unbind
ASoC: codecs: wcd938x-sdw: fix runtime PM imbalance on probe errors

 sound/soc/codecs/wcd938x-sdw.c | 27 +++++++++++-
 sound/soc/codecs/wcd938x.c     | 76 +++++++++++++++++++++++++---------
 2 files changed, 83 insertions(+), 20 deletions(-)
Signature · 1 line
2.41.0