platform/chrome: cros_ec_lpc: add support for AMD Framework Laptops
Status from this message: This series was applied to chrome-platform/linux.git (for-kernelci)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 6 repliesApplied 4/4
- v24 patches 2 repliesSuperseded
- v14 patches 9 repliesSuperseded
Changes in v3 from the cover letter
* Addressed dev_warn feedback from Thomas Weissschuh
* Removed the host command region quirk; Framework Computer is slated to release a firmware update that addresses the I/O region issue from this series' v1 and v2. This leaves just one quirk, with the potential for future quirks (e.g. changes required to reduce EC bus contention on the Intel Framework Laptops)
Patches in v3 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | platform/chrome: cros_ec_lpc: introduce a priv struct for the lpc devicedrivers/ | +21 | 0 replies | Applied |
| 2/4 | platform/chrome: cros_ec_lpc: pass driver_data from DMI to the devicedrivers/ | +7 | 0 replies | Applied |
| 3/4 | platform/chrome: cros_ec_lpc: add a "quirks" systemdrivers/ | +31 | 0 replies | Applied |
| 4/4 | platform/chrome: cros_ec_lpc: add quirks for the Framework Laptop (AMD)drivers/ | +15 | 0 replies | Applied |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Thomas Weißschuh | Mario Limonciello |
|---|---|---|
| Series | Reviewed-and-tested-by | T-b |
| 1/4 | ||
| 2/4 | ||
| 3/4 | ||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/4] platform/chrome: cros_ec_lpc: add support for AMD Framework Laptops
This patch series adds support for the AMD models of the Framework Laptop (both 13" and 16").
These models of Framework Laptop have switched to an NPCX embedded controller, which uses the original Chrome EC linear memory-mapped I/O model.
However, these devices are not configured in a way that is compatible with the cros_ec driver. Instead of mapping EC memory to I/O ports [0x900, 0x9FF], they map it to ports [0xE00, 0xEFF].
To address this difference without impacting cros_ec_lpcs' compatibility with Chromebook/Chromebox devices or the existing Framework Laptop platform, these patches add DMI match-specific driver data through which we can detect per-machine "quirks".
Quirks toggle changes in cros_ec_lpcs' behavior, such as remapping the memory MMIO window.
Changes in v2:
* Separated Framework Laptop (Intel) and Framework Laptop (AMD)
* dev_warn has been demoted to dev_info
* Style fixes
* Reworded the individual patch bodies for clarity and style
Changes in v3:
* Addressed dev_warn feedback from Thomas Weissschuh
* Removed the host command region quirk; Framework Computer is slated to release a firmware update that addresses the I/O region issue from this series' v1 and v2. This leaves just one quirk, with the potential for future quirks (e.g. changes required to reduce EC bus contention on the Intel Framework Laptops)
Dustin L. Howett (4):
platform/chrome: cros_ec_lpc: introduce a priv struct for the lpc
device
platform/chrome: cros_ec_lpc: pass driver_data from DMI to the device platform/chrome: cros_ec_lpc: add a "quirks" system platform/chrome: cros_ec_lpc: add quirks for the Framework Laptop
(AMD)
drivers/platform/chrome/cros_ec_lpc.c | 81 ++++++++++++++++++++++++--- 1 file changed, 74 insertions(+), 7 deletions(-)
Signature · 1 line
2.43.0