Skip to content

RFC benchmarks/gem_wsim: added basic xe support

Marcin Bernatowicz igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest17 patches 9 repliesIn review

v2 from the cover letter

- split patches to easy review (Kamil),
all benchmarks/gem_wsim patches before [RFC] one
contain fixes (for scale duration option), cleanups (checkpatch.pl), refactors (some code moved to functions),
not related to xe and ready to be applied
- lib/xe_spin is under review in other thread https://patchwork.freedesktop.org/series/122624/

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17lib/igt_device_scan: added functions to get first Xe cardlib/igt_device_scan.c lib/igt_device_scan.h+45 -90 replies
2/17benchmarks/gem_wsim: reposition the unbound duration booleanbenchmarks/gem_wsim.c+5 -50 replies
3/17benchmarks/gem_wsim: fix duration range checkbenchmarks/gem_wsim.c+2 -20 replies
4/17benchmarks/gem_wsim: extract duration parsing code to new functionbenchmarks/gem_wsim.c+40 -300 replies
5/17benchmarks/gem_wsim: fix conflicting SSEU #define and enumbenchmarks/gem_wsim.c+11 -110 replies
6/17benchmarks/gem_wsim: cleanupsbenchmarks/gem_wsim.c+33 -210 replies
7/17benchmarks/gem_wsim: reposition repeat_start variablebenchmarks/gem_wsim.c+3 -50 replies
8/17benchmarks/gem_wsim: use lib code to query enginesbenchmarks/gem_wsim.c+17 -1360 replies
9/17benchmarks/gem_wsim: allow comments in workload description filesbenchmarks/gem_wsim.c benchmarks/wsim/README+19 -11 reply
10/17benchmarks/gem_wsim: introduce w_step_sync functionbenchmarks/gem_wsim.c+11 -60 replies
11/17benchmarks/gem_wsim: extract allocate and prepare contexts code to new functionsbenchmarks/gem_wsim.c+32 -110 replies
12/17benchmarks/gem_wsim: extract prepare working sets code to new functionbenchmarks/gem_wsim.c+56 -480 replies
13/17benchmarks/gem_wsim: group i915 fieldsbenchmarks/gem_wsim.c+52 -480 replies
14/17benchmarks/gem_wsim: for_each_dep macrobenchmarks/gem_wsim.c+25 -200 replies
15/17benchmarks/gem_wsim: for_each_ctx macrobenchmarks/gem_wsim.c+26 -202 replies
16/17benchmarks/gem_wsim: for_each_w_step macrobenchmarks/gem_wsim.c+42 -383 replies
17/17benchmarks/gem_wsim: added basic xe supportbenchmarks/gem_wsim.c benchmarks/wsim/README+483 -273 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchKamil KoniecznyTvrtko Ursulin
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 00/17] [RFC] benchmarks/gem_wsim: added basic xe support

Added basic xe support. Single binary handles both i915 and Xe devices.

Some functionality is still missing: working sets, bonding.

The tool is handy for scheduling tests, we find it useful to verify vGPU profiles defining different execution quantum/preemption timeout settings.

There is also some rationale for the tool in following thread:
https://lore.kernel.org/dri-devel/[email protected]/

With this patch it should be possible to run following on xe device:

gem_wsim -w benchmarks/wsim/media_load_balance_fhd26u7.wsim -c 36 -r 600

Best with drm debug logs disabled:

echo 0 > /sys/module/drm/parameters/debug

v2:
- split patches to easy review (Kamil),
all benchmarks/gem_wsim patches before [RFC] one
contain fixes (for scale duration option), cleanups (checkpatch.pl), refactors (some code moved to functions),
not related to xe and ready to be applied
- lib/xe_spin is under review in other thread https://patchwork.freedesktop.org/series/122624/

v3:
- minimizing divergence - same workload syntax for both drivers, so most existing examples should run on xe unmodified (Tvrtko) This version creates one common VM per workload. Explicit VM management, compute mode, improved engine handling to come in next patchset.
- split patches to easy review (Tvrtko)
- dropped already merged patches, added documentation to public lib functions, some code cleanups (Kamil)

v4:
- addressed review comments in previous patches
- added patch with for_each_dep macro (Tvrtko)
- added patch with bb_size field in w_step
- grouped xe specific fields (Tvrtko)
- moved is_xe boolean next to fd (Tvrtko)
- use xe_ prefix for Xe specific things (Tvrtko)
- left throttling untouched (Tvrtko)
- parse errors vs silent skips on not implemented steps (Tvrtko)
- add 'Xe and i915 differences' section to README (Tvrtko) for now no data dependency implemented, left -1 <=> f-1 to not modify examples (maybe too optimistic assumption?)
- need to think on better engine handling in next version

v5:
- correct out of bound access if file ends with hash (Tvrtko)
- new patches intruducing for_each_ctx, for_each_w_step macros
- corrected engines mappings for xe
ex. "M.1.VCS,B.1,1.DEFAULT.1000.0.1" should use VCS
- verified engines selection works on MTL (Tvrtko)
- prevent misuse combinations of fence and implicit data deps (Tvrtko) ex. "f,1.DEFAULT.1000.-1.0" should fail,

      "f,1.DEFAULT.1000.f-1.0" is valid

- corrected error messages (Tvrtko)
- missing xe_device_put (Tvrtko)
- moved wsim_err up to be accessible from parse_dependencies
- left fini_workload cleanup for separate patch
- README updates

Marcin Bernatowicz (17):
lib/igt_device_scan: added functions to get first Xe card benchmarks/gem_wsim: reposition the unbound duration boolean benchmarks/gem_wsim: fix duration range check benchmarks/gem_wsim: extract duration parsing code to new function benchmarks/gem_wsim: fix conflicting SSEU #define and enum benchmarks/gem_wsim: cleanups
benchmarks/gem_wsim: reposition repeat_start variable benchmarks/gem_wsim: use lib code to query engines benchmarks/gem_wsim: allow comments in workload description files benchmarks/gem_wsim: introduce w_step_sync function benchmarks/gem_wsim: extract allocate and prepare contexts code to new
functions
benchmarks/gem_wsim: extract prepare working sets code to new function benchmarks/gem_wsim: group i915 fields benchmarks/gem_wsim: for_each_dep macro benchmarks/gem_wsim: for_each_ctx macro benchmarks/gem_wsim: for_each_w_step macro benchmarks/gem_wsim: added basic xe support

 benchmarks/gem_wsim.c  | 1177 +++++++++++++++++++++++++++-------------
 benchmarks/wsim/README |   25 +-
 lib/igt_device_scan.c  |   52 +-
 lib/igt_device_scan.h  |    2 +
 4 files changed, 860 insertions(+), 396 deletions(-)
Signature · 1 line
2.42.0