Skip to content

Add OA functionality to Xe

Ashutosh Dixit dri-devel intel-xe 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v19 Latest17 patches 3 repliesIn review
  2. v1817 patches 0 repliesSuperseded
  3. v1717 patches 0 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v1617 patches14 repliesSuperseded
v1517 patches21 repliesSuperseded
v1417 patches0 repliesSuperseded
v1217 patches0 repliesSuperseded
v717 patches41 repliesSuperseded
v31 patch1 replySuperseded
v22 patches4 repliesSuperseded
v12 patches1 replySuperseded

Patches in v19 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/xe/perf/uapi: "Perf" layer to support multiple perf counter stream typesdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_perf.c +2 more+117 -00 replies
2/17drm/xe/perf/uapi: Add perf_stream_paranoid sysctldrivers/gpu/drm/xe/xe_module.c drivers/gpu/drm/xe/xe_perf.c drivers/gpu/drm/xe/xe_perf.h+51 -00 replies
3/17drm/xe/oa/uapi: Add OA data formatsdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h +4 more+244 -10 replies
4/17drm/xe/oa/uapi: Initialize OA unitsdrivers/gpu/drm/xe/regs/xe_oa_regs.h drivers/gpu/drm/xe/xe_gt_types.h drivers/gpu/drm/xe/xe_hw_engine_types.h +3 more+322 -00 replies
5/17drm/xe/oa/uapi: Add/remove OA config perf opsdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h +3 more+495 -03 replies
6/17drm/xe/oa/uapi: Define and parse OA stream propertiesdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa.h drivers/gpu/drm/xe/xe_perf.c +1 more+443 -00 replies
7/17drm/xe/oa: OA stream initialization (OAG)drivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h+475 -00 replies
8/17drm/xe/oa/uapi: Expose OA stream fddrivers/gpu/drm/xe/xe_oa.c include/uapi/drm/xe_drm.h+384 -00 replies
9/17drm/xe/oa/uapi: Read file_operationdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h include/uapi/drm/xe_drm.h+224 -00 replies
10/17drm/xe/oa: Add OAR supportdrivers/gpu/drm/xe/instructions/xe_mi_commands.h drivers/gpu/drm/xe/regs/xe_engine_regs.h drivers/gpu/drm/xe/xe_lrc.c +3 more+206 -50 replies
11/17drm/xe/oa: Add OAC supportdrivers/gpu/drm/xe/regs/xe_engine_regs.h drivers/gpu/drm/xe/regs/xe_oa_regs.h drivers/gpu/drm/xe/xe_oa.c+75 -30 replies
12/17drm/xe/oa/uapi: Query OA unit propertiesdrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_query.c include/uapi/drm/xe_drm.h+175 -00 replies
13/17drm/xe/oa/uapi: OA buffer mmapdrivers/gpu/drm/xe/xe_oa.c+46 -00 replies
14/17drm/xe/oa: Add MMIO trigger supportdrivers/gpu/drm/xe/regs/xe_oa_regs.h drivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_reg_whitelist.c+51 -20 replies
15/17drm/xe/oa: Override GuC RC with OA on PVCdrivers/gpu/drm/xe/xe_guc_pc.c drivers/gpu/drm/xe/xe_guc_pc.h drivers/gpu/drm/xe/xe_oa.c +1 more+87 -00 replies
16/17drm/xe/oa: Changes to OA_TAKENdrivers/gpu/drm/xe/xe_oa.c+13 -90 replies
17/17drm/xe/oa: Enable Xe2+ overrun modedrivers/gpu/drm/xe/xe_oa.c drivers/gpu/drm/xe/xe_oa_types.h+30 -80 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviJosé Roberto de SouzaUmesh Nerlige RamappaGuy Zadicario
1/17A-b A-b R-b A-b
2/17A-b A-b R-b
3/17A-b A-b R-b
4/17A-b A-b R-b
5/17A-b A-b R-b
6/17A-b A-b R-b
7/17A-b R-b
8/17A-b A-b R-b
9/17A-b A-b R-b
10/17A-b R-b
11/17A-b R-b
12/17A-b R-b
13/17A-b R-b
14/17A-b R-b
15/17A-b R-b
16/17A-b R-b
17/17A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v19 thread

Cover letter [PATCH v19 00/17] Add OA functionality to Xe

Please see cover letter for v7 here:
https://patchwork.freedesktop.org/series/121084/#rev7

For changes in later versions see changelog below.

This series is also available at:
https://gitlab.freedesktop.org/adixit/kernel/-/tree/xe-oa

The series has been tested against this IGT series:

        https://gitlab.freedesktop.org/adixit/igt-gpu-tools/-/tree/xe-oa
	or,
	https://patchwork.freedesktop.org/series/130033/

Opensource consumers using uapi in this series:

gpuvis:
https://github.com/mikesart/gpuvis/pull/86 (merged)

mesa:

	https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29312

Test-with: [email protected]

v2: Fix build
v3: Rebase, due to s/xe_engine/xe_exec_queue/
v4: Re-run for testing
v5: Address review comments, new patches 11 through 17
v6: New patches 18 through 21
v7: Patches are completely redone and don't start with i915 version of the uapi
v8: See https://patchwork.freedesktop.org/patch/575214/?series=128993&rev=1
v9: See https://patchwork.freedesktop.org/patch/577441/?series=128993&rev=2
v10: See https://patchwork.freedesktop.org/patch/577943/?series=128993&rev=3
v11: See https://patchwork.freedesktop.org/patch/581239/?series=130705&rev=1
v12: Add last two new patches to enable Xe2+ overrun mode
v13: Update last two patches after code review completion
v14: https://patchwork.freedesktop.org/patch/595447/?series=134028&rev=1
v15: https://patchwork.freedesktop.org/patch/595549/?series=134056&rev=1
v16: https://patchwork.freedesktop.org/patch/597768/?series=134634&rev=1
v17: https://patchwork.freedesktop.org/patch/598236/?series=134742&rev=1
v18: Rebase
v19: Add Rodrigo's A-b on the patches

Ashutosh Dixit (17):
drm/xe/perf/uapi: "Perf" layer to support multiple perf counter stream
types
drm/xe/perf/uapi: Add perf_stream_paranoid sysctl drm/xe/oa/uapi: Add OA data formats
drm/xe/oa/uapi: Initialize OA units
drm/xe/oa/uapi: Add/remove OA config perf ops drm/xe/oa/uapi: Define and parse OA stream properties drm/xe/oa: OA stream initialization (OAG)
drm/xe/oa/uapi: Expose OA stream fd
drm/xe/oa/uapi: Read file_operation
drm/xe/oa: Add OAR support
drm/xe/oa: Add OAC support
drm/xe/oa/uapi: Query OA unit properties
drm/xe/oa/uapi: OA buffer mmap
drm/xe/oa: Add MMIO trigger support
drm/xe/oa: Override GuC RC with OA on PVC
drm/xe/oa: Changes to OA_TAKEN
drm/xe/oa: Enable Xe2+ overrun mode

 drivers/gpu/drm/xe/Makefile                   |    2 +
 .../gpu/drm/xe/instructions/xe_mi_commands.h  |    1 +
 drivers/gpu/drm/xe/regs/xe_engine_regs.h      |    2 +
 drivers/gpu/drm/xe/regs/xe_gt_regs.h          |    3 +
 drivers/gpu/drm/xe/regs/xe_oa_regs.h          |  100 +
 drivers/gpu/drm/xe/xe_device.c                |   17 +-
 drivers/gpu/drm/xe/xe_device_types.h          |    4 +
 drivers/gpu/drm/xe/xe_gt_types.h              |    4 +
 drivers/gpu/drm/xe/xe_guc_pc.c                |   57 +
 drivers/gpu/drm/xe/xe_guc_pc.h                |    3 +
 drivers/gpu/drm/xe/xe_hw_engine_types.h       |    2 +
 drivers/gpu/drm/xe/xe_lrc.c                   |   11 +-
 drivers/gpu/drm/xe/xe_lrc.h                   |    1 +
 drivers/gpu/drm/xe/xe_module.c                |    5 +
 drivers/gpu/drm/xe/xe_oa.c                    | 2428 +++++++++++++++++
 drivers/gpu/drm/xe/xe_oa.h                    |   27 +
 drivers/gpu/drm/xe/xe_oa_types.h              |  239 ++
 drivers/gpu/drm/xe/xe_perf.c                  |   92 +
 drivers/gpu/drm/xe/xe_perf.h                  |   20 +
 drivers/gpu/drm/xe/xe_query.c                 |   77 +
 drivers/gpu/drm/xe/xe_reg_whitelist.c         |   24 +-
 include/uapi/drm/xe_drm.h                     |  305 +++
 22 files changed, 3417 insertions(+), 7 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/regs/xe_oa_regs.h
 create mode 100644 drivers/gpu/drm/xe/xe_oa.c
 create mode 100644 drivers/gpu/drm/xe/xe_oa.h
 create mode 100644 drivers/gpu/drm/xe/xe_oa_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_perf.c
 create mode 100644 drivers/gpu/drm/xe/xe_perf.h
Signature · 1 line
2.41.0