Skip to content

s390x: Improve console handling

Janosch Frank kvm 2 versions – Applied

Status from this message: Pushed to our internal CI for coverage, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesApplied
  2. v13 patches 10 repliesSuperseded

Changes in v2 from the cover letter

* Reworked detect_host routine to support being called in early setup
* Added length checks in sclp_print_ascii for compat handling
* Added Linux reference to lib/s390x/sclp-console.c header

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3lib: s390x: hw: rework do_detect_host so we don't need allocationlib/s390x/hardware.c+5 -61 reply
2/3lib: s390x: sclp: Add compat handling for HMC ASCII consoleslib/s390x/sclp-console.c+24 -11 reply
3/3lib: s390x: sclp: Add line mode input handlinglib/s390x/sclp-console.c lib/s390x/sclp.h+186 -210 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchClaudio Imbrenda
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [kvm-unit-tests PATCH v2 0/3] s390x: Improve console handling

Console IO is and has been in a state of "works for me". I don't think that will change soon since there's no need for a proper console driver when all we want is the ability to print or read a line at a time.

However since input is only supported on the ASCII console I was forced to use it on the HMC. The HMC generally does not add a \r on a \n so each line doesn't start at column 0. It's time to finally fix that.

Also, since there are environments that only provide the line-mode console it's time to add line-mode input to properly support them.

v2:
* Reworked detect_host routine to support being called in early setup
* Added length checks in sclp_print_ascii for compat handling
* Added Linux reference to lib/s390x/sclp-console.c header
v1:
* Fenced ASCII compat handling so it's only use in LPAR
* Squashed compat handling into one patch
* Added an early detect_host since SCLP might be used in setup
* Fixed up a few formatting issues in input patch
* Fixed up copyright stuff

Janosch Frank (3):
lib: s390x: hw: rework do_detect_host so we don't need allocation
lib: s390x: sclp: Add compat handling for HMC ASCII consoles
lib: s390x: sclp: Add line mode input handling

 lib/s390x/hardware.c     |  11 +--
 lib/s390x/sclp-console.c | 206 +++++++++++++++++++++++++++++++++++----
 lib/s390x/sclp.h         |  26 ++++-
 3 files changed, 215 insertions(+), 28 deletions(-)
Signature · 1 line
2.34.1