SVM guest shadow stack support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 26 repliesIn review
Changes in v1 from the cover letter
- Remove RFC tag from series
- Rebase on v6 of the Intel CET virtualization series
- Use KVM-governed feature to track SHSTK for SVM
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | KVM: x86: SVM: Emulate reads and writes to shadow stack MSRsarch/ | +18 | 1 reply | |
| 2/9 | KVM: x86: SVM: Update dump_vmcb with shadow stack save area additionsarch/ | +4 | 1 reply | |
| 3/9 | KVM: x86: SVM: Pass through shadow stack MSRsarch/ arch/ | +27 | 7 replies | |
| 4/9 | KVM: SVM: Rename vmplX_ssp -> plX_ssparch/ | +4 | 1 reply | |
| 5/9 | KVM: SVM: Save shadow stack host state on VMRUNarch/ | +9 | 2 replies | |
| 6/9 | KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernelarch/ arch/ arch/ +1 more | +14 | 8 replies | |
| 7/9 | x86/sev-es: Include XSS value in GHCB CPUID requestarch/ | +15 | 4 replies | |
| 8/9 | KVM: SVM: Use KVM-governed features to track SHSTKarch/ | +1 | 1 reply | |
| 9/9 | KVM: SVM: Add CET features to supported_xssarch/ | +4 | 1 reply |
Reviews trailers per patch
6 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Maxim Levitsky |
|---|---|
| 1/9 | R-b |
| 2/9 | R-b |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] SVM guest shadow stack support
AMD Zen3 and newer processors support shadow stack, a feature designed to protect against ROP (return-oriented programming) attacks in which an attacker manipulates return addresses on the call stack in order to execute arbitrary code. To prevent this, shadow stacks can be allocated that are only used by control transfer and return instructions. When a CALL instruction is issued, it writes the return address to both the program stack and the shadow stack. When the subsequent RET instruction is issued, it pops the return address from both stacks and compares them. If the addresses don't match, a control-protection exception is raised.
Shadow stack and a related feature, Indirect Branch Tracking (IBT), are collectively referred to as Control-flow Enforcement Technology (CET). However, current AMD processors only support shadow stack and not IBT.
This series adds support for shadow stack in SVM guests and builds upon the support added in the CET guest support patch series [1]. Additional patches are required to support shadow stack enabled guests in qemu [2].
[1]: CET guest support patches (v6)
https://lore.kernel.org/all/[email protected]/
[2]: CET qemu patches
https://lore.kernel.org/all/[email protected]/
RFC v3 series:
https://lore.kernel.org/all/[email protected]/
---
RFC v2:
- Rebased on v3 of the Intel CET virtualization series, dropping the patch that moved cet_is_msr_accessible to common code as that has been pulled into the Intel series.
- Minor change removing curly brackets around if statement introduced
in patch 6/6.
RFC v3:
- Rebased on v5 of the Intel CET virtualization series.
- Add patch changing the name of vmplX_ssp SEV-ES save area fields to plX_ssp.
- Merge this series intended for KVM with the separate guest kernel
patch (now patch 7/8).
- Update MSR passthrough code to conditionally pass through shadow stack MSRS based on both host and guest support.
- Don't save PL0_SSP, PL1_SSP, and PL2_SSP MSRs on SEV-ES VMRUN as these are currently unused.
v1:
- Remove RFC tag from series
- Rebase on v6 of the Intel CET virtualization series
- Use KVM-governed feature to track SHSTK for SVM
John Allen (9):
KVM: x86: SVM: Emulate reads and writes to shadow stack MSRs
KVM: x86: SVM: Update dump_vmcb with shadow stack save area additions
KVM: x86: SVM: Pass through shadow stack MSRs
KVM: SVM: Rename vmplX_ssp -> plX_ssp
KVM: SVM: Save shadow stack host state on VMRUN
KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernel x86/sev-es: Include XSS value in GHCB CPUID request
KVM: SVM: Use KVM-governed features to track SHSTK
KVM: SVM: Add CET features to supported_xss
arch/x86/include/asm/svm.h | 9 +++--- arch/x86/kernel/sev-shared.c | 15 ++++++++++ arch/x86/kvm/svm/sev.c | 21 ++++++++++++-- arch/x86/kvm/svm/svm.c | 54 ++++++++++++++++++++++++++++++++++++ arch/x86/kvm/svm/svm.h | 3 +- 5 files changed, 95 insertions(+), 7 deletions(-)
Signature · 1 line
2.40.1