Skip to content

Miscellaneous Sparse fixes

Benjamin Gray linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12powerpc/xive: Fix endian conversion sizearch/powerpc/sysdev/xive/native.c+1 -10 replies
2/12powerpc/pseries: Restructure hvc_get_chars() endiannessarch/powerpc/platforms/pseries/hvconsole.c+3 -32 replies
3/12powerpc: Explicitly reverse bytes when checking for byte reversalarch/powerpc/sysdev/mpic.c+1 -10 replies
4/12powerpc: Use NULL instead of 0 for null pointersarch/powerpc/kernel/setup_64.c arch/powerpc/kvm/book3s_xive_native.c arch/powerpc/net/bpf_jit_comp.c +3 more+12 -120 replies
5/12powerpc: Remove extern from function implementationsarch/powerpc/kernel/iommu.c arch/powerpc/kernel/traps.c arch/powerpc/kvm/book3s_64_vio.c+10 -100 replies
6/12powerpc: Annotate endianness of various variables and functionsarch/powerpc/include/asm/book3s/64/pgtable.h arch/powerpc/include/asm/imc-pmu.h arch/powerpc/kernel/prom_init.c +7 more+26 -230 replies
7/12powerpc/kvm: Force cast endianness of KVM shared regsarch/powerpc/include/asm/kvm_ppc.h+4 -40 replies
8/12powerpc/opal: Annotate out param endiannessarch/powerpc/include/asm/opal.h+1 -10 replies
9/12powerpc/uaccess: Cast away __user annotation after verificationarch/powerpc/include/asm/uaccess.h+1 -10 replies
10/12powerpc: Cast away __iomem in low level IO routinesarch/powerpc/kernel/io.c+6 -60 replies
11/12powerpc/eeh: Remove unnecessary castarch/powerpc/kernel/eeh_driver.c+2 -20 replies
12/12powerpc/fadump: Annotate endianness cast with __forcearch/powerpc/platforms/powernv/opal-fadump.h+1 -10 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchAneesh Kumar K.V
1/12
2/12R-b
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] Miscellaneous Sparse fixes

There are many Sparse warnings in the kernel, including the powerpc directory. This series provides fixes for some low-hanging fruit found when trying to triage the warnings earlier this year. It addresses about 100 warnings (many have the same root cause).

I know there's concerns about making it harder to backport things. In general, as someone who was not around during the development of these features, I think that it is useful make the annotations as correct as possible. But it's no fuss if some/all of the patches are nacked for this reason. I just figured some of it might be useful instead of continuing to sit on it indefinitely.

Benjamin Gray (12):
powerpc/xive: Fix endian conversion size powerpc/pseries: Restructure hvc_get_chars() endianness
powerpc: Explicitly reverse bytes when checking for byte reversal
powerpc: Use NULL instead of 0 for null pointers
powerpc: Remove extern from function implementations
powerpc: Annotate endianness of various variables and functions powerpc/kvm: Force cast endianness of KVM shared regs powerpc/opal: Annotate out param endianness powerpc/uaccess: Cast away __user annotation after verification
powerpc: Cast away __iomem in low level IO routines powerpc/eeh: Remove unnecessary cast
powerpc/fadump: Annotate endianness cast with __force

 arch/powerpc/include/asm/book3s/64/pgtable.h    |  2 +-
 arch/powerpc/include/asm/imc-pmu.h              | 16 ++++++++--------
 arch/powerpc/include/asm/kvm_ppc.h              |  8 ++++----
 arch/powerpc/include/asm/opal.h                 |  2 +-
 arch/powerpc/include/asm/uaccess.h              |  2 +-
 arch/powerpc/kernel/eeh_driver.c                |  4 ++--
 arch/powerpc/kernel/io.c                        | 12 ++++++------
 arch/powerpc/kernel/iommu.c                     |  8 ++++----
 arch/powerpc/kernel/prom_init.c                 |  2 +-
 arch/powerpc/kernel/setup_64.c                  |  2 +-
 arch/powerpc/kernel/traps.c                     |  4 ++--
 arch/powerpc/kexec/core_64.c                    |  4 ++--
 arch/powerpc/kexec/file_load_64.c               |  6 +++---
 arch/powerpc/kvm/book3s_64_vio.c                |  8 ++++----
 arch/powerpc/kvm/book3s_xive_native.c           |  2 +-
 arch/powerpc/mm/drmem.c                         |  2 +-
 arch/powerpc/net/bpf_jit_comp.c                 |  8 ++++----
 arch/powerpc/perf/hv-24x7.c                     |  2 +-
 arch/powerpc/perf/imc-pmu.c                     | 11 ++++++-----
 arch/powerpc/platforms/4xx/soc.c                |  2 +-
 arch/powerpc/platforms/powermac/feature.c       |  3 ++-
 arch/powerpc/platforms/powernv/opal-fadump.h    |  2 +-
 arch/powerpc/platforms/pseries/hotplug-memory.c |  3 ++-
 arch/powerpc/platforms/pseries/hvconsole.c      |  6 +++---
 arch/powerpc/platforms/pseries/lpar.c           |  8 ++++----
 arch/powerpc/sysdev/mpic.c                      |  2 +-
 arch/powerpc/sysdev/xive/native.c               |  2 +-
 27 files changed, 68 insertions(+), 65 deletions(-)
Signature · 1 line
2.39.2