BPF verifier log improvements
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | selftests/bpf: improve percpu_alloc test robustnesstools/ tools/ tools/ | +14 | 2 replies | Applied |
| 2/5 | selftests/bpf: improve missed_kprobe_recursion test robustnesstools/ | +4 | 1 reply | Applied |
| 3/5 | selftests/bpf: make align selftests more robusttools/ | +121 | 0 replies | Applied |
| 4/5 | bpf: disambiguate SCALAR register state output in verifier logskernel/ tools/ tools/ | +55 | 4 replies | Applied |
| 5/5 | bpf: ensure proper register state printing for cond jumpskernel/ | +6 | 0 replies | Applied |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | John Fastabend | Jiri Olsa | Eduard Zingerman |
|---|---|---|---|
| Series | A-b | A-b | |
| 1/5 | |||
| 2/5 | A-b | ||
| 3/5 | |||
| 4/5 | |||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH bpf-next 0/5] BPF verifier log improvements
This patch set fixes ambiguity in BPF verifier log output of SCALAR register in the parts that emit umin/umax, smin/smax, etc ranges. See patch #4 for details.
Also, patch #5 fixes an issue with verifier log missing instruction context (state) output for conditionals that trigger precision marking. See details in the patch.
First two patches are just improvements to two selftests that are very flaky locally when run in parallel mode.
Patch #3 changes 'align' selftest to be less strict about exact verifier log output (which patch #4 changes, breaking lots of align tests as written). Now test does more of a register substate checks, mostly around expected var_off() values. This 'align' selftests is one of the more brittle ones and requires constant adjustment when verifier log output changes, without really catching any new issues. So hopefully these changes can minimize future support efforts for this specific set of tests.
Andrii Nakryiko (5):
selftests/bpf: improve percpu_alloc test robustness selftests/bpf: improve missed_kprobe_recursion test robustness selftests/bpf: make align selftests more robust
bpf: disambiguate SCALAR register state output in verifier logs
bpf: ensure proper register state printing for cond jumps
kernel/bpf/verifier.c | 74 ++++-- .../testing/selftests/bpf/prog_tests/align.c | 241 +++++++++--------- .../testing/selftests/bpf/prog_tests/missed.c | 8 +- .../selftests/bpf/prog_tests/percpu_alloc.c | 3 + .../selftests/bpf/progs/exceptions_assert.c | 18 +- .../selftests/bpf/progs/percpu_alloc_array.c | 7 + .../progs/percpu_alloc_cgrp_local_storage.c | 4 + .../selftests/bpf/progs/verifier_ldsx.c | 2 +- 8 files changed, 200 insertions(+), 157 deletions(-)
Signature · 1 line
2.34.1