Skip to content

PCI/DPC: Improve register field accessing

Ilpo Järvinen linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: Add PCI_EXP_DPC_* field detailsinclude/uapi/linux/pci_regs.h+7 -00 replies
2/2PCI/DPC: Use defines with register fieldsdrivers/pci/pcie/dpc.c+24 -152 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] PCI/DPC: Improve register field accessing

This an alternative approach to the patch in:
https://lore.kernel.org/linux-pci/[email protected]/

It adds names to all the reason literals too (which makes it incompatible with FIELD_GET() for the reason and ext_reason). When the reasons are named instead of literals, it's very easy to understand the code just by reading it (no need to lookup the meaning of those numbers from spec or otherwise).

Also 0xfff4 the other patch missed is converted here.

Just let me know if I should, for example, base the additional changes on top of that other change.

Ilpo Järvinen (2):
PCI: Add PCI_EXP_DPC_* field details
PCI/DPC: Use defines with register fields

 drivers/pci/pcie/dpc.c        | 39 +++++++++++++++++++++--------------
 include/uapi/linux/pci_regs.h |  7 +++++++
 2 files changed, 31 insertions(+), 15 deletions(-)
Signature · 1 line
2.30.2