Skip to content

Move framebuffer reservation for SPL to RAM end

Devarsh Thakkar u-boot 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 5 repliesIn review
  2. v48 patches 5 repliesSuperseded
  3. v2 posting 2/26 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/25 patches9 repliesSuperseded
v1 RFC5 patches4 repliesSuperseded

Changes in v5 from the cover letter

- Add comment for filling video handoff size with aligned size
- Use PHASE_BOARD_F while checking for U-boot proper stage
- Add Reviewed-by

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8spl: Enforce framebuffer reservation from end of RAMcommon/spl/spl.c include/spl.h+29 -00 replies
2/8arm: mach-k3: common: Reserve video memory from end of the RAMarch/arm/mach-k3/common.c+12 -50 replies
3/8board: ti: am62x: evm: Remove video_setup from spl_board_initboard/ti/am62x/evm.c+0 -180 replies
4/8common/board_f: Catch bloblist before starting reservationscommon/board_f.c+30 -30 replies
5/8video: Skip framebuffer reservation if already reservedcommon/board_f.c drivers/video/video-uclass.c+14 -40 replies
6/8video: Fill video handoff in video post probedrivers/video/video-uclass.c+20 -100 replies
7/8doc: spl: Add info for missing Kconfigsdoc/develop/spl.rst+9 -00 replies
8/8doc: spl: Add info regarding memory reservationdoc/develop/spl.rst+28 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchSimon GlassNikhil M Jain
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] Move framebuffer reservation for SPL to RAM end

Move video memory reservation for SPL at end of RAM so that it does not interefere with reservations for next stage so that the next stage need not have holes in between for passed regions and instead it can maintain continuity in reservations.

Also catch the bloblist before starting reservations to avoid the same problem.

While at it, also fill missing fields in video handoff struct before passing it to next stage.

This is as per discussions at :
For moving SPL framebuffer reservation at end of RAM:

https://lore.kernel.org/all/CAPnjgZ3xSoe_G3yrqwuAvoiVjUfZ+YQgkOR0ZTVXGT9VK8TwJg@mail.gmail.com/

For filling missing video handoff fields :
https://lore.kernel.org/all/CAPnjgZ1Hs0rNf0JDirp6YPsOQ5=QqQSP9g9qRwLoOASUV8a4cw@mail.gmail.com/

Changelog:
V2:
- Make a generic function to reserve video memory at SPL stage.
- Add debug prints while skipping framebuffer allocation at uboot.
- Correct commenting style as suggested.

V3:
- Change spl_reserve_video to spl_reserve_video_from_ram_top which enforce framebuffer reservation from end of RAM.
- Use gd->ram_top instead of local ram_top and update gd->reloc_addr after each reservation.
- Print error message on framebuffer reservation.
- Update SPL doc with spl splash screen specific info.

V4:
- Split patches into atomic commits.
- Remove duplicate check for video blob passed addresses and error out if invalid address/size received from blob.
- Improve SPL documentation memory reservation scheme and print message for video memory reservation from bloblist.
- Add Reviewed-By.

V5:
- Add comment for filling video handoff size with aligned size
- Use PHASE_BOARD_F while checking for U-boot proper stage
- Add Reviewed-by

Test logs:
https://gist.github.com/devarsht/30a3c1591270c9ebae00714b48d33058

Devarsh Thakkar (8):
spl: Enforce framebuffer reservation from end of RAM
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62x: evm: Remove video_setup from spl_board_init common/board_f: Catch bloblist before starting reservations
video: Skip framebuffer reservation if already reserved
video: Fill video handoff in video post probe
doc: spl: Add info for missing Kconfigs
doc: spl: Add info regarding memory reservation

 arch/arm/mach-k3/common.c    | 17 ++++++++++-----
 board/ti/am62x/evm.c         | 18 ----------------
 common/board_f.c             | 41 +++++++++++++++++++++++++++++++-----
 common/spl/spl.c             | 19 +++++++++++++++++
 doc/develop/spl.rst          | 37 ++++++++++++++++++++++++++++++++
 drivers/video/video-uclass.c | 40 ++++++++++++++++++++++++-----------
 include/spl.h                | 10 +++++++++
 7 files changed, 142 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1