Skip to content

drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

Andy Shevchenko dri-devel intel-gfx lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest16 patches 17 repliesIn review
  2. v315 patches 7 repliesSuperseded
  3. v27 patches 15 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drm/i915/dsi: assume BXT gpio works for non-native GPIOdrivers/gpu/drm/i915/display/intel_dsi_vbt.c+1 -90 replies
2/16drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915drivers/gpu/drm/i915/display/intel_dsi_vbt.c+7 -70 replies
3/16drm/i915/dsi: clarify GPIO exec sequencedrivers/gpu/drm/i915/display/intel_dsi_vbt.c+17 -140 replies
4/16drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()drivers/gpu/drm/i915/display/intel_dsi_vbt.c+10 -100 replies
5/16drm/i915/dsi: bxt/icl GPIO set value do not need gpio sourcedrivers/gpu/drm/i915/display/intel_dsi_vbt.c+3 -30 replies
6/16drm/i915/dsi: Replace while(1) with one with clear exit conditiondrivers/gpu/drm/i915/display/intel_dsi_vbt.c+1 -40 replies
7/16drm/i915/dsi: Get rid of redundant 'else'drivers/gpu/drm/i915/display/intel_dsi_vbt.c+28 -300 replies
8/16drm/i915/dsi: Replace check with a (missing) MIPI sequence namedrivers/gpu/drm/i915/display/intel_dsi_vbt.c+2 -10 replies
9/16drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()drivers/gpu/drm/i915/display/intel_dsi_vbt.c+9 -160 replies
10/16drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()drivers/gpu/drm/i915/display/intel_dsi_vbt.c+1 -30 replies
11/16drm/i915/dsi: Extract common soc_gpio_set_value() helperdrivers/gpu/drm/i915/display/intel_dsi_vbt.c+26 -200 replies
12/16drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's backdrivers/gpu/drm/i915/display/intel_dsi_vbt.c+28 -700 replies
13/16drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communitiesdrivers/gpu/drm/i915/display/intel_dsi_vbt.c+10 -100 replies
14/16drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's backdrivers/gpu/drm/i915/display/intel_dsi_vbt.c+10 -370 replies
15/16drm/i915/dsi: Combine checks in mipi_exec_gpio()drivers/gpu/drm/i915/display/intel_dsi_vbt.c+1 -30 replies
16/16drm/i915/iosf: Drop unused APIsdrivers/gpu/drm/i915/vlv_sideband.c drivers/gpu/drm/i915/vlv_sideband.h+0 -200 replies

Reviews trailers per patch

10 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJani NikulaAndi ShytiHans de Goede
SeriesT-b R-b
1/16
2/16
3/16
4/16
5/16
6/16A-b R-b
7/16A-b R-b
8/16A-b R-b
9/16A-b
10/16A-b
11/16A-b
12/16A-b
13/16A-b
14/16A-b
15/16
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

DSI code for VBT has a set of ugly GPIO hacks, one of which is direct talking to GPIO IP behind the actual driver's back. A second attempt to fix that is here.

If I understood correctly, my approach should work in the similar way as the current IOSF GPIO.

Hans, I believe you have some devices that use this piece of code, is it possible to give a test run on (one of) them?

In v4:
- fixed compile time errors in patch 14 (Hans, LKP)
- fixed cover letter Subject
- added patch 15 (as suggested by Ville)
- added Ack tag (Jani)

In v3:
- incorporated series by Jani
- incorporated couple of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View

In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well

Andy Shevchenko (9):
drm/i915/dsi: Replace while(1) with one with clear exit condition drm/i915/dsi: Get rid of redundant 'else'
drm/i915/dsi: Replace check with a (missing) MIPI sequence name drm/i915/dsi: Extract common soc_gpio_set_value() helper drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
communities
drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back drm/i915/dsi: Combine checks in mipi_exec_gpio() drm/i915/iosf: Drop unused APIs

Hans de Goede (2):
drm/i915/dsi: Remove GPIO lookup table at the end of
intel_dsi_vbt_gpio_init()
drm/i915/dsi: Fix wrong initial value for GPIOs in
bxt_gpio_set_value()

Jani Nikula (5):
drm/i915/dsi: assume BXT gpio works for non-native GPIO drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915 drm/i915/dsi: clarify GPIO exec sequence drm/i915/dsi: rename platform specific *_exec_gpio() to

    *_gpio_set_value()

drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
 drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
 drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
 3 files changed, 136 insertions(+), 239 deletions(-)
Signature · 1 line
2.40.0.1.gaa8946217a0b