Skip to content

gpiolib: acpi: More fixes to the consolidation rework

Andy Shevchenko linux-acpi linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()drivers/gpio/gpiolib-acpi.c+1 -02 replies
2/3gpiolib: Fix debug messaging in gpiod_find_and_request()drivers/gpio/gpiolib-acpi.c drivers/gpio/gpiolib-acpi.h drivers/gpio/gpiolib-of.c +4 more+39 -307 replies
3/3gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusingdrivers/gpio/gpiolib.c+8 -91 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDmitry TorokhovFerry TothLinus Walleij
SeriesT-b
1/3R-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework

On top what Hans already fixed, Ferry reported a few bugs that pointed out to the same consolidation rework done in v6.2.

The first is most serious issue, that needs to be fixed ASAP.

The second is good to have.

And the third one I'm not fully okay with, so open for advice on how to improve.

Note, that long list of parameters to a _find_gpio() functions can be hidden in the specifically crafted a new data structure, but this is out of scope of the _fixes_ series. I'm all ears as well for that one.

Andy Shevchenko (3):
gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()
gpiolib: Fix debug messaging in gpiod_find_and_request()
gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing

 drivers/gpio/gpiolib-acpi.c   | 10 ++++-----
 drivers/gpio/gpiolib-acpi.h   | 13 ++++++------
 drivers/gpio/gpiolib-of.c     | 13 ++++++------
 drivers/gpio/gpiolib-of.h     |  8 ++++----
 drivers/gpio/gpiolib-swnode.c |  4 ++--
 drivers/gpio/gpiolib-swnode.h |  1 +
 drivers/gpio/gpiolib.c        | 38 ++++++++++++++++++++---------------
 7 files changed, 48 insertions(+), 39 deletions(-)
Signature · 1 line
2.40.0.1.gaa8946217a0b