Skip to content

nvme: start keep-alive after admin queue setup

Hannes Reinecke linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 11 repliesIn review
  2. v14 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvme-tcp: avoid open-coding nvme_tcp_teardown_admin_queue()drivers/nvme/host/tcp.c+1 -50 replies
2/3nvme-loop: always quiesce and cancel commands before destroying admin qdrivers/nvme/target/loop.c+4 -00 replies
3/3nvme: start keep-alive after admin queue setupdrivers/nvme/host/core.c drivers/nvme/host/fc.c+9 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/3] nvme: start keep-alive after admin queue setup

Hi all,

Setting up I/O queues might take quite some time on larger and/or busy setups, so KATO might expire on the admin queue before all I/O queues can be setup.
This patchset fixes this issue by moving the call to start keep-alive into the ->init_ctrl_finish() callback, and move the call to stop keep-alives into nvme_cancel_admin_tagset().

As usual, comments and reviews are welcome.

Changes to the original version:
- Reworked to use nvme_cancel_admin_tagset()

Hannes Reinecke (3):
nvme-tcp: avoid open-coding nvme_tcp_teardown_admin_queue()
nvme-loop: always quiesce and cancel commands before destroying admin
q
nvme: start keep-alive after admin queue setup

 drivers/nvme/host/core.c   | 6 +++---
 drivers/nvme/host/fc.c     | 6 ++++++
 drivers/nvme/host/tcp.c    | 6 +-----
 drivers/nvme/target/loop.c | 4 ++++
 4 files changed, 14 insertions(+), 8 deletions(-)
Signature · 1 line
2.35.3