Skip to content

exact states comparison for iterator convergence checks

Eduard Zingerman bpf oe-kbuild-all 3 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 2 repliesApplied 7/7
  2. v27 patches 8 repliesSuperseded
  3. v15 patches 1 replySuperseded

Changelog from the cover letter

- V2 [3] -> V3:
- correct check for stack spills in widen_imprecise_scalars(), added test case progs/iters.c:widen_spill to check the behavior (suggested by Andrii);
- allow eviction of checkpoint states in is_state_visited() to avoid pathological verifier performance when iterator based loop does not converge (discussion with Alexei).
- V1 [2] -> V2, applied changes suggested by Alexei offlist:
- __explored_state() function removed;
- same_callsites() function is now used in clean_live_states();
- patches #1,2 are added as preparatory code movement;
- in process_iter_next_call() a safeguard is added to verify that

Patches in v3 All 7 applied

#Subject and filesSizeRepliesApplied
1/7bpf: move explored_state() closer to the beginning of verifier.ckernel/bpf/verifier.c+13 -150 repliesApplied
2/7bpf: extract same_callsites() as utility functionkernel/bpf/verifier.c+15 -50 repliesApplied
3/7bpf: exact states comparison for iterator convergence checksinclude/linux/bpf_verifier.h kernel/bpf/verifier.c tools/testing/selftests/bpf/progs/iters_task_vma.c+189 -310 repliesApplied
4/7selftests/bpf: tests with delayed read/precision makrs in loop bodytools/testing/selftests/bpf/progs/iters.c+518 -00 repliesApplied
5/7bpf: correct loop detection for iterators convergenceinclude/linux/bpf_verifier.h kernel/bpf/verifier.c+218 -40 repliesApplied
6/7selftests/bpf: test if state loops are detected in a tricky casetools/testing/selftests/bpf/progs/iters.c+177 -00 repliesApplied
7/7bpf: print full verifier states on infinite loop detectionkernel/bpf/verifier.c+4 -00 repliesApplied

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchAndrii Nakryiko
1/7
2/7
3/7
4/7
5/7R-b
6/7
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/7] exact states comparison for iterator convergence checks

Iterator convergence logic in is_state_visited() uses state_equals() for states with branches counter > 0 to check if iterator based loop converges. This is not fully correct because state_equals() relies on presence of read and precision marks on registers. These marks are not guaranteed to be finalized while state has branches.
Commit message for patch #3 describes a program that exhibits such behavior.

This patch-set aims to fix iterator convergence logic by adding notion of exact states comparison. Exact comparison does not rely on presence of read or precision marks and thus is more strict.
As explained in commit message for patch #3 exact comparisons require addition of speculative register bounds widening. The end result for BPF verifier users could be summarized as follows:

(!) After this update verifier would reject programs that conjure an
imprecise value on the first loop iteration and use it as precise on the second (for iterator based loops).

I urge people to at least skim over the commit message for patch #3.

Patches are organized as follows:
- patches #1,2: moving/extracting utility functions;
- patch #3: introduces exact mode for states comparison and adds widening heuristic;
- patch #4: adds test-cases that demonstrate why the series is necessary;
- patch #5: extends patch #3 with a notion of state loop entries, these entries have to be tracked to correctly identify that different verifier states belong to the same states loop;
- patch #6: adds a test-case that demonstrates a program which requires loop entry tracking for correct verification;
- patch #7: just adds a few debug prints.

The following actions are planned as a followup for this patch-set:
- implementation has to be adapted for callbacks handling logic as a part of a fix for [1];
- it is necessary to explore ways to improve widening heuristic to handle iters_task_vma test w/o need to insert barrier_var() calls;
- explored states eviction logic on cache miss has to be extended to either:
- allow eviction of checkpoint states -or-
- be sped up in case if there are many active checkpoints associated with the same instruction.

The patch-set is a followup for mailing list discussion [1].

Changelog:
- V2 [3] -> V3:
- correct check for stack spills in widen_imprecise_scalars(), added test case progs/iters.c:widen_spill to check the behavior (suggested by Andrii);
- allow eviction of checkpoint states in is_state_visited() to avoid pathological verifier performance when iterator based loop does not converge (discussion with Alexei).
- V1 [2] -> V2, applied changes suggested by Alexei offlist:
- __explored_state() function removed;
- same_callsites() function is now used in clean_live_states();
- patches #1,2 are added as preparatory code movement;
- in process_iter_next_call() a safeguard is added to verify that

    cur_st->parent exists and has expected insn index / call sites.

[1] https://lore.kernel.org/bpf/[email protected]/
[2] https://lore.kernel.org/bpf/[email protected]/
[3] https://lore.kernel.org/bpf/[email protected]/

Eduard Zingerman (7):
bpf: move explored_state() closer to the beginning of verifier.c
bpf: extract same_callsites() as utility function
bpf: exact states comparison for iterator convergence checks selftests/bpf: tests with delayed read/precision makrs in loop body
bpf: correct loop detection for iterators convergence selftests/bpf: test if state loops are detected in a tricky case
bpf: print full verifier states on infinite loop detection

 include/linux/bpf_verifier.h                  |  16 +
 kernel/bpf/verifier.c                         | 475 ++++++++++--
 tools/testing/selftests/bpf/progs/iters.c     | 695 ++++++++++++++++++
 .../selftests/bpf/progs/iters_task_vma.c      |   1 +
 4 files changed, 1133 insertions(+), 54 deletions(-)
Signature · 1 line
2.42.0