Skip to content

visl: Add a tpg_verbose parameter for reference comparison

Detlev Casanova linux-media lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 0 repliesNew
  2. v44 patches 0 repliesSuperseded
  3. v34 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches8 repliesSuperseded
v15 patches2 repliesSuperseded

Changes in v5 from the cover letter

- Remove unnecessary changes in visl_get_ref_frames
- Fix missing space after &&

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: visl,vidtv: Set parameters permissions to 0444drivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/visl/visl-core.c+18 -180 replies
2/4media: visl: Add a tpg_verbose parameterdrivers/media/test-drivers/visl/visl-core.c drivers/media/test-drivers/visl/visl-dec.c drivers/media/test-drivers/visl/visl.h+153 -1180 replies
3/4doc: visl: Document tpg_verbose parameterDocumentation/admin-guide/media/visl.rst+10 -20 replies
4/4visl: Add codec specific variability on output framesdrivers/media/test-drivers/visl/visl-dec.c+36 -00 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchDaniel Almeida
1/4R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] visl: Add a tpg_verbose parameter for reference comparison

When using visl in automated tests, we need to have output frames that can be compared to reference frames or hash of those to validate that the whole pipeline is working properly.

Make sure that a given input stream always outputs the same frames. This is done by removing TPG information like queues status and pointer values.

Introduce the tpg_verbose parameter to allow adding the more verbose information that this patchset removes

This also adds some stable variation in the frames so that different input give more different output.

Changes since v4:
- Remove unnecessary changes in visl_get_ref_frames
- Fix missing space after &&
Changes since v3:
- Fix some more permissions in vidtv
- Rename stable_output to tpg_verbose
- Rebase on media_stage/master to include AV1 support
- Remove code churn in visl_get_ref_frames()
- Remove code duplication in visl_tpg_fill_sequence()
Changes since v2:
- Set parameters permissions to 0444 in visl and vidtv
- Make stable_output true by default
- Keep showing frames timestamps and remove vb2 buffer indexes only in stable output mode
- Make codec_variablility non optional (remove parameter, keep implementation)
- Add details on used variability fields
Changes since v1:
- Fix typo in parameter documentation

Detlev Casanova (4):
media: visl,vidtv: Set parameters permissions to 0444
media: visl: Add a tpg_verbose parameter
doc: visl: Document tpg_verbose parameter
visl: Add codec specific variability on output frames

 Documentation/admin-guide/media/visl.rst      |  12 +-
 .../media/test-drivers/vidtv/vidtv_bridge.c   |  26 +-
 drivers/media/test-drivers/visl/visl-core.c   |  15 +-
 drivers/media/test-drivers/visl/visl-dec.c    | 301 +++++++++++-------
 drivers/media/test-drivers/visl/visl.h        |   1 +
 5 files changed, 217 insertions(+), 138 deletions(-)
Signature · 1 line
2.43.0