Skip to content

5.15.137-rc2 review

Greg Kroah-Hartman damon linux-patches lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 135 patches 9 repliesIn review

Patches in v1 No applies recorded yet

None of the 135 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchFlorian FainelliSlade WatkinsAllen PaisSeongJae ParkLinux Kernel Functional TestingHarshit MogalapalliRon EconomosSudip MukherjeeGuenter Roeck
SeriesT-b T-b T-b T-b T-b T-b T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v1 thread

Cover letter [PATCH 5.15 000/135] 5.15.137-rc2 review

This is the start of the stable review cycle for the 5.15.137 release. There are 135 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Thu, 26 Oct 2023 08:32:55 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.137-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 5.15.137-rc2

Zhang Changzhong <[email protected]>
xfrm6: fix inet6_dev refcount underflow problem

Kees Cook <[email protected]>
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name

Edward AD <[email protected]>
Bluetooth: hci_sock: fix slab oob read in create_monitor_event

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix runtime PM for remove

Tony Lindgren <[email protected]>
phy: mapphone-mdm6600: Fix runtime disable on probe

Geert Uytterhoeven <[email protected]>
serial: 8250: omap: Move uart_write() inside PM section

Dan Carpenter <[email protected]>
ASoC: pxa: fix a memory leak in probe()

Haibo Chen <[email protected]>
gpio: vf610: set value before the direction to avoid a glitch

Hans de Goede <[email protected]>

    platform/x86: asus-wmi: Map 0x2a code, Ignore 0x2b and 0x2c events

Hans de Goede <[email protected]>

    platform/x86: asus-wmi: Change ASUS_WMI_BRN_DOWN code from 0x20 to 0x2e

Armin Wolf <[email protected]>
platform/surface: platform_profile: Propagate error if profile registration fails

Dinghao Liu <[email protected]>
s390/cio: fix a memleak in css_alloc_subchannel

Francis Laniel <[email protected]>
selftests/ftrace: Add new test case which checks non unique symbol

Niklas Schnelle <[email protected]>
s390/pci: fix iommu bitmap allocation

Peter Zijlstra <[email protected]>
perf: Disallow mis-matched inherited group reads

Puliang Lu <[email protected]>
USB: serial: option: add Fibocom to DELL custom modem FM101R-GL

Benoît Monin <[email protected]>
USB: serial: option: add entry for Sierra EM9191 with new firmware

Fabio Porcedda <[email protected]>

    USB: serial: option: add Telit LE910C4-WWX 0x1035 composition

Maurizio Lombardi <[email protected]>
nvme-rdma: do not try to stop unallocated queues

Keith Busch <[email protected]>
nvme-pci: add BOGUS_NID for Intel 0a54 device

Sunil V L <[email protected]>
ACPI: irq: Fix incorrect return value in acpi_register_gsi()

Olga Kornievskaia <[email protected]>
NFSv4.1: fixup use EXCHGID4_FLAG_USE_PNFS_DS for DS server

Trond Myklebust <[email protected]>
pNFS: Fix a hang in nfs4_evict_inode()

Andy Shevchenko <[email protected]>
Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"

Avri Altman <[email protected]>
mmc: core: Capture correct oemid-bits for eMMC cards

Haibo Chen <[email protected]>
mmc: core: sdio: hold retuning if sdio in 1-bit mode

Pablo Sun <[email protected]>
mmc: mtk-sd: Use readl_poll_timeout_atomic in msdc_reset_hw

Geert Uytterhoeven <[email protected]>
mtd: physmap-core: Restore map_rom fallback

Martin Kurbanov <[email protected]>
mtd: spinand: micron: correct bitmask for ecc status

Miquel Raynal <[email protected]>
mtd: rawnand: arasan: Ensure program page operations are successful

Miquel Raynal <[email protected]>
mtd: rawnand: marvell: Ensure program page operations are successful

Miquel Raynal <[email protected]>
mtd: rawnand: pl353: Ensure program page operations are successful

Bibek Kumar Patro <[email protected]>
mtd: rawnand: qcom: Unmap the right resource upon probe failure

Jakub Kicinski <[email protected]>
net: fix ifname in netlink ntf during netns move

Wolfram Sang <[email protected]>
net: move from strlcpy with unused retval to strscpy

Antoine Tenart <[email protected]>
net: introduce a function to check if a netdev name is in use

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_event: Fix using memcmp when comparing keys

Maher Sanalla <[email protected]>
net/mlx5: Handle fw tracer change ownership event based on MTRC

Renan Guilherme Lebre Ramos <[email protected]>
platform/x86: touchscreen_dmi: Add info for the Positivo C4128B

Rahul Rameshbabu <[email protected]>

    HID: multitouch: Add required quirk for Synaptics 0xcd7e device

Filipe Manana <[email protected]>
btrfs: error out when reallocating block for defrag using a stale transaction

Filipe Manana <[email protected]>
btrfs: error when COWing block from a root that is being deleted

Filipe Manana <[email protected]>
btrfs: error out when COWing block using a stale transaction

Josef Bacik <[email protected]>
btrfs: fix some -Wmaybe-uninitialized warnings in ioctl.c

Kai Uwe Broulik <[email protected]>
drm: panel-orientation-quirks: Add quirk for One Mix 2S

Hangbin Liu <[email protected]>
ipv4/fib: send notify when delete source address routes

Kees Cook <[email protected]>
sky2: Make sure there is at least one frag_addr available

Michał Mirosław <[email protected]>
regulator/core: Revert "fix kobject release warning and memory leak in regulator_register()"

Benjamin Berg <[email protected]>
wifi: cfg80211: avoid leaking stack data into trace

Wen Gong <[email protected]>
wifi: mac80211: allow transmitting EAPOL frames with tainted key

Ilan Peer <[email protected]>
wifi: cfg80211: Fix 6GHz scan configuration

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_core: Fix build warnings

Ying Hsu <[email protected]>
Bluetooth: Avoid redundant authentication

Rocky Liao <[email protected]>
Bluetooth: btusb: add shutdown function for QCA6174

Ma Ke <[email protected]>
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event

Ben Greear <[email protected]>
wifi: iwlwifi: Ensure ack flag is properly cleared.

Gustavo A. R. Silva <[email protected]>
wifi: mwifiex: Sanity check tlv_len and tlv_bitmap_len

Clément Léger <[email protected]>
tracing: relax trace_event_eval_update() execution with cond_resched()

Damien Le Moal <[email protected]>
ata: libata-eh: Fix compilation warning in ata_eh_link_report()

Damien Le Moal <[email protected]>
ata: libata-core: Fix compilation warning in ata_dev_config_ncq()

Chengfeng Ye <[email protected]>

    gpio: timberdale: Fix potential deadlock on &tgpio->lock

Jeff Layton <[email protected]>
overlayfs: set ctime when setting mtime and atime

Heiner Kallweit <[email protected]>
i2c: mux: Avoid potential false error message in i2c_mux_add_adapter

Josef Bacik <[email protected]>
btrfs: initialize start_slot in btrfs_log_prealloc_extents

Filipe Manana <[email protected]>
btrfs: return -EUCLEAN for delayed tree ref with a ref count not equals to 1

Chunhai Guo <[email protected]>
fs-writeback: do not requeue a clean inode having skipped pages

Tony Lindgren <[email protected]>
ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone

Namjae Jeon <[email protected]>
ksmbd: not allow to open file if delelete on close bit is set

Yanguo Li <[email protected]>
nfp: flower: avoid rmmod nfp crash issues

Jeremy Kerr <[email protected]>
mctp: perform route lookups under a RCU read-side lock

Jeremy Kerr <[email protected]>
mctp: Allow local delivery to the null EID

Michael Ellerman <[email protected]>
powerpc/47x: Fix 47x syscall return crash

Christophe Leroy <[email protected]>
powerpc/32s: Do kuep_lock() and kuep_unlock() in assembly

Christophe Leroy <[email protected]>
powerpc/32s: Remove capability to disable KUEP at boottime

Simon Ser <[email protected]>
drm/atomic-helper: relax unregistered connector check

JP Kobryn <[email protected]>
perf/x86/lbr: Filter vsyscall addresses

Sandipan Das <[email protected]>
perf/x86: Move branch classifier

Anshuman Khandual <[email protected]>
perf: Add irq and exception return branch types

Alisa-Dariana Roman <[email protected]>
iio: adc: ad7192: Correct reference voltage

Tzung-Bi Shih <[email protected]>
iio: cros_ec: fix an use-after-free in cros_ec_sensors_push_data()

Nuno Sá <[email protected]>
iio: core: introduce iio_device_{claim|release}_buffer_mode() APIs

Miquel Raynal <[email protected]>

    iio: core: Hide read accesses to iio_dev->currentmode

Miquel Raynal <[email protected]>
iio: Un-inline iio_buffer_enabled()

Tony Lindgren <[email protected]>
serial: 8250_omap: Fix errors with no_console_suspend

Tony Lindgren <[email protected]>
serial: 8250: omap: Fix imprecise external abort for omap_8250_pm()

Juntong Deng <[email protected]>
selftests/mm: fix awk usage in charge_reserved_hugetlb.sh and hugetlb_reparenting_test.sh that may cause error

Gavrilov Ilia <[email protected]>
net: pktgen: Fix interface flags printing

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: revert do not remove elements if set backend implements .abort

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: do not remove elements if set backend implements .abort

Pablo Neira Ayuso <[email protected]>
netfilter: nft_set_rbtree: .deactivate fails if element has expired

Geert Uytterhoeven <[email protected]>
neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section

Pedro Tammela <[email protected]>
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve

Jiri Wiesner <[email protected]>
bonding: Return pointer to data after pull on skb

Jinjie Ruan <[email protected]>
net: dsa: bcm_sf2: Fix possible memory leak in bcm_sf2_mdio_register()

Michal Schmidt <[email protected]>
i40e: prevent crash on probe if hw registers have invalid values

Dan Carpenter <[email protected]>
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()

Eric Dumazet <[email protected]>

    ipv4: fib: annotate races around nh->nh_saddr_genid and nh->nh_saddr

Eric Dumazet <[email protected]>
tun: prevent negative ifindex

Eric Dumazet <[email protected]>
tcp: tsq: relax tcp_small_queue_check() when rtx queue contains a single skb

Neal Cardwell <[email protected]>
tcp: fix excessive TLP and RACK timeouts from HZ rounding

Josua Mayer <[email protected]>
net: rfkill: gpio: prevent value glitch during probe

Ma Ke <[email protected]>
net: ipv6: fix return value check in esp_remove_trailer

Ma Ke <[email protected]>
net: ipv4: fix return value check in esp_remove_trailer

Eric Dumazet <[email protected]>
xfrm: interface: use DEV_STATS_INC()

Eric Dumazet <[email protected]>
xfrm: fix a data-race in xfrm_gen_index()

Manish Chopra <[email protected]>
qed: fix LL2 RX buffer allocation

Johan Hovold <[email protected]>
ASoC: codecs: wcd938x: fix unbind tear down order

Johan Hovold <[email protected]>
ASoC: codecs: wcd938x: drop bogus bind error handling

Johan Hovold <[email protected]>
ASoC: codecs: wcd938x-sdw: fix runtime PM imbalance on probe errors

Johan Hovold <[email protected]>
ASoC: codecs: wcd938x-sdw: fix use after free on driver unbind

Ville Syrjälä <[email protected]>
drm/i915: Retry gtt fault when out of fence registers

Sagi Grimberg <[email protected]>
nvmet-tcp: Fix a possible UAF in queue intialization setup

Florian Westphal <[email protected]>
netfilter: nft_payload: fix wrong mac header matching

Konstantin Komarov <[email protected]>
fs/ntfs3: fix deadlock in mark_as_free_ex

Zeng Heng <[email protected]>
fs/ntfs3: fix panic about slab-out-of-bounds caused by ntfs_list_ea()

Ziqi Zhao <[email protected]>
fs/ntfs3: Fix possible null-pointer dereference in hdr_find_e()

Paolo Abeni <[email protected]>
tcp: check mptcp-level constraints for backlog coalescing

Joerg Roedel <[email protected]>
x86/sev: Check for user-space IOIO pointing to kernel space

Joerg Roedel <[email protected]>
x86/sev: Check IOBM for IOIO exceptions from user-space

Borislav Petkov (AMD) <[email protected]>
x86/sev: Disable MMIO emulation from user mode

Jim Mattson <[email protected]>
KVM: x86: Mask LVTPC when handling a PMI

Johan Hovold <[email protected]>
regmap: fix NULL deref on lookup

Krzysztof Kozlowski <[email protected]>
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()

Jesse Brandeburg <[email protected]>
ice: reset first in crash dump kernels

Jesse Brandeburg <[email protected]>
ice: fix over-shifted variable

Arnd Bergmann <[email protected]>
Bluetooth: avoid memcmp() out of bounds warning

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_event: Fix coding style

Arkadiusz Bokowy <[email protected]>
Bluetooth: vhci: Fix race when opening vhci device

Ziyang Xuan <[email protected]>
Bluetooth: Fix a refcnt underflow problem for hci_conn

Lee, Chun-Yi <[email protected]>
Bluetooth: Reject connection with the device which has same BD_ADDR

Lee, Chun-Yi <[email protected]>
Bluetooth: hci_event: Ignore NULL link key

Darrick J. Wong <[email protected]>
xfs: don't expose internal symlink metadata buffers to the vfs

Bagas Sanjaya <[email protected]>
Documentation: sysctl: align cells in second content column

Hyeonggon Yoo <[email protected]>
lib/Kconfig.debug: do not enable DEBUG_PREEMPT by default

-------------

Diffstat:

 Documentation/admin-guide/sysctl/net.rst           |  18 +-
 Makefile                                           |   4 +-
 arch/arm/boot/dts/motorola-mapphone-common.dtsi    |   1 +
 arch/powerpc/include/asm/book3s/32/kup.h           |  37 +--
 arch/powerpc/include/asm/book3s/32/mmu-hash.h      |  77 +++++-
 arch/powerpc/include/asm/interrupt.h               |   6 +-
 arch/powerpc/include/asm/kup.h                     |   5 -
 arch/powerpc/kernel/entry_32.S                     |  39 ++-
 arch/powerpc/kernel/head_32.h                      |   6 +
 arch/powerpc/kernel/head_book3s_32.S               |   4 +
 arch/powerpc/kernel/interrupt.c                    |   3 -
 arch/powerpc/mm/book3s32/kuep.c                    |  10 +-
 arch/s390/pci/pci_dma.c                            |  15 +-
 arch/x86/boot/compressed/sev.c                     |  10 +
 arch/x86/events/Makefile                           |   2 +-
 arch/x86/events/intel/lbr.c                        | 273 ---------------------
 arch/x86/events/perf_event.h                       |  62 +++++
 arch/x86/events/utils.c                            | 217 ++++++++++++++++
 arch/x86/kernel/sev-shared.c                       |  53 +++-
 arch/x86/kernel/sev.c                              |  30 +++
 arch/x86/kvm/lapic.c                               |   8 +-
 drivers/acpi/irq.c                                 |   7 +-
 drivers/ata/libata-core.c                          |   2 +-
 drivers/ata/libata-eh.c                            |   2 +-
 drivers/base/regmap/regmap.c                       |   2 +-
 drivers/bluetooth/btusb.c                          |   1 +
 drivers/bluetooth/hci_vhci.c                       |   3 +
 drivers/gpio/gpio-timberdale.c                     |   5 +-
 drivers/gpio/gpio-vf610.c                          |   4 +-
 drivers/gpu/drm/drm_atomic_helper.c                |  17 +-
 drivers/gpu/drm/drm_panel_orientation_quirks.c     |  16 ++
 drivers/gpu/drm/i915/gem/i915_gem_mman.c           |   1 +
 drivers/hid/hid-holtek-kbd.c                       |   4 +
 drivers/hid/hid-multitouch.c                       |   4 +
 drivers/i2c/i2c-mux.c                              |   2 +-
 drivers/iio/accel/bmc150-accel-core.c              |   4 +-
 drivers/iio/adc/ad7192.c                           |  29 ++-
 drivers/iio/adc/at91-sama5d2_adc.c                 |   4 +-
 .../common/cros_ec_sensors/cros_ec_sensors_core.c  |   6 +-
 drivers/iio/industrialio-core.c                    |  61 +++++
 drivers/mmc/core/mmc.c                             |   2 +-
 drivers/mmc/core/sdio.c                            |   8 +-
 drivers/mmc/host/mtk-sd.c                          |   6 +-
 drivers/mtd/maps/physmap-core.c                    |  11 +
 drivers/mtd/nand/raw/arasan-nand-controller.c      |  16 +-
 drivers/mtd/nand/raw/marvell_nand.c                |  23 +-
 drivers/mtd/nand/raw/pl35x-nand-controller.c       |   9 +
 drivers/mtd/nand/raw/qcom_nandc.c                  |   2 +-
 drivers/mtd/nand/spi/micron.c                      |   2 +-
 drivers/net/bonding/bond_main.c                    |   2 +-
 drivers/net/dsa/bcm_sf2.c                          |  24 +-
 drivers/net/ethernet/intel/i40e/i40e_common.c      |   4 +-
 drivers/net/ethernet/intel/ice/ice_lib.c           |   3 +-
 drivers/net/ethernet/intel/ice/ice_main.c          |  15 ++
 drivers/net/ethernet/marvell/sky2.h                |   2 +-
 .../ethernet/mellanox/mlx5/core/diag/fw_tracer.c   |   2 +-
 drivers/net/ethernet/netronome/nfp/flower/cmsg.c   |  10 +-
 .../net/ethernet/netronome/nfp/flower/conntrack.c  |  19 +-
 drivers/net/ethernet/netronome/nfp/flower/main.h   |   2 +
 .../net/ethernet/netronome/nfp/flower/metadata.c   |   2 +
 .../net/ethernet/netronome/nfp/flower/offload.c    |  24 +-
 .../net/ethernet/netronome/nfp/flower/qos_conf.c   |  20 +-
 drivers/net/ethernet/qlogic/qed/qed_ll2.c          |   7 +-
 drivers/net/tun.c                                  |   7 +-
 drivers/net/usb/smsc95xx.c                         |   2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c        |   3 +
 .../net/wireless/marvell/mwifiex/11n_rxreorder.c   |  16 ++
 drivers/nvme/host/pci.c                            |   3 +-
 drivers/nvme/host/rdma.c                           |   3 +
 drivers/nvme/target/tcp.c                          |   7 +-
 drivers/phy/motorola/phy-mapphone-mdm6600.c        |  38 ++-
 drivers/pinctrl/core.c                             |  16 +-
 .../platform/surface/surface_platform_profile.c    |   3 +-
 drivers/platform/x86/asus-nb-wmi.c                 |   3 +
 drivers/platform/x86/asus-wmi.h                    |   2 +-
 drivers/platform/x86/touchscreen_dmi.c             |  23 ++
 drivers/regulator/core.c                           |   6 +-
 drivers/s390/cio/css.c                             |   6 +-
 drivers/tty/serial/8250/8250_omap.c                |  93 +++----
 drivers/usb/serial/option.c                        |   7 +
 fs/btrfs/ctree.c                                   |  52 +++-
 fs/btrfs/extent-tree.c                             |   6 +-
 fs/btrfs/ioctl.c                                   |   4 +-
 fs/btrfs/tree-log.c                                |   2 +-
 fs/fs-writeback.c                                  |  11 +-
 fs/ksmbd/vfs_cache.c                               |   4 +-
 fs/nfs/nfs4proc.c                                  |   2 -
 fs/nfs/pnfs.c                                      |  33 ++-
 fs/ntfs3/fsntfs.c                                  |   6 +-
 fs/ntfs3/index.c                                   |   3 +
 fs/ntfs3/xattr.c                                   |   7 +-
 fs/overlayfs/copy_up.c                             |   2 +-
 fs/xfs/xfs_iops.c                                  |  34 +--
 fs/xfs/xfs_symlink.c                               |  29 ++-
 include/linux/iio/iio.h                            |  14 +-
 include/linux/netdevice.h                          |   1 +
 include/linux/perf_event.h                         |   1 +
 include/net/bluetooth/hci_core.h                   |   2 +-
 include/net/bluetooth/hci_mon.h                    |   2 +-
 include/net/ip_fib.h                               |   1 +
 include/net/netns/xfrm.h                           |   1 +
 include/net/tcp.h                                  |   3 +
 include/trace/events/neigh.h                       |   4 +-
 include/uapi/linux/perf_event.h                    |   2 +
 kernel/events/core.c                               |  39 ++-
 kernel/trace/trace_events.c                        |   1 +
 lib/Kconfig.debug                                  |   5 +-
 net/bluetooth/hci_conn.c                           |  72 +++---
 net/bluetooth/hci_core.c                           |   8 +-
 net/bluetooth/hci_event.c                          |  33 ++-
 net/bluetooth/hci_sock.c                           |   3 +-
 net/core/dev.c                                     |  58 +++--
 net/core/drop_monitor.c                            |   2 +-
 net/core/netpoll.c                                 |   4 +-
 net/core/pktgen.c                                  |  14 +-
 net/ipv4/esp4.c                                    |   4 +-
 net/ipv4/fib_semantics.c                           |  15 +-
 net/ipv4/fib_trie.c                                |   4 +
 net/ipv4/tcp_ipv4.c                                |   1 +
 net/ipv4/tcp_output.c                              |  25 +-
 net/ipv4/tcp_recovery.c                            |   2 +-
 net/ipv6/esp6.c                                    |   4 +-
 net/ipv6/xfrm6_policy.c                            |   4 +-
 net/mac80211/tx.c                                  |   3 +-
 net/mctp/route.c                                   |  33 +++
 net/netfilter/nft_payload.c                        |   2 +-
 net/netfilter/nft_set_rbtree.c                     |   2 +
 net/nfc/nci/spi.c                                  |   2 +
 net/rfkill/rfkill-gpio.c                           |   4 +-
 net/sched/sch_hfsc.c                               |  18 +-
 net/wireless/nl80211.c                             |   2 +-
 net/wireless/scan.c                                |   4 +
 net/xfrm/xfrm_interface_core.c                     |  22 +-
 net/xfrm/xfrm_policy.c                             |   6 +-
 sound/soc/codecs/wcd938x-sdw.c                     |  27 +-
 sound/soc/codecs/wcd938x.c                         |   6 +-
 sound/soc/pxa/pxa-ssp.c                            |   2 +-
 tools/include/uapi/linux/perf_event.h              |   2 +
 tools/perf/util/branch.c                           |   4 +-
 .../ftrace/test.d/kprobe/kprobe_non_uniq_symbol.tc |  13 +
 .../selftests/vm/charge_reserved_hugetlb.sh        |   4 +-
 .../selftests/vm/hugetlb_reparenting_test.sh       |   4 +-
 142 files changed, 1444 insertions(+), 747 deletions(-)