Skip to content

fanotify support for btrfs sub-volumes

Amir Goldstein linux-btrfs linux-fsdevel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v13 patches 77 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fanotify: store fsid in mark instead of in connectorfs/notify/fanotify/fanotify.c fs/notify/fanotify/fanotify.h fs/notify/fanotify/fanotify_user.c +2 more+42 -700 replies
2/3fanotify: report the most specific fsid for btrfsfs/notify/fanotify/fanotify.c include/linux/fsnotify_backend.h+5 -20 replies
3/3fanotify: support setting marks in btrfs sub-volumesfs/notify/fanotify/fanotify_user.c+0 -130 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchChristoph Hellwig
SeriesHard-NAKed-by Extra-hard-Nacked-by
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] fanotify support for btrfs sub-volumes

Jan,

As agreed on the review of v1 [1], we do not need any vfs changes to support fanotify on btrfs sub-volumes and we can enable setting marks on btrfs sub-volumes simply by caching the fsid in the mark object instead of the connector.

This is the would be man page update to clarify the meaning of fsid as it is reflected in this patch set:

fsid

This is a unique identifier of the filesystem containing the object associated with the event. It is a structure of type __kernel_fsid_t and contains the same value reported in f_fsid when calling statfs(2) with the same pathname argument that was used for fanotify_mark(2). Note that some filesystems (e.g., btrfs(5)) report non-uniform values of f_fsid on different objects of the same filesystem. In these cases, if fanotify_mark(2) is called several times with different pathname values, the fsid value reported in events will match f_fsid associated with at least one of those pathname values.

Thanks,
Amir.

[1] https://lore.kernel.org/r/CAOQ4uxg9wjESoCFNDADbneF0-nW4xVHHV3Rhhp=gJwAs=S83dQ@mail.gmail.com/

Amir Goldstein (3):
fanotify: store fsid in mark instead of in connector
fanotify: report the most specific fsid for btrfs
fanotify: support setting marks in btrfs sub-volumes

 fs/notify/fanotify/fanotify.c      | 21 ++++--------
 fs/notify/fanotify/fanotify.h      | 10 ++++++
 fs/notify/fanotify/fanotify_user.c | 31 ++++++++----------
 fs/notify/mark.c                   | 52 +++++-------------------------
 include/linux/fsnotify_backend.h   | 18 +++++------
 5 files changed, 47 insertions(+), 85 deletions(-)
Signature · 1 line
2.34.1