Refactor VM bind code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest30 patches 38 repliesIn review
- v322 patches 1 replySuperseded
- v227 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 26 patches | 3 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/30 | drm/xe: Lock all gpuva ops during VM bind IOCTLdrivers/ | +101 | 4 replies | |
| 2/30 | drm/xe: Add ops_execute function which returns a fencedrivers/ | +111 | 3 replies | |
| 3/30 | drm/xe: Move migrate to prefetch to op_lock functiondrivers/ | +13 | 3 replies | |
| 4/30 | drm/xe: Add struct xe_vma_ops abstractiondrivers/ drivers/ | +28 | 1 reply | |
| 5/30 | drm/xe: Update xe_vm_rebind to use dummy VMA operationsdrivers/ drivers/ | +132 | 2 replies | |
| 6/30 | drm/xe: Simplify VM bind IOCTL error handling and cleanupdrivers/ drivers/ | +9 | 2 replies | |
| 7/30 | drm/xe: Update pagefaults to use dummy VMA operationsdrivers/ drivers/ drivers/ +1 more | +47 | 0 replies | |
| 8/30 | drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queuedrivers/ drivers/ drivers/ | +7 | 1 reply | |
| 9/30 | drm/xe: Add some members to xe_vma_opsdrivers/ drivers/ | +18 | 2 replies | |
| 10/30 | drm/xe: Add vm_bind_ioctl_ops_install_fences helperdrivers/ | +23 | 3 replies | |
| 11/30 | drm/xe: Move setting last fence to vm_bind_ioctl_ops_install_fencesdrivers/ | +2 | 2 replies | |
| 12/30 | drm/xe: Move ufence check to op_lockdrivers/ | +23 | 2 replies | |
| 13/30 | drm/xe: Move ufence add to vm_bind_ioctl_ops_install_fencesdrivers/ drivers/ drivers/ | +53 | 3 replies | |
| 14/30 | drm/xe: Add xe_gt_tlb_invalidation_range and convert PT layer to use thisdrivers/ drivers/ drivers/ | +65 | 2 replies | |
| 15/30 | drm/xe: Add xe_vm_pgtable_update_op to xe_vma_opsdrivers/ drivers/ drivers/ | +81 | 3 replies | |
| 16/30 | drm/xe: Use ordered WQ for TLB invalidation fencesdrivers/ | +1 | 2 replies | |
| 17/30 | drm/xe: Delete PT update selftestdrivers/ | +0 | 1 reply | |
| 18/30 | drm/xe: Convert multiple bind ops into single jobdrivers/ drivers/ drivers/ +8 more | +969 | 2 replies | |
| 19/30 | drm/xe: Remove old functions defs in xe_pt.hdrivers/ | +0 | 0 replies | |
| 20/30 | drm/xe: Update PT layer with better error handlingdrivers/ drivers/ | +165 | 0 replies | |
| 21/30 | drm/xe: Update xe_vm_rebind to return intdrivers/ drivers/ drivers/ | +10 | 0 replies | |
| 22/30 | drm/xe: Move vma rebinding to the drm_exec locking loopdrivers/ drivers/ | +11 | 0 replies | |
| 23/30 | drm/xe: Update VM trace eventsdrivers/ drivers/ | +45 | 0 replies | |
| 24/30 | drm/xe: Update clear / populate argumentsdrivers/ drivers/ drivers/ | +15 | 0 replies | |
| 25/30 | drm/xe: Add __xe_migrate_update_pgtables_cpu helperdrivers/ | +31 | 0 replies | |
| 26/30 | drm/xe: CPU binds for jobsdrivers/ drivers/ drivers/ +14 more | +254 | 0 replies | |
| 27/30 | drm/xe: Don't use migrate exec queue for page fault bindsdrivers/ drivers/ drivers/ | +23 | 0 replies | |
| 28/30 | drm/xe: Add VM bind IOCTL error injectiondrivers/ drivers/ drivers/ +1 more | +58 | 0 replies | |
| 29/30 | drm/xe/guc: Assert time'd out jobs are not from a VM exec queuedrivers/ | +3 | 0 replies | |
| 30/30 | drm/xe: Add PT exec queuesdrivers/ drivers/ drivers/ +9 more | +288 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 00/30] Refactor VM bind code
Broken into roughly 5 parts:
Part 1: Prep patches, patches 1-14
Part 2: 1 jobs per VM bind IOCTL and error handling, patches 15-23 Part 3: CPU binds, patches 24-27
Part 4: Error injection for testing, patch 28
Part 5: PT exec queues 29-30
For reviewing, let's focus on part 1 for now and see if patches from that part can start to get merged.
Tested with [1] and new error handling appears to be working. Also tested with existing tests at every patch in the series and should be working at every patch in the series.
Latest version includes some of Thomas's patches too [2].
Matt
[1] https://patchwork.freedesktop.org/series/129606/
[2] https://patchwork.freedesktop.org/series/130871/
Matthew Brost (28):
drm/xe: Lock all gpuva ops during VM bind IOCTL
drm/xe: Add ops_execute function which returns a fence drm/xe: Move migrate to prefetch to op_lock function drm/xe: Add struct xe_vma_ops abstraction
drm/xe: Update xe_vm_rebind to use dummy VMA operations drm/xe: Simplify VM bind IOCTL error handling and cleanup drm/xe: Update pagefaults to use dummy VMA operations drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue drm/xe: Add some members to xe_vma_ops
drm/xe: Add vm_bind_ioctl_ops_install_fences helper drm/xe: Move setting last fence to vm_bind_ioctl_ops_install_fences drm/xe: Move ufence check to op_lock
drm/xe: Move ufence add to vm_bind_ioctl_ops_install_fences drm/xe: Add xe_gt_tlb_invalidation_range and convert PT layer to use
this
drm/xe: Add xe_vm_pgtable_update_op to xe_vma_ops
drm/xe: Use ordered WQ for TLB invalidation fences drm/xe: Delete PT update selftest
drm/xe: Convert multiple bind ops into single job
drm/xe: Remove old functions defs in xe_pt.h
drm/xe: Update PT layer with better error handling drm/xe: Update VM trace events
drm/xe: Update clear / populate arguments
drm/xe: Add __xe_migrate_update_pgtables_cpu helper drm/xe: CPU binds for jobs
drm/xe: Don't use migrate exec queue for page fault binds drm/xe: Add VM bind IOCTL error injection
drm/xe/guc: Assert time'd out jobs are not from a VM exec queue drm/xe: Add PT exec queues
Thomas Hellström (2):
drm/xe: Update xe_vm_rebind to return int drm/xe: Move vma rebinding to the drm_exec locking loop
drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/tests/xe_migrate.c | 86 -- drivers/gpu/drm/xe/xe_bo.c | 7 +- drivers/gpu/drm/xe/xe_bo.h | 4 +- drivers/gpu/drm/xe/xe_device.c | 35 + drivers/gpu/drm/xe/xe_device.h | 2 + drivers/gpu/drm/xe/xe_device_types.h | 16 + drivers/gpu/drm/xe/xe_exec.c | 41 +- drivers/gpu/drm/xe/xe_exec_queue.c | 120 +- drivers/gpu/drm/xe/xe_exec_queue_types.h | 20 +- drivers/gpu/drm/xe/xe_gt_pagefault.c | 10 +- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 59 +- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h | 3 + drivers/gpu/drm/xe/xe_guc_submit.c | 22 +- drivers/gpu/drm/xe/xe_migrate.c | 385 ++---- drivers/gpu/drm/xe/xe_migrate.h | 46 +- drivers/gpu/drm/xe/xe_pt.c | 1236 ++++++++++++------- drivers/gpu/drm/xe/xe_pt.h | 15 +- drivers/gpu/drm/xe/xe_pt_exec_queue.c | 180 +++ drivers/gpu/drm/xe/xe_pt_exec_queue.h | 14 + drivers/gpu/drm/xe/xe_pt_types.h | 53 + drivers/gpu/drm/xe/xe_sched_job.c | 68 +- drivers/gpu/drm/xe/xe_sched_job_types.h | 31 +- drivers/gpu/drm/xe/xe_sync.c | 15 + drivers/gpu/drm/xe/xe_sync.h | 1 + drivers/gpu/drm/xe/xe_trace.h | 21 +- drivers/gpu/drm/xe/xe_vm.c | 1124 ++++++++--------- drivers/gpu/drm/xe/xe_vm.h | 9 +- drivers/gpu/drm/xe/xe_vm_types.h | 198 +-- 29 files changed, 2118 insertions(+), 1704 deletions(-) create mode 100644 drivers/gpu/drm/xe/xe_pt_exec_queue.c create mode 100644 drivers/gpu/drm/xe/xe_pt_exec_queue.h
Signature · 1 line
2.34.1