Skip to content

System Suspend fixes and improvements for CS35L41 HDA

Stefan Binding alsa-devel linux-sound lkml 1 version Applied

Status from this message: Applied to for-next branch now. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8ALSA: hda: cs35l41: Use reset label to get GPIO for HP Zbook Fury 17 G9sound/pci/hda/cs35l41_hda_property.c+9 -20 replies
2/8ALSA: hda: cs35l41: Assert reset before system suspendsound/pci/hda/cs35l41_hda.c+8 -50 replies
3/8ALSA: hda: cs35l41: Assert Reset prior to de-asserting in probe and system resumesound/pci/hda/cs35l41_hda.c+2 -00 replies
4/8ALSA: hda: cs35l41: Run boot process during resume callbackssound/pci/hda/cs35l41_hda.c+72 -330 replies
5/8ALSA: hda: cs35l41: Force a software reset after hardware resetinclude/sound/cs35l41.h sound/pci/hda/cs35l41_hda.c sound/soc/codecs/cs35l41-lib.c+7 -00 replies
6/8ALSA: hda: cs35l41: Do not unload firmware before reset in system suspendsound/pci/hda/cs35l41_hda.c+4 -290 replies
7/8ALSA: hda: cs35l41: Check CSPL state after loading firmwaresound/pci/hda/cs35l41_hda.c+18 -00 replies
8/8ASoC: cs35l41: Detect CSPL errors when sending CSPL commandsinclude/sound/cs35l41.h sound/soc/codecs/cs35l41-lib.c+7 -01 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMark Brown
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/8] System Suspend fixes and improvements for CS35L41 HDA

There is a report of a single laptop which uses CS35L41 HDA having an issue with System Suspend. This particular laptop uses S3 (Deep) Sleep. The reported issue states that when the laptop resumes from a system suspend, audio no longer works.

The root cause of this issue is due to the CS35L41 being returned to us in an unexpected state after a suspend/resume cycle.
When the driver resumes, it expects the parts to have been reset, which leads to issues with audio and firmware loading.

To prevent this issue, and the possibility of similar issues, patches 2-5 force the driver to reset during probe, system suspend, and system resume, which ensures that the part is always in the correct state. Patches 6-8 are improvements in the suspend and firmware loading code, which makes it easier to detect issues in the future, as well as simplifiying the suspend code.

Patch 1 is a fix for an incorrect configuration for the HP Zbook Fury 17, which is the laptop which had the original issue.

Stefan Binding (8):
ALSA: hda: cs35l41: Use reset label to get GPIO for HP Zbook Fury 17

    G9

ALSA: hda: cs35l41: Assert reset before system suspend
ALSA: hda: cs35l41: Assert Reset prior to de-asserting in probe and
system resume
ALSA: hda: cs35l41: Run boot process during resume callbacks
ALSA: hda: cs35l41: Force a software reset after hardware reset
ALSA: hda: cs35l41: Do not unload firmware before reset in system
suspend
ALSA: hda: cs35l41: Check CSPL state after loading firmware
ASoC: cs35l41: Detect CSPL errors when sending CSPL commands

 include/sound/cs35l41.h              |   3 +
 sound/pci/hda/cs35l41_hda.c          | 170 +++++++++++++++++----------
 sound/pci/hda/cs35l41_hda_property.c |  11 +-
 sound/soc/codecs/cs35l41-lib.c       |   6 +
 4 files changed, 124 insertions(+), 66 deletions(-)
Signature · 1 line
2.34.1