Skip to content

ovl: new mount options lowerdir+,datadir+

Amir Goldstein linux-unionfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ovl: remove unused code in lowerdir param parsingfs/overlayfs/params.c+16 -790 replies
2/4ovl: store and show the user provided lowerdir mount optionfs/overlayfs/params.c fs/overlayfs/params.h fs/overlayfs/super.c+28 -240 replies
3/4ovl: refactor layer parsing helpersfs/overlayfs/params.c+62 -542 replies
4/4ovl: add support for appending lowerdirs one by onefs/overlayfs/params.c+76 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] ovl: new mount options lowerdir+,datadir+

Miklos,

As discussed, here are the patches for the new mount options.

- Only string format is supported
- Legacy lowerdir= cannot be mixed with new lowerdir+,datadir+
- lowerdir+,datadir+ are not escaped
- lowerdir,upperdir,workdir are escaped as always

I did not find a good reason to change escaping of upperdir,workdir. We can skip escaping when we add support for path format.

Wrote some xfstests [1].

Thanks,
Amir.

[1] https://github.com/amir73il/xfstests/commits/ovl-lowerdir-add

Amir Goldstein (4):
ovl: remove unused code in lowerdir param parsing
ovl: store and show the user provided lowerdir mount option
ovl: refactor layer parsing helpers
ovl: add support for appending lowerdirs one by one

 fs/overlayfs/params.c | 317 ++++++++++++++++++++++--------------------
 fs/overlayfs/params.h |   1 +
 fs/overlayfs/super.c  |   5 +-
 3 files changed, 173 insertions(+), 150 deletions(-)
Signature · 1 line
2.34.1