Skip to content

Packet/beacon loss roaming improvements

James Prestwood iwd 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4station: rename ap_directed_roam to force_roamsrc/station.c+8 -80 replies
2/4station: start roam on beacon loss eventsrc/netdev.h src/station.c+18 -00 replies
3/4netdev: handle/send beacon loss eventsrc/netdev.c+5 -10 replies
4/4station: rate limit packet loss roam scanssrc/station.c+27 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Packet/beacon loss roaming improvements

The rate limiting patch shouldn't be too controversial, but the forced roam on beacon loss may be so I wanted to provde some background. This behavior was only tested on ath10k, so I understand if we don't want to impose the same behavior for all drivers.

We were seeing beacon loss events not resulting in an immediate disconnnect (as I have always expected), still eventually but after plenty of time to roam. I initially added handling for beacon loss identical to packet loss (try and find a better BSS) but noticed that if IWD did not find a better candidate it resulted in a disconnect 100% of the time. I watched a client for a full day and whenever beacon loss events arrived they were followed by a disconnect within ~5-6 seconds if IWD did not roam. This led me to believe that at least on ath10k a beacon loss is still very much a sign that a disconnect is going to come, we just have a bit more time than other drivers. This was the motivation behind re-using/re-naming the 'ap_directed_roam' flag in order to force IWD off the BSS.

Again, this is just one driver. Maybe other drivers can handle/recover from beacon loss. If we instead want to keep the behavior the same as packet loss I'm ok with that (I can keep the patch locally), or put the forced roam behavior behind a user option e.g. [Roam].ForceRoamOnBeaconLoss

James Prestwood (4):
station: rename ap_directed_roam to force_roam
station: start roam on beacon loss event
netdev: handle/send beacon loss event
station: rate limit packet loss roam scans

 src/netdev.c  |  6 ++++-
 src/netdev.h  |  1 +
 src/station.c | 61 +++++++++++++++++++++++++++++++++++++++++++--------
 3 files changed, 58 insertions(+), 10 deletions(-)
Signature · 1 line
2.25.1