Skip to content

eventfs: Fixing dynamic creation

Steven Rostedt linux-trace-kernel lkml stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 3 repliesIn review
  2. v57 patches 4 repliesSuperseded
  3. v43 patches 0 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8eventfs: Remove "is_freed" union with rcu headfs/tracefs/event_inode.c fs/tracefs/internal.h+5 -30 replies
2/8eventfs: Have a free_ei() that just frees the eventfs_inodefs/tracefs/event_inode.c+11 -80 replies
3/8eventfs: Test for ei->is_freed when accessing ei->dentryfs/tracefs/event_inode.c fs/tracefs/internal.h+41 -70 replies
4/8eventfs: Save ownership and modefs/tracefs/event_inode.c fs/tracefs/internal.h+151 -130 replies
5/8eventfs: Hold eventfs_mutex when calling callback functionsfs/tracefs/event_inode.c include/linux/tracefs.h+63 -21 reply
6/8eventfs: Delete eventfs_inode when the last dentry is freedfs/tracefs/event_inode.c fs/tracefs/internal.h+69 -790 replies
7/8eventfs: Remove special processing of dput() of events directoryfs/tracefs/event_inode.c+2 -171 reply
8/8eventfs: Use simple_recursive_removal() to clean up dentriesfs/tracefs/event_inode.c fs/tracefs/internal.h+44 -351 reply

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu (Google)Linux Kernel Functional TestingNaresh KambojuBeau Belgrave
1/8R-b
2/8R-b
3/8R-b T-b T-b T-b
4/8
5/8R-b T-b T-b
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/8] eventfs: Fixing dynamic creation

Changes since v5: https://lore.kernel.org/all/[email protected]/

This was originally based on:

[PATCH] eventfs: Process deletion of dentry more thoroughly
https://lore.kernel.org/linux-trace-kernel/[email protected]/

But Al Viro asked why I do not use use simple_recursive_removal()? Which at first I thought I could not, but after playing with it more I realized I could (with a little addition of dget()'s to balance the dput()s). This simplifies the code. But to do this, it really needs to be done *after* these changes. Hence, I moved that patch to after this series and to handle this rebase, I'm reposting all the patches and including the above mentioned patch at the end and renamed to:

eventfs: Use simple_recursive_removal() to clean up dentries

I hope this is the last series, as this *is* for this merge window!

Steven Rostedt (Google) (8):
eventfs: Remove "is_freed" union with rcu head
eventfs: Have a free_ei() that just frees the eventfs_inode
eventfs: Test for ei->is_freed when accessing ei->dentry
eventfs: Save ownership and mode
eventfs: Hold eventfs_mutex when calling callback functions
eventfs: Delete eventfs_inode when the last dentry is freed
eventfs: Remove special processing of dput() of events directory
eventfs: Use simple_recursive_removal() to clean up dentries

----

 fs/tracefs/event_inode.c | 420 ++++++++++++++++++++++++++++++++---------------
 fs/tracefs/internal.h    |  29 +++-
 include/linux/tracefs.h  |  43 +++++
 3 files changed, 357 insertions(+), 135 deletions(-)