Skip to content

PM: domains: Add control for switching back and forth to HW control

Abel Vesa linux-arm-msm linux-clk linux-media linux-pm lkml 7 versions – In review

Get series with b4
b4 am [email protected] change-id 20231101-gdsc-hwctrl-13f01ea60cbd

Versions newest first

  1. v4 Latest5 patches 19 repliesIn review
  2. v3 posting 4/45 patches 18 repliesSuperseded inferred link
  3. v3 posting 3/45 patches 0 repliesSuperseded inferred link
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/40 of 5 patches3 repliesSuperseded inferred link
v3 posting 1/45 patches2 repliesSuperseded inferred link
v26 patches19 repliesSuperseded inferred link
v12 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Re-worded 1st patch commit message, as per Bjorn's suggestion, and added Dmitry's R-b tag
- Added Bjorn's and Dmitry's R-b tags to the 2nd patch
- Re-worded 3rd patch commit message, to better explain the HW_CTRL_TRIGGER flag.
- Added mode transition delay when setting mode for GDSC
- Added status polling if GDSSC is enabled when transitioning from HW to SW
- Re-worded 4th patch commit message to better explain why the HW_CTRL_TRIGGER needs to be used instead
- Drop changes to SC7180, SDM845 and SM8550 video CC drivers, as only SC7280 and SM8250 have been tested so far. More platforms (with v6 venus) will be added eventually.
- Call genpd set_hwmode API only for v6 and dropped the vcodec_pmdomains_hwctrl.
- Re-worded 5th patch commit message accordingly.
- Link to v3:
https://lore.kernel.org/r/[email protected]/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PM: domains: Allow devices attached to genpd to be managed by HWdrivers/pmdomain/core.c include/linux/pm_domain.h+86 -012 replies
2/5PM: domains: Add the domain HW-managed mode to the summarydrivers/pmdomain/core.c+12 -20 replies
3/5clk: qcom: gdsc: Add set and get hwmode callbacks to switch GDSC modedrivers/clk/qcom/gdsc.c drivers/clk/qcom/gdsc.h+55 -04 replies
4/5clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW modedrivers/clk/qcom/videocc-sc7280.c drivers/clk/qcom/videocc-sm8250.c+3 -30 replies
5/5venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC modedrivers/media/platform/qcom/venus/pm_helpers.c+13 -102 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchDmitry BaryshkovUlf HanssonBjorn Andersson
1/5R-b
2/5R-b R-b R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] PM: domains: Add control for switching back and forth to HW control

---
Changes in v4:
- Re-worded 1st patch commit message, as per Bjorn's suggestion, and added Dmitry's R-b tag
- Added Bjorn's and Dmitry's R-b tags to the 2nd patch
- Re-worded 3rd patch commit message, to better explain the HW_CTRL_TRIGGER flag.
- Added mode transition delay when setting mode for GDSC
- Added status polling if GDSSC is enabled when transitioning from HW to SW
- Re-worded 4th patch commit message to better explain why the HW_CTRL_TRIGGER needs to be used instead
- Drop changes to SC7180, SDM845 and SM8550 video CC drivers, as only SC7280 and SM8250 have been tested so far. More platforms (with v6 venus) will be added eventually.
- Call genpd set_hwmode API only for v6 and dropped the vcodec_pmdomains_hwctrl.
- Re-worded 5th patch commit message accordingly.
- Link to v3:
https://lore.kernel.org/r/[email protected]/

---
Abel Vesa (1):
PM: domains: Add the domain HW-managed mode to the summary

Jagadeesh Kona (3):
clk: qcom: gdsc: Add set and get hwmode callbacks to switch GDSC mode
clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode
venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode

Ulf Hansson (1):
PM: domains: Allow devices attached to genpd to be managed by HW

 drivers/clk/qcom/gdsc.c                        | 54 +++++++++++++++++
 drivers/clk/qcom/gdsc.h                        |  1 +
 drivers/clk/qcom/videocc-sc7280.c              |  2 +-
 drivers/clk/qcom/videocc-sm8250.c              |  4 +-
 drivers/media/platform/qcom/venus/pm_helpers.c | 23 +++----
 drivers/pmdomain/core.c                        | 83 +++++++++++++++++++++++++-
 include/linux/pm_domain.h                      | 17 ++++++
 7 files changed, 169 insertions(+), 15 deletions(-)

---
base-commit: 319fbd8fc6d339e0a1c7b067eed870c518a13a02
change-id: 20231101-gdsc-hwctrl-13f01ea60cbd

Best regards,

Signature · 1 line
Abel Vesa <[email protected]>