Skip to content

mmc: block: Fixes for CQE error recovery recovery

Adrian Hunter linux-mmc lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 14 repliesIn review
  2. v15 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mmc: block: Do not lose cache flush during CQE error recoverydrivers/mmc/core/block.c+2 -01 reply
2/6mmc: cqhci: Increase recovery halt timeoutdrivers/mmc/host/cqhci-core.c+3 -32 replies
3/6mmc: block: Be sure to wait while busy in CQE error recoverydrivers/mmc/core/core.c+2 -04 replies
4/6mmc: block: Retry commands in CQE error recoverydrivers/mmc/core/core.c+5 -21 reply
5/6mmc: cqhci: Warn of halt or task clear failuredrivers/mmc/host/cqhci-core.c+3 -32 replies
6/6mmc: cqhci: Fix task clearing in CQE error recoverydrivers/mmc/host/cqhci-core.c+16 -161 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchKornel DulębaAvri AltmanChristian Loehle
1/6R-b
2/6R-b
3/6R-b R-b
4/6R-b
5/6R-b R-b
6/6T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH V2 0/6] mmc: block: Fixes for CQE error recovery recovery

Hi

Some issues have been found with CQE error recovery. Here are some fixes.

As of V2, the alternative implementation for the patch from Kornel Dulęba:

	https://lore.kernel.org/linux-mmc/[email protected]/T/#u

is now included, see patch 6 "mmc: cqhci: Fix task clearing in CQE error recovery")

Please also note ->post_disable() seems to be missing from cqhci_recovery_start(). It would be good if ->post_disable() users could check if this needs attention.

Changes in V2:

mmc: cqhci: Fix task clearing in CQE error recovery
New patch

mmc: cqhci: Warn of halt or task clear failure
Add fixes and stable tags

Adrian Hunter (6):
mmc: block: Do not lose cache flush during CQE error recovery
mmc: cqhci: Increase recovery halt timeout
mmc: block: Be sure to wait while busy in CQE error recovery
mmc: block: Retry commands in CQE error recovery
mmc: cqhci: Warn of halt or task clear failure
mmc: cqhci: Fix task clearing in CQE error recovery

 drivers/mmc/core/block.c      |  2 ++
 drivers/mmc/core/core.c       |  9 +++++++--
 drivers/mmc/host/cqhci-core.c | 44 +++++++++++++++++++++----------------------
 3 files changed, 31 insertions(+), 24 deletions(-)

Regards
Adrian