Skip to content

modpost: fix modpost errors for m68k-uclinux-gcc

Masahiro Yamada linux-kbuild lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7modpost: move sym_name() to modpost.hscripts/mod/modpost.c scripts/mod/modpost.h+9 -80 replies
2/7modpost: add const qualifier to syminfo tablescripts/mod/symsearch.c+1 -10 replies
3/7modpost: add table_size local variable to symsearch_find_nearest()scripts/mod/symsearch.c+4 -40 replies
4/7modpost: introduce a filtering feature to symsearchscripts/mod/symsearch.c+77 -250 replies
5/7modpost: prefer global symbols in symsearch_find_nearest()scripts/mod/symsearch.c+24 -330 replies
6/7modpost: add symsearch_find_with_name() helper functionscripts/mod/modpost.h scripts/mod/symsearch.c+47 -00 replies
7/7modpost: look up the correct symbol in check_export_symbol()scripts/mod/modpost.c+22 -90 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchGreg Ungerer
SeriesT-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] modpost: fix modpost errors for m68k-uclinux-gcc

Greg Ungerer reports building with m68k-uclinux-gcc toolchain is broken:
https://lore.kernel.org/linux-kbuild/CAK7LNASQ_W5Yva5a4Xx8E2EYi-tN7x3OHgMFhK+93W+BiX1=9Q@mail.gmail.com/T/#m6ff0364f9ca8483c9f6d162619e5005833d1e887

Usually, we do not need to search for export symbols in the .symtab section, but m68k-uclinux-gcc seems to be an exceptional case. I do not know what makes it different from other toolchains. Also, I do not know there exist other toolchains that work like that.

This series extends the symsearch feature in case we need to explicitly search for export symbols.

Then, the last patch fixes the issue.

This series should be applicable for linux-next.

This series is too late for the current merge window, but I'd like to fix the issue somehow by the next merge window.

Masahiro Yamada (7):
modpost: move sym_name() to modpost.h
modpost: add const qualifier to syminfo table
modpost: add table_size local variable to symsearch_find_nearest()
modpost: introduce a filtering feature to symsearch
modpost: prefer global symbols in symsearch_find_nearest()
modpost: add symsearch_find_with_name() helper function
modpost: look up the correct symbol in check_export_symbol()

 scripts/mod/modpost.c   |  39 ++++----
 scripts/mod/modpost.h   |  12 +++
 scripts/mod/symsearch.c | 205 ++++++++++++++++++++++++++++------------
 3 files changed, 180 insertions(+), 76 deletions(-)
Signature · 1 line
2.40.1