binder: convert alloc->mutex to spinlock
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest28 patches 30 repliesIn review
- v121 patches 35 repliesSuperseded
Changes in v2 from the cover letter
- New fix for wasted alloc->free_sync_space calculation
- Fix issues pointed out by Alice: incorrect size overflow check, data race in buffer->async_transaction, reorder of __free_page(page) and new_buffer leak in some error paths.
- Better naming and comments to accommodate the new scope of things e.g. binder_lru_freelist_add() and binder_install_single_page().
- Dropped patch ("binder: do not add pages to LRU in release path") since it is not worth the added complexity.
- Avoid _new_ logs of unhashed userspace addresses.
- More minor cosmeting changes.
- Add Reviewed-by tags.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/28 | binder: use EPOLLERR from eventpoll.hdrivers/ | +1 | 0 replies | |
| 2/28 | binder: fix use-after-free in shinker's callbackdrivers/ | +5 | 0 replies | |
| 3/28 | binder: fix race between mmput() and do_exit()drivers/ | +2 | 6 replies | |
| 4/28 | binder: fix async space check for 0-sized buffersdrivers/ | +4 | 4 replies | |
| 5/28 | binder: fix unused alloc->free_async_spacedrivers/ | +4 | 8 replies | |
| 6/28 | binder: fix trivial typo of binder_free_buf_locked()drivers/ | +1 | 0 replies | |
| 7/28 | binder: fix comment on binder_alloc_new_buf() return valuedrivers/ | +1 | 0 replies | |
| 8/28 | binder: remove extern from function prototypesdrivers/ | +19 | 0 replies | |
| 9/28 | binder: keep vma addresses type as unsigned longdrivers/ drivers/ drivers/ +2 more | +57 | 1 reply | |
| 10/28 | binder: split up binder_update_page_range()drivers/ | +40 | 0 replies | |
| 11/28 | binder: do unlocked work in binder_alloc_new_buf()drivers/ | +56 | 3 replies | |
| 12/28 | binder: remove pid param in binder_alloc_new_buf()drivers/ drivers/ drivers/ +1 more | +12 | 0 replies | |
| 13/28 | binder: separate the no-space debugging logicdrivers/ | +40 | 0 replies | |
| 14/28 | binder: relocate low space calculationdrivers/ | +11 | 0 replies | |
| 15/28 | binder: relocate binder_alloc_clear_buf()drivers/ | +61 | 0 replies | |
| 16/28 | binder: refactor page range allocationdrivers/ | +47 | 0 replies | |
| 17/28 | binder: malloc new_buffer outside of locksdrivers/ | +23 | 1 reply | |
| 18/28 | binder: initialize lru pages in mmap callbackdrivers/ | +7 | 0 replies | |
| 19/28 | binder: perform page installation outside of locksdrivers/ | +73 | 1 reply | |
| 20/28 | binder: remove redundant debug logdrivers/ | +0 | 1 reply | |
| 21/28 | binder: make oversized buffer code more readabledrivers/ | +10 | 1 reply | |
| 22/28 | binder: rename lru shrinker utilitiesdrivers/ drivers/ drivers/ | +25 | 1 reply | |
| 23/28 | binder: document the final page calculationdrivers/ | +11 | 4 replies | |
| 24/28 | binder: collapse print_binder_buffer() into callerdrivers/ | +9 | 1 reply | |
| 25/28 | binder: refactor binder_delete_free_buffer()drivers/ | +11 | 1 reply | |
| 26/28 | binder: avoid user addresses in debug logsdrivers/ drivers/ | +8 | 1 reply | |
| 27/28 | binder: reverse locking order in shrinker callbackdrivers/ | +22 | 4 replies | |
| 28/28 | binder: switch alloc->mutex to spinlock_tdrivers/ drivers/ | +28 | 0 replies |
Reviews trailers per patch
27 of 28 patches have a Reviewed-by or Acked-by.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/28] binder: convert alloc->mutex to spinlock
This series refactors the binder buffer allocation space to be able to convert the alloc->mutex into a spinlock. Doing so decreases the latency of binder transactions seen under worst-case scenarios.
I attempted to organize and improve readability of things that were touched during this process. I also include a couple of fixes (unrelated to the lock conversion) for issues I found along the way.
Regards,
Carlos Llamas
v2:
- New fix for wasted alloc->free_sync_space calculation
- Fix issues pointed out by Alice: incorrect size overflow check, data race in buffer->async_transaction, reorder of __free_page(page) and new_buffer leak in some error paths.
- Better naming and comments to accommodate the new scope of things e.g. binder_lru_freelist_add() and binder_install_single_page().
- Dropped patch ("binder: do not add pages to LRU in release path") since it is not worth the added complexity.
- Avoid _new_ logs of unhashed userspace addresses.
- More minor cosmeting changes.
- Add Reviewed-by tags.
v1:
https://lore.kernel.org/all/[email protected]/
Carlos Llamas (28):
binder: use EPOLLERR from eventpoll.h
binder: fix use-after-free in shinker's callback
binder: fix race between mmput() and do_exit()
binder: fix async space check for 0-sized buffers
binder: fix unused alloc->free_async_space
binder: fix trivial typo of binder_free_buf_locked()
binder: fix comment on binder_alloc_new_buf() return value
binder: remove extern from function prototypes
binder: keep vma addresses type as unsigned long
binder: split up binder_update_page_range()
binder: do unlocked work in binder_alloc_new_buf()
binder: remove pid param in binder_alloc_new_buf()
binder: separate the no-space debugging logic
binder: relocate low space calculation
binder: relocate binder_alloc_clear_buf()
binder: refactor page range allocation
binder: malloc new_buffer outside of locks
binder: initialize lru pages in mmap callback
binder: perform page installation outside of locks
binder: remove redundant debug log
binder: make oversized buffer code more readable
binder: rename lru shrinker utilities
binder: document the final page calculation
binder: collapse print_binder_buffer() into caller
binder: refactor binder_delete_free_buffer()
binder: avoid user addresses in debug logs
binder: reverse locking order in shrinker callback
binder: switch alloc->mutex to spinlock_t
drivers/android/binder.c | 27 +- drivers/android/binder_alloc.c | 858 ++++++++++++------------ drivers/android/binder_alloc.h | 61 +- drivers/android/binder_alloc_selftest.c | 14 +- drivers/android/binder_trace.h | 2 +- 5 files changed, 489 insertions(+), 473 deletions(-)
base-commit: 994d5c58e50e91bb02c7be4a91d5186292a895c8
Signature · 1 line
2.43.0.rc2.451.g8631bc7472-goog