Skip to content

perf annotate: Reduce memory footprint (v1)

Namhyung Kim linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf annotate: Split struct cycles_infotools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+30 -202 replies
2/5perf annotate: Split struct annotated_branchtools/perf/util/annotate.c tools/perf/util/annotate.h tools/perf/util/block-info.c +1 more+72 -602 replies
3/5perf annotate: Move max_coverage to annotated_branchtools/perf/builtin-annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h +1 more+15 -51 reply
4/5perf annotate: Move some fields to annotated_sourcetools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+22 -213 replies
5/5perf annotate: Move offsets to annotated_sourcetools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+12 -121 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchIan Rogers
1/5
2/5
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/5] perf annotate: Reduce memory footprint (v1)

Hello,

This is a part of my work to improve perf annotate. At first, I'd like reduce the size of struct annotation which will be allocated together with struct symbol in some cases. In fact, it doesn't use most of them so it needs to slim down and lazy-allocate used part.

With this applied, size of the struct goes down from 96 to 48.

The code is available at perf/annotate-diet-v1 branch in

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (5):
perf annotate: Split struct cycles_info perf annotate: Split struct annotated_branch perf annotate: Move max_coverage to annotated_branch perf annotate: Move some fields to annotated_source perf annotate: Move offsets to annotated_source

 tools/perf/builtin-annotate.c     |   7 +-
 tools/perf/ui/browsers/annotate.c |  18 ++--
 tools/perf/util/annotate.c        | 162 ++++++++++++++++--------------
 tools/perf/util/annotate.h        |  49 +++++----
 tools/perf/util/block-info.c      |   4 +-
 tools/perf/util/block-range.c     |   7 +-
 tools/perf/util/sort.c            |  14 +--
 7 files changed, 147 insertions(+), 114 deletions(-)
Signature · 1 line
2.42.0.869.gea05f2083d-goog