Skip to content

RDMA/rxe: Make multicast work

Bob Pearson linux-rdma netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 6 repliesIn review
  2. v57 patches 13 repliesSuperseded
  3. v47 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches0 repliesSuperseded
v26 patches0 repliesSuperseded
v16 patches6 repliesSuperseded

Changes in v6 from the cover letter

Replace spin_(un)lock_bh(&sk->sk_lock.slock) by lock(release)_sock(sk) to address comment by Rain River.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7RDMA/rxe: Cleanup rxe_ah/av_chk_attrdrivers/infiniband/sw/rxe/rxe_av.c drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_qp.c +1 more+12 -430 replies
2/7RDMA/rxe: Fix sending of mcast packetsdrivers/infiniband/sw/rxe/rxe_av.c drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_net.c +3 more+25 -40 replies
3/7RDMA/rxe: Register IP mcast addressdrivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_net.c drivers/infiniband/sw/rxe/rxe_net.h +1 more+102 -216 replies
4/7RDMA/rxe: Let rxe_lookup_mcg use rcu_read_lockdrivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_verbs.h+21 -390 replies
5/7RDMA/rxe: Split multicast lockdrivers/infiniband/sw/rxe/rxe.c drivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_recv.c +1 more+105 -1590 replies
6/7RDMA/rxe: Cleanup mcg lifetimedrivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_recv.c+46 -1280 replies
7/7RDMA/rxe: Add module parameters for mcast limitsdrivers/infiniband/sw/rxe/Makefile drivers/infiniband/sw/rxe/rxe.c drivers/infiniband/sw/rxe/rxe_param.c +1 more+32 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH for-next v6 0/7] RDMA/rxe: Make multicast work

After developing a test program which exercises node to node testing of RoCE multicast it became clear that there are a number of issues with the current rdma_rxe multicast implementation.

The issues seen include:
- There is no support for IPV4 multicast addresses.
- Once a multicast MAC is added it is not removed.
- Multicast packets are sent with the wrong QP number.
- Multicast IP addresses are not created and without them no multicast packets received on the interface are delivered to the rdma_rxe driver.
- The implementation in rxe_mcast.c is potentially racy if multiple simultaneous attach/detach operations are issued.

This patch set fixes these issues.

Copied to the netdev list. Please review patch 3/7 which interfaces with the netdev stack to create the IP mcast endpoints that support the RDMA mcast endpoints.
---
v6:
Replace spin_(un)lock_bh(&sk->sk_lock.slock) by lock(release)_sock(sk) to address comment by Rain River.
v5:
Missed previous fix in error path. Add sock lock around ipv6_sock_mm_drop() in rxe_mcast_add6().
v4:
Corrected a lockdep bug reported by Zhu Yanjun.
v3:
Removed rxe_loop_and_send(). It turns out it is not needed. Added module parameters to set mcast limits to small values when driver is loaded to enable mcast limit testing.
Rebased to current for-next branch.
v2:
Respond to comments by Zhu.
Added more Fixes lines.
Added some more explanation in the commit messages.
Fixed an error in rxe_lookup_mcg. Should have checked
the return from rxe_get_mcg().

Bob Pearson (7):
RDMA/rxe: Cleanup rxe_ah/av_chk_attr RDMA/rxe: Fix sending of mcast packets RDMA/rxe: Register IP mcast address RDMA/rxe: Let rxe_lookup_mcg use rcu_read_lock RDMA/rxe: Split multicast lock
RDMA/rxe: Cleanup mcg lifetime
RDMA/rxe: Add module parameters for mcast limits

 drivers/infiniband/sw/rxe/Makefile     |   3 +-
 drivers/infiniband/sw/rxe/rxe.c        |   8 +-
 drivers/infiniband/sw/rxe/rxe_av.c     |  50 +--
 drivers/infiniband/sw/rxe/rxe_loc.h    |   6 +-
 drivers/infiniband/sw/rxe/rxe_mcast.c  | 526 +++++++++++--------------
 drivers/infiniband/sw/rxe/rxe_net.c    |   6 +-
 drivers/infiniband/sw/rxe/rxe_net.h    |   1 +
 drivers/infiniband/sw/rxe/rxe_opcode.h |   2 +-
 drivers/infiniband/sw/rxe/rxe_param.c  |  23 ++
 drivers/infiniband/sw/rxe/rxe_param.h  |   4 +
 drivers/infiniband/sw/rxe/rxe_qp.c     |   4 +-
 drivers/infiniband/sw/rxe/rxe_recv.c   |  11 +-
 drivers/infiniband/sw/rxe/rxe_req.c    |  11 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c  |   5 +-
 drivers/infiniband/sw/rxe/rxe_verbs.h  |   5 +-
 15 files changed, 305 insertions(+), 360 deletions(-)
 create mode 100644 drivers/infiniband/sw/rxe/rxe_param.c
Signature · 1 line
2.40.1