Skip to content

io_uring: mshot read fix for buffer size changes

Dylan Yudaken io-uring 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v12 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- apply comments
- add a patch for io_kbuf_recycle to show if it did anything

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3io_uring: indicate if io_kbuf_recycle did recycle anythingio_uring/kbuf.c io_uring/kbuf.h+11 -80 replies
2/3io_uring: do not allow multishot read to set addr or lenio_uring/rw.c+4 -00 replies
3/3io_uring: do not clamp read length for multishot readio_uring/rw.c+8 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] io_uring: mshot read fix for buffer size changes

Hi,

This series fixes a bug (see [1] for liburing patch) where the used buffer size is clamped to the minimum of all the previous buffers selected.

It also as part of this forces the multishot read API to set addr & len to 0.
len should probably have some accounting post-processing if it has meaning to set it to non-zero, but I think for a new API it is simpler to overly-constrain it upfront?

addr is useful to force to zero as it will allow some more bits to be used in struct io_rw, which is otherwise full.

v2:
- apply comments
- add a patch for io_kbuf_recycle to show if it did anything

[1]: https://github.com/axboe/liburing/pull/981

Dylan Yudaken (3):
io_uring: indicate if io_kbuf_recycle did recycle anything
io_uring: do not allow multishot read to set addr or len
io_uring: do not clamp read length for multishot read

 io_uring/kbuf.c |  6 +++---
 io_uring/kbuf.h | 13 ++++++++-----
 io_uring/rw.c   | 13 ++++++++++++-
 3 files changed, 23 insertions(+), 9 deletions(-)

base-commit: f688944cfb810986c626cb13d95bc666e5c8a36c

Signature · 1 line
2.41.0