Skip to content

RFC Support multiple KVM modules on the same host

Anish Ghulati kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest14 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14KVM: x86: Move common module params from SVM/VMX to x86arch/x86/kvm/svm/nested.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h +3 more+23 -270 replies
2/14KVM: x86: Fold x86 vendor modules into the main KVM modulesarch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kernel/nmi.c +6 more+82 -820 replies
3/14KVM: x86: Remove unused exportsarch/x86/kvm/cpuid.c arch/x86/kvm/hyperv.c arch/x86/kvm/irq.c +8 more+0 -1910 replies
4/14KVM: x86: Create stubs for a new VAC modulearch/x86/kvm/Makefile arch/x86/kvm/svm/vac.c arch/x86/kvm/vac.c +5 more+25 -00 replies
5/14KVM: x86: Refactor hardware enable/disable operations into a new filevirt/kvm/kvm_main.c virt/kvm/vac.c virt/kvm/vac.h+204 -1960 replies
6/14KVM: x86: Move user return msr operations out of KVMarch/x86/include/asm/kvm_host.h arch/x86/kvm/cpuid.c arch/x86/kvm/svm/svm.c +4 more+173 -1470 replies
7/14KVM: SVM: Move shared SVM data structures into VACarch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h arch/x86/kvm/svm/vac.c +1 more+37 -160 replies
8/14KVM: VMX: Move shared VMX data structures into VACarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/vac.c arch/x86/kvm/vmx/vac.h +2 more+65 -380 replies
9/14KVM: x86: Move shared KVM state into VACvirt/kvm/kvm_main.c virt/kvm/vac.c virt/kvm/vac.h+12 -22 replies
10/14KVM: VMX: Move VMX enable and disable into VACarch/x86/kvm/vac.h arch/x86/kvm/vmx/vac.c arch/x86/kvm/vmx/vac.h +1 more+219 -1740 replies
11/14KVM: SVM: Move SVM enable and disable into VACarch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h +5 more+175 -1390 replies
12/14KVM: x86: Move VMX and SVM support checks into VACarch/x86/kvm/svm/svm.c arch/x86/kvm/svm/vac.c arch/x86/kvm/vac.h +3 more+78 -800 replies
13/14KVM: x86: VAC: Move all hardware enable/disable code into VACarch/x86/include/asm/kvm-x86-ops.h arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm_ops.h +8 more+58 -1310 replies
14/14KVM: VAC: Bring up VAC as a new modulearch/x86/kvm/Kconfig arch/x86/kvm/Makefile arch/x86/kvm/svm/svm.c +11 more+128 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/14] Support multiple KVM modules on the same host

This series is a rough, PoC-quality RFC to allow (un)loading and running multiple KVM modules simultaneously on a single host, e.g. to deploy fixes, mitigations, and/or new features without having to drain all VMs from the host. Multi-KVM will also allow running the "same" KVM module with different params, e.g. to run trusted VMs with different mitigations.

The goal of this RFC is to get feedback on the idea itself and the high-level approach. In particular, we're looking for input on:

- Combining kvm_intel.ko and kvm_amd.ko into kvm.ko
- Exposing multiple /dev/kvmX devices via Kconfig
- The name and prefix of the new base module

Feedback on individual patches is also welcome, but please keep in mind that this is very much a work in-progress

This builds on Sean's series to hide KVM internals:

    https://lore.kernel.org/lkml/[email protected]

The whole thing can be found at:

    https://github.com/asg-17/linux vac-rfc

The basic gist of the approach is to:

- Move system-wide virtualization resource management to a new base module to avoid collisions between different KVM modules, e.g. VPIDs and ASIDs need to be unique per VM, and callbacks from IRQ handlers need to be mediated so that things like PMIs get to the right KVM instance.

- Refactor KVM to make all upgradable assets visible only to KVM, i.e. make KVM a black box, so that the layout/size of things like "struct kvm_vcpu" isn't exposed to the kernel at-large.

- Fold kvm_intel.ko and kvm_amd.ko into kvm.ko to avoid complications having to generate unique symbols for every symbol exported by kvm.ko.

- Add a Kconfig string to allow defining a device and module postfix at build time, e.g. to create kvmX.ko and /dev/kvmX.

The proposed name of the new base module is vac.ko, a.k.a. Virtualization Acceleration Code (Unupgradable Units Module). Childish humor aside, "vac" is a unique name in the kernel and hopefully in x86 and hardware terminology, is a unique name in the kernel and hopefully in x86 and hardware terminology, e.g. git grep vac_ yields no hits in the kernel. It also has the same number of characters as "kvm", e.g. the namespace can be modified without needing whitespace adjustment if we want to go that route.

Requirements / Goals / Notes:
- Fully opt-in and backwards compatible (except for the disappearance of kvm_{amd,intel}.ko).

- User space ultimately controls and is responsible for deployment, usage, lifecycles, etc. Standard module refcounting applies, but ensuruing that a VM is created with the "right" KVM module is a user space problem.

- No user space *VMM* changes are required, e.g. /dev/kvm can be presented to a VMM by symlinking /dev/kvmX.

- Mutually exclusive with subsytems that have a hard dependency on KVM, i.e. KVMGT.

- x86 only (for the foreseeable future).

Anish Ghulati (13):
KVM: x86: Move common module params from SVM/VMX to x86
KVM: x86: Fold x86 vendor modules into the main KVM modules
KVM: x86: Remove unused exports
KVM: x86: Create stubs for a new VAC module
KVM: x86: Refactor hardware enable/disable operations into a new file
KVM: x86: Move user return msr operations out of KVM
KVM: SVM: Move shared SVM data structures into VAC
KVM: VMX: Move shared VMX data structures into VAC
KVM: VMX: Move VMX enable and disable into VAC
KVM: SVM: Move SVM enable and disable into VAC
KVM: x86: Move VMX and SVM support checks into VAC
KVM: x86: VAC: Move all hardware enable/disable code into VAC
KVM: VAC: Bring up VAC as a new module

Venkatesh Srinivas (1):
KVM: x86: Move shared KVM state into VAC

 arch/x86/include/asm/kvm-x86-ops.h |   3 +-
 arch/x86/include/asm/kvm_host.h    |  12 +-
 arch/x86/kernel/nmi.c              |   2 +-
 arch/x86/kvm/Kconfig               |  29 +-
 arch/x86/kvm/Makefile              |  31 ++-
 arch/x86/kvm/cpuid.c               |   8 +-
 arch/x86/kvm/hyperv.c              |   2 -
 arch/x86/kvm/irq.c                 |   3 -
 arch/x86/kvm/irq_comm.c            |   2 -
 arch/x86/kvm/kvm_onhyperv.c        |   3 -
 arch/x86/kvm/lapic.c               |  15 -
 arch/x86/kvm/mmu/mmu.c             |  12 -
 arch/x86/kvm/mmu/spte.c            |   4 -
 arch/x86/kvm/mtrr.c                |   1 -
 arch/x86/kvm/pmu.c                 |   2 -
 arch/x86/kvm/svm/nested.c          |   4 +-
 arch/x86/kvm/svm/sev.c             |   2 +-
 arch/x86/kvm/svm/svm.c             | 224 ++-------------
 arch/x86/kvm/svm/svm.h             |  21 +-
 arch/x86/kvm/svm/svm_data.h        |  23 ++
 arch/x86/kvm/svm/svm_ops.h         |   1 +
 arch/x86/kvm/svm/vac.c             | 172 ++++++++++++
 arch/x86/kvm/svm/vac.h             |  20 ++
 arch/x86/kvm/vac.c                 | 214 +++++++++++++++
 arch/x86/kvm/vac.h                 |  69 +++++
 arch/x86/kvm/vmx/nested.c          |   6 +-
 arch/x86/kvm/vmx/vac.c             | 287 +++++++++++++++++++
 arch/x86/kvm/vmx/vac.h             |  20 ++
 arch/x86/kvm/vmx/vmx.c             | 332 +++-------------------
 arch/x86/kvm/vmx/vmx.h             |   2 -
 arch/x86/kvm/vmx/vmx_ops.h         |   1 +
 arch/x86/kvm/x86.c                 | 423 ++---------------------------
 arch/x86/kvm/x86.h                 |  15 +-
 include/linux/kvm_host.h           |   2 +
 virt/kvm/Makefile.kvm              |  14 +-
 virt/kvm/kvm_main.c                | 210 +-------------
 virt/kvm/vac.c                     | 192 +++++++++++++
 virt/kvm/vac.h                     |  40 +++
 38 files changed, 1212 insertions(+), 1211 deletions(-)
 create mode 100644 arch/x86/kvm/svm/svm_data.h
 create mode 100644 arch/x86/kvm/svm/vac.c
 create mode 100644 arch/x86/kvm/svm/vac.h
 create mode 100644 arch/x86/kvm/vac.c
 create mode 100644 arch/x86/kvm/vac.h
 create mode 100644 arch/x86/kvm/vmx/vac.c
 create mode 100644 arch/x86/kvm/vmx/vac.h
 create mode 100644 virt/kvm/vac.c
 create mode 100644 virt/kvm/vac.h

base-commit: 0b78fc46e5450f08ef92431e569c797a63f31517

Signature · 1 line
2.42.0.869.gea05f2083d-goog