Use V4L2 CCI in CCS driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 0 repliesNew
- v36 patches 4 repliesSuperseded
- v26 patches 8 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 17 replies | Superseded |
Changes in v4 from the cover letter
- Drop unintended changes to make newly added macros in v4l2-cci.h signed again.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | media: v4l: cci: Include linux/bits.hinclude/ | +1 | 0 replies | |
| 2/6 | media: v4l: cci: Add driver-private bit definitionsinclude/ | +5 | 0 replies | |
| 3/6 | media: v4l: cci: Add macros to obtain register width and addressdrivers/ include/ | +9 | 0 replies | |
| 4/6 | media: ccs: Generate V4L2 CCI compliant register definitionsDocumentation/ | +75 | 0 replies | |
| 5/6 | media: ccs: Better separate CCS static data accessdrivers/ | +11 | 0 replies | |
| 6/6 | media: ccs: Use V4L2 CCI for accessing sensor registersdrivers/ drivers/ drivers/ +2 more | +999 | 0 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Hans de Goede | Laurent Pinchart |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/6] Use V4L2 CCI in CCS driver
Hi folks,
This set adds a few features to the V4L2 CCI library and makes the CCS driver use V4L2 CCI.
The additional features are about storing driver specific information in the CCI registers (besides register address) and obtaining register address and width using convenient V4L2 CCI macros.
since v3:
- Drop unintended changes to make newly added macros in v4l2-cci.h signed again.
since v2:
- Rename CCS static data read-only register access function.
- Fix ccs-regs.h generation to include all changes in the 4th patch (some had slipped into the 5th).
since v1:
- Fix two SMIAPP register definitions using misspelled CCI macro names.
- Add macros using FIELD_GET() to obtain CCI register address and width, use the macros in V4L2 CCI.
- Use _SHIFT and _MASK for private register range.
- Check CCS driver's private flags only cover driver-private bits of the CCI register definition, using BUILD_BUG_ON().
- Fix CCS CCI register macro generation (register address vs. flag vs. array indices).
- Use a nicer way to check for the guardian value in the limit array, i.e. don't pass the value unconditionally to CCI_REG_WIDTH_BYTES().
- Include linux/bits.h and media/v4l2-cci.h in smiapp-reg-defs.h.
- Improve commit message of the CCS static data register access function rename patch.
Sakari Ailus (6):
media: v4l: cci: Include linux/bits.h
media: v4l: cci: Add driver-private bit definitions
media: v4l: cci: Add macros to obtain register width and address
media: ccs: Generate V4L2 CCI compliant register definitions
media: ccs: Better separate CCS static data access
media: ccs: Use V4L2 CCI for accessing sensor registers
.../driver-api/media/drivers/ccs/mk-ccs-regs | 104 +- drivers/media/i2c/ccs/ccs-core.c | 84 +- drivers/media/i2c/ccs/ccs-reg-access.c | 213 +--- drivers/media/i2c/ccs/ccs-regs.h | 906 ++++++++--------- drivers/media/i2c/ccs/ccs.h | 2 + drivers/media/i2c/ccs/smiapp-reg-defs.h | 951 +++++++++--------- drivers/media/v4l2-core/v4l2-cci.c | 8 +- include/media/v4l2-cci.h | 11 + 8 files changed, 1100 insertions(+), 1179 deletions(-)
base-commit: 62bdf633090d684c3ac6d3b46e926c0ac8cef466
Signature · 1 line
2.39.2