Skip to content

Add powernv10 I2C devices and tests

Glenn Miles qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest9 patches 5 repliesIn review
  2. v69 patches 1 replySuperseded
  3. v59 patches 9 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v411 patches17 repliesSuperseded
v38 patches11 repliesApplied
v28 patches8 repliesSuperseded
v18 patches1 replySuperseded

Changes from previous version from the cover letter

- Made several changes to commit 9/9 to address comments from Cédric.
- Added new PnvI2cCtlr struct to commit 9/9 for convenience in passing parameters.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9misc/pca9552: Fix inverted input statushw/misc/pca9552.c tests/qtest/pca9552-test.c+16 -80 replies
2/9misc/pca9552: Let external devices set pca9552 inputshw/misc/pca9552.c include/hw/misc/pca9552.h+45 -80 replies
3/9ppc/pnv: New powernv10-rainier machine typehw/ppc/pnv.c+22 -20 replies
4/9ppc/pnv: Add pca9552 to powernv10-rainier for PCIe hotplug power controlhw/ppc/Kconfig hw/ppc/pnv.c include/hw/ppc/pnv.h+27 -00 replies
5/9ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power controlhw/ppc/pnv.c+13 -10 replies
6/9ppc/pnv: Use resettable interface to reset child I2C buseshw/ppc/pnv_i2c.c+14 -10 replies
7/9misc: Add a pca9554 GPIO device modelMAINTAINERS hw/misc/pca9554.c include/hw/misc/pca9554.h +1 more+391 -24 replies
8/9ppc/pnv: Add a pca9554 I2C device to powernv10-rainierhw/misc/Kconfig hw/misc/meson.build hw/ppc/Kconfig +1 more+12 -00 replies
9/9ppc/pnv: Test pnv i2c master and connected deviceshw/ppc/pnv_i2c.c include/hw/i2c/pnv_i2c_regs.h tests/qtest/meson.build +3 more+717 -1901 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAndrew JefferyCédric Le Goater
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/9] Add powernv10 I2C devices and tests

This series of patches includes support, tests and fixes for adding PCA9552 and PCA9554 I2C devices to the powernv10 chip.

The PCA9552 device is used for PCIe slot hotplug power control and monitoring, while the PCA9554 device is used for presence detection of IBM CableCard devices. Both devices are required by the Power Hypervisor Firmware on the Power10 Ranier platform.

Changes from previous version:
- Made several changes to commit 9/9 to address comments from Cédric.
- Added new PnvI2cCtlr struct to commit 9/9 for convenience in passing parameters.

Glenn Miles (9):
misc/pca9552: Fix inverted input status
misc/pca9552: Let external devices set pca9552 inputs ppc/pnv: New powernv10-rainier machine type
ppc/pnv: Add pca9552 to powernv10-rainier for PCIe hotplug power
control
ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power control ppc/pnv: Use resettable interface to reset child I2C buses
misc: Add a pca9554 GPIO device model
ppc/pnv: Add a pca9554 I2C device to powernv10-rainier ppc/pnv: Test pnv i2c master and connected devices

 MAINTAINERS                     |  10 +-
 hw/misc/Kconfig                 |   4 +
 hw/misc/meson.build             |   1 +
 hw/misc/pca9552.c               |  58 +++-
 hw/misc/pca9554.c               | 328 +++++++++++++++++++++
 hw/ppc/Kconfig                  |   2 +
 hw/ppc/pnv.c                    |  67 ++++-
 hw/ppc/pnv_i2c.c                | 146 +---------
 include/hw/i2c/pnv_i2c_regs.h   | 143 ++++++++++
 include/hw/misc/pca9552.h       |   3 +-
 include/hw/misc/pca9554.h       |  36 +++
 include/hw/misc/pca9554_regs.h  |  19 ++
 include/hw/ppc/pnv.h            |   1 +
 tests/qtest/meson.build         |   1 +
 tests/qtest/pca9552-test.c      |   6 +-
 tests/qtest/pnv-host-i2c-test.c | 491 ++++++++++++++++++++++++++++++++
 tests/qtest/pnv-xscom-test.c    |  61 +---
 tests/qtest/pnv-xscom.h         |  80 ++++++
 18 files changed, 1251 insertions(+), 206 deletions(-)
 create mode 100644 hw/misc/pca9554.c
 create mode 100644 include/hw/i2c/pnv_i2c_regs.h
 create mode 100644 include/hw/misc/pca9554.h
 create mode 100644 include/hw/misc/pca9554_regs.h
 create mode 100644 tests/qtest/pnv-host-i2c-test.c
 create mode 100644 tests/qtest/pnv-xscom.h
Signature · 1 line
2.31.1