kmsan: Enable on s390
Status from this message: [merged mm-stable] kmsan-enable-on-s390.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest38 patches 2 repliesApplied 38/38
- v639 patches 3 repliesSuperseded
- v537 patches 13 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 35 patches | 16 replies | Superseded | |
| v3 | 34 patches | 21 replies | Superseded | |
| v2 | 33 patches | 36 replies | Superseded | |
| v1 | 32 patches | 22 replies | Superseded |
Patches in v7 All 38 applied
Reviews trailers per patch
All 38 patches have a Reviewed-by or Acked-by.
| Patch | Alexander Potapenko | Steven Rostedt (Google) | Vlastimil Babka | Alexander Gordeev | Heiko Carstens |
|---|---|---|---|---|---|
| 1/38 | R-b | A-b | |||
| 2/38 | R-b | ||||
| 3/38 | R-b | ||||
| 4/38 | R-b | ||||
| 5/38 | R-b | ||||
| 6/38 | R-b | ||||
| 7/38 | R-b | ||||
| 8/38 | R-b | ||||
| 9/38 | R-b | ||||
| 10/38 | R-b | ||||
| 11/38 | R-b | ||||
| 12/38 | R-b | ||||
| 13/38 | R-b | ||||
| 14/38 | R-b | ||||
| 15/38 | R-b | ||||
| 16/38 | R-b | ||||
| 17/38 | R-b | A-b | |||
| 18/38 | R-b | A-b | |||
| 19/38 | R-b T-b | ||||
| 20/38 | R-b | ||||
| 21/38 | R-b | ||||
| 22/38 | R-b | R-b | |||
| 23/38 | R-b | R-b | |||
| 24/38 | R-b | ||||
| 25/38 | R-b | A-b | |||
| 26/38 | R-b | T-b | A-b | ||
| 27/38 | R-b | A-b | |||
| 28/38 | R-b | ||||
| 29/38 | R-b | A-b | |||
| 30/38 | R-b | ||||
| 31/38 | R-b | A-b | A-b | ||
| 32/38 | R-b | A-b | |||
| 33/38 | R-b | A-b | |||
| 34/38 | R-b | A-b | |||
| 35/38 | R-b | ||||
| 36/38 | R-b | A-b | |||
| 37/38 | R-b | A-b | |||
| 38/38 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v7 00/38] kmsan: Enable on s390
v6: https://lore.kernel.org/lkml/[email protected]/
v6 -> v7: Drop the ptdump patch.
All patches are reviewed.
v5: https://lore.kernel.org/lkml/[email protected]/
v5 -> v6: Include KMSAN vmalloc areas in page table dump.
Fix doc comments; use KMSAN_WARN_ON (Alexander P.). Patches that need review:
- [PATCH 16/39] kmsan: Expose KMSAN_WARN_ON()
- [PATCH 32/39] s390/ptdump: Add KMSAN page markers
v4: https://lore.kernel.org/lkml/[email protected]/
v4 -> v5: Fix the __memset() build issue.
Change the attribute #defines to lowercase in order to match the existing code style.
Fix the kmsan_virt_addr_valid() implementation to avoid recursion in debug builds, like it's done on x86_64 - dropped R-bs, please take another look.
Add kmsan_disable_current()/kmsan_enable_current() doc;
Fix the poisoned memchr_inv() value in a different way;
Add the missing linux/instrumented.h #include;
(Alexander P.).
Patches that need review:
- [PATCH 12/37] kmsan: Introduce memset_no_sanitize_memory()
- [PATCH 13/37] kmsan: Support SLAB_POISON
- [PATCH 17/37] mm: slub: Disable KMSAN when checking the padding bytes
- [PATCH 36/37] s390/kmsan: Implement the architecture-specific functions
v3: https://lore.kernel.org/lkml/[email protected]/
v3 -> v4: Rebase.
Elaborate why ftrace_ops_list_func() change is needed on x64_64 (Steven).
Add a comment to the DFLTCC patch (Alexander P.). Simplify diag224();
Improve __arch_local_irq_attributes style;
Use IS_ENABLED(CONFIG_KMSAN) for vmalloc area (Heiko). Align vmalloc area on _SEGMENT_SIZE (Alexander G.).
v2: https://lore.kernel.org/lkml/[email protected]/
v2 -> v3: Drop kmsan_memmove_metadata() and strlcpy() patches;
Remove kmsan_get_metadata() stub;
Move kmsan_enable_current() and kmsan_disable_current() to include/linux/kmsan.h, explain why a counter is needed; Drop the memset_no_sanitize_memory() patch;
Use __memset() in the SLAB_POISON patch;
Add kmsan-checks.h to the DFLTCC patch;
Add recursion check to the arch_kmsan_get_meta_or_null() patch (Alexander P.).
Fix inline + __no_kmsan_checks issues.
New patch for s390/irqflags, that resolves a lockdep warning. New patch for s390/diag, that resolves a false positive when running on an LPAR.
New patch for STCCTM, same as above.
New patch for check_bytes_and_report() that resolves a false positive that occurs even on Intel.
v1: https://lore.kernel.org/lkml/[email protected]/
v1 -> v2: Add comments, sort #includes, introduce
memset_no_sanitize_memory() and use it to avoid unpoisoning of redzones, change vmalloc alignment to _REGION3_SIZE, add R-bs (Alexander P.).
Fix building
[PATCH 28/33] s390/string: Add KMSAN support with FORTIFY_SOURCE.
Hi,
This series provides the minimal support for Kernel Memory Sanitizer on s390. Kernel Memory Sanitizer is clang-only instrumentation for finding accesses to uninitialized memory. The clang support for s390 has already been merged [1].
With this series, I can successfully boot s390 defconfig and debug_defconfig with kmsan.panic=1. The tool found one real s390-specific bug (fixed in master).
Best regards,
Ilya
[1] https://reviews.llvm.org/D148596
Ilya Leoshkevich (38):
ftrace: Unpoison ftrace_regs in ftrace_ops_list_func()
kmsan: Make the tests compatible with kmsan.panic=1
kmsan: Disable KMSAN when DEFERRED_STRUCT_PAGE_INIT is enabled
kmsan: Increase the maximum store size to 4096
kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces
kmsan: Fix kmsan_copy_to_user() on arches with overlapping address
spaces
kmsan: Remove a useless assignment from
kmsan_vmap_pages_range_noflush()
kmsan: Remove an x86-specific #include from kmsan.h
kmsan: Expose kmsan_get_metadata()
kmsan: Export panic_on_kmsan
kmsan: Allow disabling KMSAN checks for the current task
kmsan: Introduce memset_no_sanitize_memory()
kmsan: Support SLAB_POISON
kmsan: Use ALIGN_DOWN() in kmsan_get_metadata()
kmsan: Do not round up pg_data_t size
kmsan: Expose KMSAN_WARN_ON()
mm: slub: Let KMSAN access metadata
mm: slub: Disable KMSAN when checking the padding bytes
mm: kfence: Disable KMSAN when checking the canary lib/zlib: Unpoison DFLTCC output buffers
kmsan: Accept ranges starting with 0 on s390
s390/boot: Turn off KMSAN
s390: Use a larger stack for KMSAN
s390/boot: Add the KMSAN runtime stub
s390/checksum: Add a KMSAN check
s390/cpacf: Unpoison the results of cpacf_trng() s390/cpumf: Unpoison STCCTM output buffer
s390/diag: Unpoison diag224() output buffer
s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN s390/mm: Define KMSAN metadata for vmalloc and modules s390/string: Add KMSAN support
s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs s390/uaccess: Add KMSAN support to put_user() and get_user() s390/uaccess: Add the missing linux/instrumented.h #include s390/unwind: Disable KMSAN checks
s390/kmsan: Implement the architecture-specific functions
kmsan: Enable on s390
Documentation/dev-tools/kmsan.rst | 11 ++- arch/s390/Kconfig | 1 + arch/s390/Makefile | 2 +- arch/s390/boot/Makefile | 3 + arch/s390/boot/kmsan.c | 6 ++ arch/s390/boot/startup.c | 7 ++ arch/s390/boot/string.c | 16 ++++ arch/s390/include/asm/checksum.h | 2 + arch/s390/include/asm/cpacf.h | 3 + arch/s390/include/asm/cpu_mf.h | 6 ++ arch/s390/include/asm/irqflags.h | 17 ++++- arch/s390/include/asm/kmsan.h | 59 +++++++++++++++ arch/s390/include/asm/pgtable.h | 12 +++ arch/s390/include/asm/string.h | 20 +++-- arch/s390/include/asm/thread_info.h | 2 +- arch/s390/include/asm/uaccess.h | 112 ++++++++++++++++++++-------- arch/s390/kernel/diag.c | 10 ++- arch/s390/kernel/ftrace.c | 2 + arch/s390/kernel/traps.c | 6 ++ arch/s390/kernel/unwind_bc.c | 4 + drivers/s390/char/sclp.c | 2 +- include/linux/kmsan.h | 76 +++++++++++++++++++ include/linux/kmsan_types.h | 2 +- kernel/trace/ftrace.c | 1 + lib/zlib_dfltcc/dfltcc.h | 1 + lib/zlib_dfltcc/dfltcc_util.h | 28 +++++++ mm/Kconfig | 1 + mm/kfence/core.c | 11 ++- mm/kmsan/core.c | 1 - mm/kmsan/hooks.c | 23 ++++-- mm/kmsan/init.c | 7 +- mm/kmsan/instrumentation.c | 11 +-- mm/kmsan/kmsan.h | 33 ++------ mm/kmsan/kmsan_test.c | 5 ++ mm/kmsan/report.c | 8 +- mm/kmsan/shadow.c | 9 +-- mm/slub.c | 33 ++++++-- tools/objtool/check.c | 2 + 38 files changed, 445 insertions(+), 110 deletions(-) create mode 100644 arch/s390/boot/kmsan.c create mode 100644 arch/s390/include/asm/kmsan.h
Signature · 1 line
2.45.1