Skip to content

Intel_fb.c refactoring

Jouni Högander intel-xe 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest9 patches 0 repliesNew
  2. v59 patches 2 repliesSuperseded
  3. v49 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches0 repliesSuperseded
v29 patches1 replySuperseded
v18 patches0 repliesSuperseded

Changes in v6 from the cover letter

- Patch 7. is now backported

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe changes"drivers/gpu/drm/i915/display/intel_fb.c+0 -150 replies
2/9fixup! FIXME: drm/i915/display: Remaining changes to make xe compiledrivers/gpu/drm/i915/display/intel_fb.c+17 -810 replies
3/9drm/i915/display: use intel_bo_to_drm_bo in intel_fb.cdrivers/gpu/drm/i915/display/intel_fb.c+6 -60 replies
4/9drm/i915/display: Convert intel_fb_modifier_to_tiling as non-staticdrivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb.h+22 -200 replies
5/9drm/i915/display: Handle invalid fb_modifier in intel_fb_modifier_to_tilingdrivers/gpu/drm/i915/display/intel_fb.c+8 -10 replies
6/9drm/i915/display: Split i915 specific code away from intel_fb.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb_bo.c +1 more+127 -630 replies
7/9drm/i915/display: Add intel_fb_bo_framebuffer_finidrivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb_bo.c drivers/gpu/drm/i915/display/intel_fb_bo.h+26 -130 replies
8/9fixup! drm/xe/display: Implement display supportdrivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h+16 -00 replies
9/9fixup! drm/xe/display: Implement display supportdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/display/intel_fb_bo.c drivers/gpu/drm/xe/display/intel_fb_bo.h+99 -00 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJani NikulaMaarten LankhorstVille Syrjälä
1/9A-b R-b
2/9A-b R-b
3/9A-b R-b R-b
4/9A-b R-b R-b
5/9A-b R-b R-b
6/9A-b R-b R-b
7/9A-b R-b R-b
8/9A-b R-b
9/9A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/9] Intel_fb.c refactoring

This patch set is refactoring intel_fb.c code to get rid of ifdefs. This is done by splitting i915 and Xe specific parts from intel_fb.c into their own source files.

Some ifdefs are tackled by adding definitions into Xe compatibility headers.

v6:
- Patch 7. is now backported
v5:
- s/user_mode_cmd/mode_cmd
- Fix typo intel_fb vs. intel_fb_bo
v4: Empty function instead of define
v3:
- intel_fb_bo_framebuffer_fini added
- xe_bo_get/put and unpin moved to intel_fb_bo_framebuffer_init/fini
v2: i915 changes are now backported

Cc Maarten Lankhorst <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Jani Nikula <[email protected]>

Jouni Högander (9):
Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe
changes"
fixup! FIXME: drm/i915/display: Remaining changes to make xe compile drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static drm/i915/display: Handle invalid fb_modifier in
intel_fb_modifier_to_tiling
drm/i915/display: Split i915 specific code away from intel_fb.c drm/i915/display: Add intel_fb_bo_framebuffer_fini
fixup! drm/xe/display: Implement display support
fixup! drm/xe/display: Implement display support

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_fb.c       | 247 +++++-------------
 drivers/gpu/drm/i915/display/intel_fb.h       |   2 +
 drivers/gpu/drm/i915/display/intel_fb_bo.c    |  97 +++++++
 drivers/gpu/drm/i915/display/intel_fb_bo.h    |  26 ++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 .../compat-i915-headers/gem/i915_gem_object.h |  16 ++
 drivers/gpu/drm/xe/display/intel_fb_bo.c      |  74 ++++++
 drivers/gpu/drm/xe/display/intel_fb_bo.h      |  24 ++
 9 files changed, 305 insertions(+), 183 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.h
 create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.c
 create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.h
Signature · 1 line
2.34.1