Skip to content

lockdep enhancements for bcachefs

Kent Overstreet linux-bcachefs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6locking/lockdep: lock_class_is_held()include/linux/lockdep.h kernel/locking/lockdep.c+24 -00 replies
2/6locking/lockdep: lockdep_set_no_check_recursion()include/linux/lockdep.h include/linux/lockdep_types.h kernel/locking/lockdep.c+33 -12 replies
3/6bcachefs: Assert that btree node locks aren't being leakedfs/bcachefs/btree_gc.c fs/bcachefs/btree_locking.c fs/bcachefs/btree_types.h+11 -00 replies
4/6bcachefs: Use lock_class_is_held() for btree locking assertsfs/bcachefs/btree_locking.c+0 -30 replies
5/6bcachefs: Check for btree locks held on transaction initfs/bcachefs/btree_iter.c+2 -00 replies
6/6bcachefs: Switch to lockdep_set_no_check_recursion()fs/bcachefs/btree_locking.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] lockdep enhancements for bcachefs

This adds:
- lockdep_set_no_check_recursion(), which allows lockdep checking for bcachefs six locks

bcachefs has a cycle detector for deadlock avoidance; there is no lock ordering for lockdep to check w.r.t. other btree node locks. However, we do want held btree node locks to be tracked, and lock ordering to be checked w.r.t. other locks.

- lock_class_is_held(), which we use for some extra locking assertion

We want to assert e.g. that we're not blocking on IO with btree node locks held.

Kent Overstreet (6):
locking/lockdep: lock_class_is_held() locking/lockdep: lockdep_set_no_check_recursion()
bcachefs: Assert that btree node locks aren't being leaked
bcachefs: Use lock_class_is_held() for btree locking asserts
bcachefs: Check for btree locks held on transaction init
bcachefs: Switch to lockdep_set_no_check_recursion()

 fs/bcachefs/btree_gc.c        |  3 +++
 fs/bcachefs/btree_iter.c      |  2 ++
 fs/bcachefs/btree_locking.c   | 14 ++++++++---
 fs/bcachefs/btree_types.h     |  1 +
 include/linux/lockdep.h       | 10 ++++++++
 include/linux/lockdep_types.h |  2 +-
 kernel/locking/lockdep.c      | 46 +++++++++++++++++++++++++++++++++++
 7 files changed, 73 insertions(+), 5 deletions(-)
Signature · 1 line
2.42.0